)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"31ac090ed60bf9d9ee0e4e24481fd60311a3e41d","unresolved":false,"context_lines":[{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        endpoints_link \u003d utils.get_endpoints_link(service)"},{"line_number":792,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":793,"context_line":"        try:"},{"line_number":794,"context_line":"            endpoint \u003d k8s.get(endpoints_link)"},{"line_number":795,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":796,"context_line":"            LOG.debug(\"Endpoint for Service %s not Found\", svc_name)"},{"line_number":797,"context_line":"            return"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        lbaas \u003d utils.get_lbaas_state(endpoint)"},{"line_number":800,"context_line":"        if not lbaas:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_ad385f3d","line":797,"range":{"start_line":793,"start_character":0,"end_line":797,"end_character":18},"updated":"2020-05-04 08:04:54.000000000","message":"If those pod resources are cleaned up, do we need to remove them from the exceptions made at the listeners to remove their access? like making the listeners admin status down? Otherwise if the ports are reused, the service can get access to them? Or those endpoints are supposed to be deleted as members anyway?","commit_id":"ecbf15a0ebf602ddbf153dd106688be7eb8dd043"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"735136e353769b2916ed74de62706f8853e9c834","unresolved":false,"context_lines":[{"line_number":790,"context_line":""},{"line_number":791,"context_line":"        endpoints_link \u003d utils.get_endpoints_link(service)"},{"line_number":792,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":793,"context_line":"        try:"},{"line_number":794,"context_line":"            endpoint \u003d k8s.get(endpoints_link)"},{"line_number":795,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":796,"context_line":"            LOG.debug(\"Endpoint for Service %s not Found\", svc_name)"},{"line_number":797,"context_line":"            return"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        lbaas \u003d utils.get_lbaas_state(endpoint)"},{"line_number":800,"context_line":"        if not lbaas:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_c503f772","line":797,"range":{"start_line":793,"start_character":0,"end_line":797,"end_character":18},"in_reply_to":"1f493fa4_ad385f3d","updated":"2020-05-04 19:11:42.000000000","message":"If there is no endpoint for the matched service I believe there is no point to attempt to update the listener ACL/LB SG as when an endpoint is deleted all the related load balancer resources are also deleted [1]. Or do you mean some other scenario?\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/handlers/lbaas.py#L227","commit_id":"ecbf15a0ebf602ddbf153dd106688be7eb8dd043"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c47a8a9def987721076b049403318d24952267f5","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        try:"},{"line_number":794,"context_line":"            endpoint \u003d k8s.get(endpoints_link)"},{"line_number":795,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":796,"context_line":"            LOG.debug(\"Endpoint not Found. Skipping LB SG update for\""},{"line_number":797,"context_line":"                      \"%s as the LB resources are not present\", lbaas_name)"},{"line_number":798,"context_line":"            return"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_1705d0c2","line":796,"range":{"start_line":796,"start_character":23,"end_line":796,"end_character":31},"updated":"2020-05-07 14:44:26.000000000","message":"The object is called \"Endpoints\".","commit_id":"c7d798a45c028863b6d7f32b1b1351a928e5850e"}]}