)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"fbf12bcdaa1f6e77a96d8b10a90e180738697d92","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            vip_port \u003d self._get_vip_port(loadbalancer)"},{"line_number":176,"context_line":"            os_net.update_port(vip_port.id, security_groups\u003d[sg.id])"},{"line_number":177,"context_line":"            sg_id \u003d sg.id"},{"line_number":178,"context_line":"            loadbalancer.security_groups \u003d [sg.id]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            os_net.create_security_group_rule(direction\u003d\u0027ingress\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_dc3581aa","line":178,"range":{"start_line":178,"start_character":12,"end_line":178,"end_character":50},"updated":"2020-05-25 07:55:09.000000000","message":"what is the difference with line 174?","commit_id":"08e3b3eea1e44c3e988726bbd892ee66e2f43cdc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"fbf12bcdaa1f6e77a96d8b10a90e180738697d92","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            sg_id \u003d sg.id"},{"line_number":178,"context_line":"            loadbalancer.security_groups \u003d [sg.id]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        try:"},{"line_number":181,"context_line":"            os_net.create_security_group_rule(direction\u003d\u0027ingress\u0027,"},{"line_number":182,"context_line":"                                              port_range_min\u003dlistener.port,"},{"line_number":183,"context_line":"                                              port_range_max\u003dlistener.port,"},{"line_number":184,"context_line":"                                              protocol\u003dlistener.protocol,"},{"line_number":185,"context_line":"                                              security_group_id\u003dsg_id,"},{"line_number":186,"context_line":"                                              description\u003dlistener.name)"},{"line_number":187,"context_line":"        except os_exc.ConflictException:"},{"line_number":188,"context_line":"            pass"},{"line_number":189,"context_line":"        except os_exc.SDKException:"},{"line_number":190,"context_line":"            LOG.exception(\u0027Failed when creating security group rule for \u0027"},{"line_number":191,"context_line":"                          \u0027listener %s.\u0027, listener.name)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _create_listeners_acls(self, loadbalancer, port, target_port,"},{"line_number":194,"context_line":"                               protocol, lb_sg, new_sgs, listener_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_7cbb950d","line":191,"range":{"start_line":180,"start_character":0,"end_line":191,"end_character":56},"updated":"2020-05-25 07:55:09.000000000","message":"is the rule actually needed?","commit_id":"08e3b3eea1e44c3e988726bbd892ee66e2f43cdc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"0074b4196ca825d9e65242eac9ef895825d2eb65","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        if CONF.octavia_defaults.sg_mode \u003d\u003d \u0027update\u0027:"},{"line_number":368,"context_line":"            sg_id \u003d self._get_vip_port(loadbalancer).security_group_ids[0]"},{"line_number":369,"context_line":"        if sg_id:"},{"line_number":370,"context_line":"            rules \u003d os_net.security_group_rules(security_group_id\u003dsg_id,"},{"line_number":371,"context_line":"                                                description\u003dlistener.name)"},{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                os_net.delete_security_group_rule(next(rules).id)"},{"line_number":374,"context_line":"            except StopIteration:"},{"line_number":375,"context_line":"                LOG.warning(\u0027Cannot find SG rule for %s (%s) listener.\u0027,"},{"line_number":376,"context_line":"                            listener.id, listener.name)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def ensure_pool(self, loadbalancer, listener):"},{"line_number":379,"context_line":"        pool \u003d obj_lbaas.LBaaSPool(name\u003dlistener.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_6aff3567","line":376,"range":{"start_line":369,"start_character":0,"end_line":376,"end_character":55},"updated":"2020-05-26 10:33:47.000000000","message":"this need to be indented now, as the security group will only be there for the update case (plus sg_id won\u0027t exists if sg_mode \u003d\u003d create)","commit_id":"4205d0e6e4f7fe1b9d646e1a0997720bb86b6dea"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8bec45ad1a1a42ee4dedfed8760c9c29e072c8f0","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # NOTE (maysams) It might happen that the update of LBaaS SG"},{"line_number":225,"context_line":"        # has been triggered and the LBaaS SG was not created yet."},{"line_number":226,"context_line":"        # This update is skiped, until the LBaaS members are created."},{"line_number":227,"context_line":"        if not lb_sg:"},{"line_number":228,"context_line":"            return"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        if self._octavia_acls:"},{"line_number":231,"context_line":"            self._create_listeners_acls(loadbalancer, port, target_port,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_29aed6e6","line":228,"range":{"start_line":227,"start_character":2,"end_line":228,"end_character":18},"updated":"2020-05-27 07:09:24.000000000","message":"this should now be indented inside the enforce_sg_rules?","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2d13c2b1b7a0c13aba1d5e340384239b8a92418a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # NOTE (maysams) It might happen that the update of LBaaS SG"},{"line_number":225,"context_line":"        # has been triggered and the LBaaS SG was not created yet."},{"line_number":226,"context_line":"        # This update is skiped, until the LBaaS members are created."},{"line_number":227,"context_line":"        if not lb_sg:"},{"line_number":228,"context_line":"            return"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        if self._octavia_acls:"},{"line_number":231,"context_line":"            self._create_listeners_acls(loadbalancer, port, target_port,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_49d50ae5","line":228,"range":{"start_line":227,"start_character":2,"end_line":228,"end_character":18},"in_reply_to":"ff570b3c_29aed6e6","updated":"2020-05-27 08:08:37.000000000","message":"I don\u0027t think so. In case of no enforcement of sg rules the apply_members_security_groups should be skipped.","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"87a768263a2b3a9a14e47030d8e2473bcf940476","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # NOTE (maysams) It might happen that the update of LBaaS SG"},{"line_number":225,"context_line":"        # has been triggered and the LBaaS SG was not created yet."},{"line_number":226,"context_line":"        # This update is skiped, until the LBaaS members are created."},{"line_number":227,"context_line":"        if not lb_sg:"},{"line_number":228,"context_line":"            return"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        if self._octavia_acls:"},{"line_number":231,"context_line":"            self._create_listeners_acls(loadbalancer, port, target_port,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_acd2f432","line":228,"range":{"start_line":227,"start_character":2,"end_line":228,"end_character":18},"in_reply_to":"ff570b3c_49d50ae5","updated":"2020-05-27 08:47:31.000000000","message":"ohh, right. In fact, this should not be even called, right?\n\nPerhaps we could modify 219 line, and have:\nif not CONF.octavia_defaults.enforce_sg_rules:\n    return\n\nAnd then have the rest not indented","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8bec45ad1a1a42ee4dedfed8760c9c29e072c8f0","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                          {\u0027prot\u0027: protocol})"},{"line_number":350,"context_line":"            return None"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if not CONF.octavia_defaults.enforce_sg_rules:"},{"line_number":353,"context_line":"            os_net \u003d clients.get_network_client()"},{"line_number":354,"context_line":"            vip_port \u003d self._get_vip_port(loadbalancer)"},{"line_number":355,"context_line":"            os_net.update_port(vip_port.id, security_groups\u003d[])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_69b8ce29","line":352,"range":{"start_line":352,"start_character":0,"end_line":352,"end_character":54},"updated":"2020-05-27 07:09:24.000000000","message":"a NOTE here is needed to remember why we do this","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2d13c2b1b7a0c13aba1d5e340384239b8a92418a","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                          {\u0027prot\u0027: protocol})"},{"line_number":350,"context_line":"            return None"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if not CONF.octavia_defaults.enforce_sg_rules:"},{"line_number":353,"context_line":"            os_net \u003d clients.get_network_client()"},{"line_number":354,"context_line":"            vip_port \u003d self._get_vip_port(loadbalancer)"},{"line_number":355,"context_line":"            os_net.update_port(vip_port.id, security_groups\u003d[])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_494a2aac","line":352,"range":{"start_line":352,"start_character":0,"end_line":352,"end_character":54},"in_reply_to":"ff570b3c_69b8ce29","updated":"2020-05-27 08:08:37.000000000","message":"Done","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8bec45ad1a1a42ee4dedfed8760c9c29e072c8f0","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                      lbaas.delete_listener,"},{"line_number":365,"context_line":"                      listener.id)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        if CONF.octavia_defaults.enforce_sg_rules:"},{"line_number":368,"context_line":"            sg_id \u003d self._get_vip_port(loadbalancer).security_group_ids[0]"},{"line_number":369,"context_line":"            rules \u003d os_net.security_group_rules(security_group_id\u003dsg_id,"},{"line_number":370,"context_line":"                                                description\u003dlistener.name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_49b34a4e","line":367,"range":{"start_line":367,"start_character":0,"end_line":367,"end_character":50},"updated":"2020-05-27 07:09:24.000000000","message":"same here (though it was not here before...)","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2d13c2b1b7a0c13aba1d5e340384239b8a92418a","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                      lbaas.delete_listener,"},{"line_number":365,"context_line":"                      listener.id)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        if CONF.octavia_defaults.enforce_sg_rules:"},{"line_number":368,"context_line":"            sg_id \u003d self._get_vip_port(loadbalancer).security_group_ids[0]"},{"line_number":369,"context_line":"            rules \u003d os_net.security_group_rules(security_group_id\u003dsg_id,"},{"line_number":370,"context_line":"                                                description\u003dlistener.name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_a9c66615","line":367,"range":{"start_line":367,"start_character":0,"end_line":367,"end_character":50},"in_reply_to":"ff570b3c_49b34a4e","updated":"2020-05-27 08:08:37.000000000","message":"Done","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f76d5052eb0709c204f18b980b3b70b47fae946a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                lb_sg \u003d vip_port.security_group_ids[0]"},{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            LOG.debug(\"Skipping sg update for lb %s\", loadbalancer.name)"},{"line_number":225,"context_line":"            return"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if self._octavia_acls:"},{"line_number":228,"context_line":"            self._create_listeners_acls(loadbalancer, port, target_port,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_dfe9cc80","line":225,"range":{"start_line":225,"start_character":0,"end_line":225,"end_character":18},"updated":"2020-05-27 09:50:55.000000000","message":"we still need to check the if not lb_sg, right?","commit_id":"863b3f310e83f90f134f12e39e57dda2ab1d639d"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"37dd9f7bc303c9da5dbd348cd2105edaa96089a3","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                lb_sg \u003d vip_port.security_group_ids[0]"},{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            LOG.debug(\"Skipping sg update for lb %s\", loadbalancer.name)"},{"line_number":225,"context_line":"            return"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if self._octavia_acls:"},{"line_number":228,"context_line":"            self._create_listeners_acls(loadbalancer, port, target_port,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_8286d764","line":225,"range":{"start_line":225,"start_character":0,"end_line":225,"end_character":18},"in_reply_to":"ff570b3c_df3a6ce5","updated":"2020-05-27 10:07:48.000000000","message":"disregard this question. :)","commit_id":"863b3f310e83f90f134f12e39e57dda2ab1d639d"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"032fb1e3516e875ef7d54d746ca0882d4e255762","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                lb_sg \u003d vip_port.security_group_ids[0]"},{"line_number":223,"context_line":"        else:"},{"line_number":224,"context_line":"            LOG.debug(\"Skipping sg update for lb %s\", loadbalancer.name)"},{"line_number":225,"context_line":"            return"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        if self._octavia_acls:"},{"line_number":228,"context_line":"            self._create_listeners_acls(loadbalancer, port, target_port,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_df3a6ce5","line":225,"range":{"start_line":225,"start_character":0,"end_line":225,"end_character":18},"in_reply_to":"ff570b3c_dfe9cc80","updated":"2020-05-27 09:58:05.000000000","message":"Why? with amphora the security group must be there","commit_id":"863b3f310e83f90f134f12e39e57dda2ab1d639d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"43f44b81992ac9e6a34e556930bc4c0ed0a50c80","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        sg_id \u003d None"},{"line_number":378,"context_line":"        if CONF.octavia_defaults.enforce_sg_rules:"},{"line_number":379,"context_line":"            sg_id \u003d self._get_vip_port(loadbalancer).security_group_ids[0]"},{"line_number":380,"context_line":"        if sg_id:"},{"line_number":381,"context_line":"            rules \u003d os_net.security_group_rules(security_group_id\u003dsg_id,"},{"line_number":382,"context_line":"                                                description\u003dlistener.name)"},{"line_number":383,"context_line":"            try:"},{"line_number":384,"context_line":"                os_net.delete_security_group_rule(next(rules).id)"},{"line_number":385,"context_line":"            except StopIteration:"},{"line_number":386,"context_line":"                LOG.warning(\u0027Cannot find SG rule for %s (%s) listener.\u0027,"},{"line_number":387,"context_line":"                            listener.id, listener.name)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    def ensure_pool(self, loadbalancer, listener):"},{"line_number":390,"context_line":"        pool \u003d obj_lbaas.LBaaSPool(name\u003dlistener.name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_61ea8c75","line":387,"range":{"start_line":380,"start_character":0,"end_line":387,"end_character":55},"updated":"2020-05-28 08:05:22.000000000","message":"why not indenting this? we only need to remove the SG rule for the enforce_sg_rules mode, right?","commit_id":"c50739898d45ed6d71994cbb021f0fbf983fde97"}],"releasenotes/notes/deprecate-sg-mode-option-96824c33335cd74b.yaml":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8bec45ad1a1a42ee4dedfed8760c9c29e072c8f0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Setting the ``sg_mode`` option for octavia is being deprecated."},{"line_number":5,"context_line":"    Main reason is that when ``sg_mode`` is create a new load balancer"},{"line_number":6,"context_line":"    security group is created, However when ovn-octavia provider is"},{"line_number":7,"context_line":"    used that security group is not enforced, and thus there is no"},{"line_number":8,"context_line":"    need to have been created."},{"line_number":9,"context_line":"    To address the other operation handled on this config, the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff570b3c_89860265","line":6,"range":{"start_line":6,"start_character":29,"end_line":6,"end_character":31},"updated":"2020-05-27 07:09:24.000000000","message":".","commit_id":"28a855286fc860054b3f6a439ded418f1d4ac630"}]}