)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"7050a49b8a27ca7c7940170c0d0a9e45d68f2177","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if v \u003e\u003d _OCTAVIA_ACL_VERSION:"},{"line_number":67,"context_line":"            self._octavia_acls \u003d True"},{"line_number":68,"context_line":"            LOG.info(\u0027Octavia supports ACLs for Amphora provider.\u0027)"},{"line_number":69,"context_line":"        if v \u003e\u003d _OCTAVIA_DL_VERSION:"},{"line_number":70,"context_line":"            self._octavia_double_listeners \u003d True"},{"line_number":71,"context_line":"            LOG.info(\u0027Octavia supports double listeners (different \u0027"},{"line_number":72,"context_line":"                     \u0027protocol, same port) for Amphora provider.\u0027)"},{"line_number":73,"context_line":"        if v \u003e\u003d _OCTAVIA_TAGGING_VERSION:"},{"line_number":74,"context_line":"            LOG.info(\u0027Octavia supports resource tags.\u0027)"},{"line_number":75,"context_line":"            self._octavia_tags \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_3b11b55e","line":72,"range":{"start_line":69,"start_character":8,"end_line":72,"end_character":66},"updated":"2020-06-01 11:13:32.000000000","message":"Should this be v \u003e _OCTAVIA_DL_VERSION? and in case the fix wasn\u0027t backported to 2.11 we might need to still have the workaround for that version.","commit_id":"9d9ef895f9810b8d58c7e316cf968bfa16dcb2a0"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"286de16d584d5a7705175361d09e4190b7c22a71","unresolved":false,"context_lines":[{"line_number":44,"context_line":"_LB_STS_POLL_FAST_INTERVAL \u003d 1"},{"line_number":45,"context_line":"_LB_STS_POLL_SLOW_INTERVAL \u003d 3"},{"line_number":46,"context_line":"_OCTAVIA_TAGGING_VERSION \u003d 2, 5"},{"line_number":47,"context_line":"# NOTE(ltomasbo): amphora supports it on 2.11, but ovn-octavia only on 2.13"},{"line_number":48,"context_line":"# In order to make it simpler, we assume this is supported only from 2.13"},{"line_number":49,"context_line":"_OCTAVIA_DL_VERSION \u003d 2, 13"},{"line_number":50,"context_line":"_OCTAVIA_ACL_VERSION \u003d 2, 12"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_d5e760e2","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":73},"updated":"2020-06-04 11:38:17.000000000","message":"Could you please put some context, since after merge, when someone read this, he/she could be clueless what amphora supports from 2.11 ;) I guess, I\u0027d dig to it by the log message from line 73, but, well…","commit_id":"dc78e0cef3d8644e85c216074c486942564ab375"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"829c8b6fb113e0cf9151b3da7c7cde745eea9aae","unresolved":false,"context_lines":[{"line_number":44,"context_line":"_LB_STS_POLL_FAST_INTERVAL \u003d 1"},{"line_number":45,"context_line":"_LB_STS_POLL_SLOW_INTERVAL \u003d 3"},{"line_number":46,"context_line":"_OCTAVIA_TAGGING_VERSION \u003d 2, 5"},{"line_number":47,"context_line":"# NOTE(ltomasbo): amphora supports it on 2.11, but ovn-octavia only on 2.13"},{"line_number":48,"context_line":"# In order to make it simpler, we assume this is supported only from 2.13"},{"line_number":49,"context_line":"_OCTAVIA_DL_VERSION \u003d 2, 13"},{"line_number":50,"context_line":"_OCTAVIA_ACL_VERSION \u003d 2, 12"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_1b97463c","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":73},"in_reply_to":"ff570b3c_d5e760e2","updated":"2020-06-04 15:01:03.000000000","message":"Uhm, waaaait… So newer versions running on amphora and Octavia 2.11 and 2.12 will start behaving differently on upgrade. Aww, this is pretty bad actually. Sorry, I know I advocated not to differentiate, but sudden change of behavior on Kuryr upgrade is not something that should happen. :(","commit_id":"dc78e0cef3d8644e85c216074c486942564ab375"}]}