)]}'
{"kuryr_kubernetes/controller/handlers/lbaas.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2df5d18a39b91b839c8df4cd4ee60d4130146233","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                               for service in services"},{"line_number":661,"context_line":"                               if service[\u0027spec\u0027].get(\u0027clusterIP\u0027)}"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        services_without_selector \u003d set("},{"line_number":664,"context_line":"            service[\u0027spec\u0027][\u0027clusterIP\u0027] for service in services"},{"line_number":665,"context_line":"            if (service[\u0027spec\u0027].get(\u0027clusterIP\u0027) and"},{"line_number":666,"context_line":"                not service[\u0027spec\u0027].get(\u0027selector\u0027)))"},{"line_number":667,"context_line":"        lbaas_spec \u003d {}"},{"line_number":668,"context_line":"        self._drv_lbaas.add_tags(\u0027loadbalancer\u0027, lbaas_spec)"},{"line_number":669,"context_line":"        loadbalancers \u003d lbaas_client.load_balancers(**lbaas_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0414f342","line":666,"range":{"start_line":663,"start_character":0,"end_line":666,"end_character":53},"updated":"2020-06-05 11:23:33.000000000","message":"Perhaps we could add the opposite check to the services_cluster_ip definition and remove this definition?\n\nAnd update line 676 accordingly.","commit_id":"df0f68acccb09561b1e6e6ded8b6ecec4e05d2c7"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d756d0eb7bd90ea2e838015b93257359aec0272d","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                               for service in services"},{"line_number":661,"context_line":"                               if service[\u0027spec\u0027].get(\u0027clusterIP\u0027)}"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        services_without_selector \u003d set("},{"line_number":664,"context_line":"            service[\u0027spec\u0027][\u0027clusterIP\u0027] for service in services"},{"line_number":665,"context_line":"            if (service[\u0027spec\u0027].get(\u0027clusterIP\u0027) and"},{"line_number":666,"context_line":"                not service[\u0027spec\u0027].get(\u0027selector\u0027)))"},{"line_number":667,"context_line":"        lbaas_spec \u003d {}"},{"line_number":668,"context_line":"        self._drv_lbaas.add_tags(\u0027loadbalancer\u0027, lbaas_spec)"},{"line_number":669,"context_line":"        loadbalancers \u003d lbaas_client.load_balancers(**lbaas_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_64932f50","line":666,"range":{"start_line":663,"start_character":0,"end_line":666,"end_character":53},"in_reply_to":"ff570b3c_0414f342","updated":"2020-06-05 11:36:29.000000000","message":"no, we need that on services_cluster_ips, otherwise the kubernetes svc gets deleted (that is what I did initially... :( )","commit_id":"df0f68acccb09561b1e6e6ded8b6ecec4e05d2c7"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"73efa0deadaa828f00bba7ef3f6622c7bd5aa8e0","unresolved":false,"context_lines":[{"line_number":660,"context_line":"                               for service in services"},{"line_number":661,"context_line":"                               if service[\u0027spec\u0027].get(\u0027clusterIP\u0027)}"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"        services_without_selector \u003d set("},{"line_number":664,"context_line":"            service[\u0027spec\u0027][\u0027clusterIP\u0027] for service in services"},{"line_number":665,"context_line":"            if (service[\u0027spec\u0027].get(\u0027clusterIP\u0027) and"},{"line_number":666,"context_line":"                not service[\u0027spec\u0027].get(\u0027selector\u0027)))"},{"line_number":667,"context_line":"        lbaas_spec \u003d {}"},{"line_number":668,"context_line":"        self._drv_lbaas.add_tags(\u0027loadbalancer\u0027, lbaas_spec)"},{"line_number":669,"context_line":"        loadbalancers \u003d lbaas_client.load_balancers(**lbaas_spec)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9a833ecb","line":666,"range":{"start_line":663,"start_character":0,"end_line":666,"end_character":53},"in_reply_to":"ff570b3c_64932f50","updated":"2020-06-05 13:14:35.000000000","message":"oh, right. But as both iterations are over the same resources, perhaps that could be done only once, and updating the different variables depending on the condition.","commit_id":"df0f68acccb09561b1e6e6ded8b6ecec4e05d2c7"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"356fc608fa22d379f1625c070e539e529b920459","unresolved":false,"context_lines":[{"line_number":702,"context_line":"                retry \u003d False"},{"line_number":703,"context_line":"            except k_exc.ResourceNotReady:"},{"line_number":704,"context_line":"                LOG.debug(\"Attempt (%s) of loadbalancer release %s failed.\""},{"line_number":705,"context_line":"                          \" A retry will be triggered.\", attempts,"},{"line_number":706,"context_line":"                          lb_obj.name)"},{"line_number":707,"context_line":"                attempts +\u003d 1"},{"line_number":708,"context_line":"                retry \u003d True"},{"line_number":709,"context_line":"        if svc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_74e908b6","line":706,"range":{"start_line":705,"start_character":0,"end_line":706,"end_character":38},"updated":"2020-06-08 11:49:31.000000000","message":"Seems like it\u0027s not needed, but whatever. ;)","commit_id":"df0f68acccb09561b1e6e6ded8b6ecec4e05d2c7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"11f9e880e784d7c6ebb00232e4093be435d4e973","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        lbaas_state \u003d utils.get_lbaas_state(endpoints)"},{"line_number":187,"context_line":"        if not lbaas_state:"},{"line_number":188,"context_line":"            lbaas_state \u003d obj_lbaas.LBaaSState()"},{"line_number":189,"context_line":"        elif (lbaas_state.loadbalancer and self._lb_provider !\u003d lbaas_state.loadbalancer.provider):"},{"line_number":190,"context_line":"            LOG.info(\"LoadBalancer associated to the service does not match the desired provider\")"},{"line_number":191,"context_line":"            return"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_fc168555","line":189,"updated":"2020-06-09 13:48:10.000000000","message":"pep8: E501 line too long (99 \u003e 79 characters)","commit_id":"dd653d2c2aa6dd92d5b974b5089635469d9bec2e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"11f9e880e784d7c6ebb00232e4093be435d4e973","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if not lbaas_state:"},{"line_number":188,"context_line":"            lbaas_state \u003d obj_lbaas.LBaaSState()"},{"line_number":189,"context_line":"        elif (lbaas_state.loadbalancer and self._lb_provider !\u003d lbaas_state.loadbalancer.provider):"},{"line_number":190,"context_line":"            LOG.info(\"LoadBalancer associated to the service does not match the desired provider\")"},{"line_number":191,"context_line":"            return"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        if self._sync_lbaas_members(endpoints, lbaas_state, lbaas_spec):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_5c0b312a","line":190,"updated":"2020-06-09 13:48:10.000000000","message":"pep8: E501 line too long (98 \u003e 79 characters)","commit_id":"dd653d2c2aa6dd92d5b974b5089635469d9bec2e"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b9c35df1f223bf909d1115f1548782d03dcb4437","unresolved":false,"context_lines":[{"line_number":717,"context_line":""},{"line_number":718,"context_line":"            lbaas \u003d utils.get_lbaas_state(endpoint)"},{"line_number":719,"context_line":"            if lbaas:"},{"line_number":720,"context_line":"                lbaas.loadbalancer \u003d None"},{"line_number":721,"context_line":"                lbaas.pools \u003d []"},{"line_number":722,"context_line":"                lbaas.listeners \u003d []"},{"line_number":723,"context_line":"                lbaas.members \u003d []"},{"line_number":724,"context_line":"                utils.set_lbaas_state(endpoint, lbaas)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_4d87eb10","line":723,"range":{"start_line":720,"start_character":0,"end_line":723,"end_character":34},"updated":"2020-06-10 09:49:36.000000000","message":"could be redefined as empty obj obj_lbaas.LBaaSState()","commit_id":"b55b0fe1cb8f9c7f6744ca107d1dd045511a55f8"}]}