)]}'
{"kuryr_kubernetes/controller/drivers/network_policy.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"a78963535c75d010794acd0d2c4bbdb37efba67d","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                        ethertype\u003dethertype,"},{"line_number":418,"context_line":"                        protocol\u003dport.get(\u0027protocol\u0027)))"},{"line_number":419,"context_line":"                sg_rule_body_list.append(sg_rule)"},{"line_number":420,"context_line":"            if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":421,"context_line":"                rule \u003d self._create_svc_egress_sg_rule("},{"line_number":422,"context_line":"                    sg_id, policy_namespace, port\u003dport.get(\u0027port\u0027),"},{"line_number":423,"context_line":"                    protocol\u003dport.get(\u0027protocol\u0027))"},{"line_number":424,"context_line":"                sg_rule_body_list.extend(rule)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _create_default_sg_rule(self, sg_id, direction, sg_rule_body_list):"},{"line_number":427,"context_line":"        for ethertype in (constants.IPv4, constants.IPv6):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_90219db7","line":424,"range":{"start_line":420,"start_character":0,"end_line":424,"end_character":46},"updated":"2020-07-11 23:05:32.000000000","message":"Previous created rule already takes care of allowing traffic to 0.0.0.0/0, so I believe this also can get removed.","commit_id":"3f8073f829642291ad592c47b16417297a66fbd0"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"15d1d83056601ae2c37f0eff3bb6be696e7f5241","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                        ethertype\u003dethertype,"},{"line_number":418,"context_line":"                        protocol\u003dport.get(\u0027protocol\u0027)))"},{"line_number":419,"context_line":"                sg_rule_body_list.append(sg_rule)"},{"line_number":420,"context_line":"            if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":421,"context_line":"                rule \u003d self._create_svc_egress_sg_rule("},{"line_number":422,"context_line":"                    sg_id, policy_namespace, port\u003dport.get(\u0027port\u0027),"},{"line_number":423,"context_line":"                    protocol\u003dport.get(\u0027protocol\u0027))"},{"line_number":424,"context_line":"                sg_rule_body_list.extend(rule)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _create_default_sg_rule(self, sg_id, direction, sg_rule_body_list):"},{"line_number":427,"context_line":"        for ethertype in (constants.IPv4, constants.IPv6):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4ddb684e","line":424,"range":{"start_line":420,"start_character":0,"end_line":424,"end_character":46},"in_reply_to":"bf51134e_90219db7","updated":"2020-07-21 15:03:32.000000000","message":"Ack.","commit_id":"3f8073f829642291ad592c47b16417297a66fbd0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"a78963535c75d010794acd0d2c4bbdb37efba67d","unresolved":false,"context_lines":[{"line_number":559,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":560,"context_line":"                    # TODO(gryf): Check if those rules are needed for the"},{"line_number":561,"context_line":"                    # services"},{"line_number":562,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":563,"context_line":"                        rule \u003d self._create_svc_egress_sg_rule("},{"line_number":564,"context_line":"                            sg_id, policy_namespace)"},{"line_number":565,"context_line":"                        sg_rule_body_list.extend(rule)"},{"line_number":566,"context_line":"            else:"},{"line_number":567,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":568,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7037a9ff","line":565,"range":{"start_line":562,"start_character":0,"end_line":565,"end_character":54},"updated":"2020-07-11 23:05:32.000000000","message":"As the sg rule created at line 563 is allowing traffic to everywhere, looks like this rule is also not needed.","commit_id":"3f8073f829642291ad592c47b16417297a66fbd0"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"15d1d83056601ae2c37f0eff3bb6be696e7f5241","unresolved":false,"context_lines":[{"line_number":559,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":560,"context_line":"                    # TODO(gryf): Check if those rules are needed for the"},{"line_number":561,"context_line":"                    # services"},{"line_number":562,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":563,"context_line":"                        rule \u003d self._create_svc_egress_sg_rule("},{"line_number":564,"context_line":"                            sg_id, policy_namespace)"},{"line_number":565,"context_line":"                        sg_rule_body_list.extend(rule)"},{"line_number":566,"context_line":"            else:"},{"line_number":567,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":568,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2de0b4fa","line":565,"range":{"start_line":562,"start_character":0,"end_line":565,"end_character":54},"in_reply_to":"bf51134e_7037a9ff","updated":"2020-07-21 15:03:32.000000000","message":"Ack.","commit_id":"3f8073f829642291ad592c47b16417297a66fbd0"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"c39bd901296f06e82ae62b7a7e598094bf29f41c","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_af5818fa","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"updated":"2020-07-22 19:35:12.000000000","message":"did you run it locally with amphora provider and it required this sg rule?","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"688036429c15a207cb4e183061f91b1ffa747927","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_9d0e8330","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"in_reply_to":"bf51134e_04ff4567","updated":"2020-07-24 17:13:56.000000000","message":"I\u0027ll run test next monday.","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"c13a93f677a1b121e2f8286670d952972a168c2e","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_c42c2d4c","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"in_reply_to":"bf51134e_0b83d805","updated":"2020-07-24 11:20:25.000000000","message":"Apparently we don\u0027t. Unless there is some case which I didn\u0027t think of.","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"fd1bac00cb6aae948ce96a207b7afb211f12ce4b","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_d7750ffc","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"in_reply_to":"bf51134e_2f9d2866","updated":"2020-07-23 14:29:33.000000000","message":"Ok, so let see.","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"fd1bac00cb6aae948ce96a207b7afb211f12ce4b","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_976b971d","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"in_reply_to":"bf51134e_af5818fa","updated":"2020-07-23 14:29:33.000000000","message":"Not yet. I was intend to do so, but I was fighting with devstack today, so I guess, I\u0027ll delegate it to gates.","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"a931761bc40992ebdd9f988e52b480759bb188c2","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_2f9d2866","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"in_reply_to":"bf51134e_af5818fa","updated":"2020-07-22 19:45:57.000000000","message":"Note that the failures on the egress tests seen in patch 3 are probably unrelated to the removal of this sg rule. As the np gates is running with ovn-octavia provider, no sg rule with service cidr on remote_ip is needed for the traffic to reach the endpoint.\nIn order to ensure this is not needed we would need to check in an env with amphoras.","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d039e367f6a43418a779fc75f5776992bc8de30e","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_04ff4567","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"in_reply_to":"bf51134e_c42c2d4c","updated":"2020-07-24 11:44:32.000000000","message":"I think this was needed when using amphora and pod to pod communication through the service. As if we only allow egress to the pod ip... it should also be allowed to the svc IP, as that is what the pod is replying to. Have you tested this with amphora instead of ovn-octavia??","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4a2c1b578bba4d0a06ecdcac3e1b1f2574b8a192","unresolved":false,"context_lines":[{"line_number":551,"context_line":"                            port_range_max\u003d65535,"},{"line_number":552,"context_line":"                            ethertype\u003dethertype)"},{"line_number":553,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":554,"context_line":"                    if direction \u003d\u003d \u0027egress\u0027:"},{"line_number":555,"context_line":"                        self._create_svc_egress_sg_rule("},{"line_number":556,"context_line":"                            sg_id, policy_namespace, sg_rule_body_list)"},{"line_number":557,"context_line":"            else:"},{"line_number":558,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"},{"line_number":559,"context_line":"                          \u0027%(rule_direction)s and no ports: %(policy)s\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_0b83d805","line":556,"range":{"start_line":554,"start_character":0,"end_line":556,"end_character":71},"in_reply_to":"bf51134e_d7750ffc","updated":"2020-07-24 08:20:09.000000000","message":"don\u0027t we need this?","commit_id":"fdbca812d55cfa597e9991d03ee45679b658736f"}],"kuryr_kubernetes/tests/unit/controller/drivers/test_network_policy.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9e56df16e7c45279bb7ed288dabd50e70d205eaa","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                                                       allow_all\u003dTrue)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        m_get_ports.assert_called_with(resources[0], port)"},{"line_number":552,"context_line":"        self.assertEqual(0, len(crd_rules))"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @mock.patch(\u0027kuryr_kubernetes.utils.get_subnet_cidr\u0027)"},{"line_number":555,"context_line":"    @mock.patch(\u0027kuryr_kubernetes.controller.drivers.utils.\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_7dd066f8","line":552,"range":{"start_line":552,"start_character":0,"end_line":552,"end_character":43},"updated":"2020-08-19 10:45:41.000000000","message":"That\u0027s something that I\u0027m afraid of here…","commit_id":"617b0c60706f8572e0e7e831e37942c7ccfd7b7e"}]}