)]}'
{"kuryr_kubernetes/cni/binding/sriov.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"c07cdbb95b0c17e207c20ca94235793cf0628cb0","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"                container_devices \u003d container.devices"},{"line_number":89,"context_line":"            except Exception:"},{"line_number":90,"context_line":"                LOG.warning(\"No devices in container %s\", container.name)"},{"line_number":91,"context_line":"                continue"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            for dev in container_devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_2f5368e4","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":73},"updated":"2020-07-22 19:48:48.000000000","message":"yay! less lines!","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"e4b35e31da20eeeb3c275c28537ece7a0d7a9473","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"                container_devices \u003d container.devices"},{"line_number":89,"context_line":"            except Exception:"},{"line_number":90,"context_line":"                LOG.warning(\"No devices in container %s\", container.name)"},{"line_number":91,"context_line":"                continue"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            for dev in container_devices:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_bf703f0a","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":73},"in_reply_to":"bf51134e_2f5368e4","updated":"2020-07-23 06:48:02.000000000","message":"yes, it\u0027s totally important;)","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"c07cdbb95b0c17e207c20ca94235793cf0628cb0","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            LOG.info(\"PCI device %s will be moved to container\u0027s net ns %s\","},{"line_number":141,"context_line":"                     pci, netns)"},{"line_number":142,"context_line":"            self._move_to_netns(ifname, netns, vif, vf_name, vf_index, pf)"},{"line_number":143,"context_line":"            old_driver \u003d driver"},{"line_number":144,"context_line":"        self._annotate_device(pod_link, pci, old_driver, driver, vif.id)"},{"line_number":145,"context_line":"        return pci_info"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _move_to_netns(self, ifname, netns, vif, vf_name, vf_index, pf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8f10b402","line":144,"range":{"start_line":143,"start_character":1,"end_line":144,"end_character":72},"updated":"2020-07-22 19:48:48.000000000","message":"I don\u0027t get it. old_diver is the same as a driver, yet both are passed to _annotate_device? Wouldn\u0027t that be clearer, if the driver would be passed twice as before?","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"1686d9e5b31f5cc8939562305f57fbf3aa36c250","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            LOG.info(\"PCI device %s will be moved to container\u0027s net ns %s\","},{"line_number":141,"context_line":"                     pci, netns)"},{"line_number":142,"context_line":"            self._move_to_netns(ifname, netns, vif, vf_name, vf_index, pf)"},{"line_number":143,"context_line":"            old_driver \u003d driver"},{"line_number":144,"context_line":"        self._annotate_device(pod_link, pci, old_driver, driver, vif.id)"},{"line_number":145,"context_line":"        return pci_info"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _move_to_netns(self, ifname, netns, vif, vf_name, vf_index, pf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_425e6a76","line":144,"range":{"start_line":143,"start_character":1,"end_line":144,"end_character":72},"in_reply_to":"bf51134e_62b1eee1","updated":"2020-07-23 07:57:27.000000000","message":"thanks a lot, Roman","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2b3a4274eeca2f420ac8431869d532d93c27d56d","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            LOG.info(\"PCI device %s will be moved to container\u0027s net ns %s\","},{"line_number":141,"context_line":"                     pci, netns)"},{"line_number":142,"context_line":"            self._move_to_netns(ifname, netns, vif, vf_name, vf_index, pf)"},{"line_number":143,"context_line":"            old_driver \u003d driver"},{"line_number":144,"context_line":"        self._annotate_device(pod_link, pci, old_driver, driver, vif.id)"},{"line_number":145,"context_line":"        return pci_info"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _move_to_netns(self, ifname, netns, vif, vf_name, vf_index, pf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c862a2d9","line":144,"range":{"start_line":143,"start_character":1,"end_line":144,"end_character":72},"in_reply_to":"bf51134e_8f10b402","updated":"2020-07-22 22:34:47.000000000","message":"+1","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"e4b35e31da20eeeb3c275c28537ece7a0d7a9473","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            LOG.info(\"PCI device %s will be moved to container\u0027s net ns %s\","},{"line_number":141,"context_line":"                     pci, netns)"},{"line_number":142,"context_line":"            self._move_to_netns(ifname, netns, vif, vf_name, vf_index, pf)"},{"line_number":143,"context_line":"            old_driver \u003d driver"},{"line_number":144,"context_line":"        self._annotate_device(pod_link, pci, old_driver, driver, vif.id)"},{"line_number":145,"context_line":"        return pci_info"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _move_to_netns(self, ifname, netns, vif, vf_name, vf_index, pf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_dfe373a3","line":144,"range":{"start_line":143,"start_character":1,"end_line":144,"end_character":72},"in_reply_to":"bf51134e_c862a2d9","updated":"2020-07-23 06:48:02.000000000","message":"yes, but that will increase the number of redundant code. Two calls of _annotate_device are different only with one parameter","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"444acd2f5d70481065a0b26f6106edb18f5e1841","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            LOG.info(\"PCI device %s will be moved to container\u0027s net ns %s\","},{"line_number":141,"context_line":"                     pci, netns)"},{"line_number":142,"context_line":"            self._move_to_netns(ifname, netns, vif, vf_name, vf_index, pf)"},{"line_number":143,"context_line":"            old_driver \u003d driver"},{"line_number":144,"context_line":"        self._annotate_device(pod_link, pci, old_driver, driver, vif.id)"},{"line_number":145,"context_line":"        return pci_info"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _move_to_netns(self, ifname, netns, vif, vf_name, vf_index, pf):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_62b1eee1","line":144,"range":{"start_line":143,"start_character":1,"end_line":144,"end_character":72},"in_reply_to":"bf51134e_dfe373a3","updated":"2020-07-23 07:41:50.000000000","message":"Oh, I got it now. old_driver is set either to driver directly, or through self._bind_device() method. Ignore me, I\u0027m blind ;)","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2b3a4274eeca2f420ac8431869d532d93c27d56d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                iface.ifname \u003d ifname"},{"line_number":161,"context_line":"                iface.mtu \u003d vif.network.mtu"},{"line_number":162,"context_line":"                iface.up()"},{"line_number":163,"context_line":"        return"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _get_vf_info(self, pci, driver):"},{"line_number":166,"context_line":"        vf_sys_path \u003d \u0027/sys/bus/pci/devices/{}/net/\u0027.format(pci)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e83966d8","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":14},"updated":"2020-07-22 22:34:47.000000000","message":"Looks like this return can be removed as is not returning anything and it won\u0027t break the execution follow of following operations.","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"e4b35e31da20eeeb3c275c28537ece7a0d7a9473","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                iface.ifname \u003d ifname"},{"line_number":161,"context_line":"                iface.mtu \u003d vif.network.mtu"},{"line_number":162,"context_line":"                iface.up()"},{"line_number":163,"context_line":"        return"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    def _get_vf_info(self, pci, driver):"},{"line_number":166,"context_line":"        vf_sys_path \u003d \u0027/sys/bus/pci/devices/{}/net/\u0027.format(pci)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3f854fd0","line":163,"range":{"start_line":163,"start_character":0,"end_line":163,"end_character":14},"in_reply_to":"bf51134e_e83966d8","updated":"2020-07-23 06:48:02.000000000","message":"yes, I agree\nthanks a lot","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2b3a4274eeca2f420ac8431869d532d93c27d56d","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                 neutron_port, nodename)"},{"line_number":322,"context_line":"        k8s.remove_node_annotations(nodename, annot_name)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def _make_annot_name(self, neutron_port):"},{"line_number":325,"context_line":"        annot_name \u003d constants.K8S_ANNOTATION_NODE_PCI_DEVICE_INFO"},{"line_number":326,"context_line":"        annot_name \u003d annot_name.replace(\u0027/\u0027, \u0027~1\u0027)"},{"line_number":327,"context_line":"        annot_name \u003d annot_name + \u0027-\u0027 + neutron_port"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a8a3eeff","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":24},"updated":"2020-07-22 22:34:47.000000000","message":"It may be clear if renamed to _make_annotation_name","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"},{"author":{"_account_id":24604,"name":"Danil Golov","email":"d.golov@samsung.com","username":"d.golov"},"change_message_id":"e4b35e31da20eeeb3c275c28537ece7a0d7a9473","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                 neutron_port, nodename)"},{"line_number":322,"context_line":"        k8s.remove_node_annotations(nodename, annot_name)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def _make_annot_name(self, neutron_port):"},{"line_number":325,"context_line":"        annot_name \u003d constants.K8S_ANNOTATION_NODE_PCI_DEVICE_INFO"},{"line_number":326,"context_line":"        annot_name \u003d annot_name.replace(\u0027/\u0027, \u0027~1\u0027)"},{"line_number":327,"context_line":"        annot_name \u003d annot_name + \u0027-\u0027 + neutron_port"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5f5be385","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":24},"in_reply_to":"bf51134e_a8a3eeff","updated":"2020-07-23 06:48:02.000000000","message":"Done","commit_id":"3376b68ba995c58f57cd30e41206cac27d3d27b2"}]}