)]}'
{"kuryr_kubernetes/controller/handlers/vif.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4243dfb4d10ba53d9eeb39a630987c439e4aeaa2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                drivers.ServiceSecurityGroupsDriver.get_instance())"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def on_present(self, pod):"},{"line_number":66,"context_line":"        # NOTE(gryf): Set the finlizer as soon, as we have pod created. On"},{"line_number":67,"context_line":"        # subsequent updates of the pod, add_finalizer will ignore this if"},{"line_number":68,"context_line":"        # finalizer exists."},{"line_number":69,"context_line":"        k8s \u003d clients.get_kubernetes_client()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e72ea9f8","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":38},"updated":"2020-07-31 08:58:13.000000000","message":"finalizer","commit_id":"dfa1c364fc37c7b6bec415afc9988e3d8be1701d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"541eb28b4fc19e5369195bff1eb70dc1fb311e5c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # NOTE(gryf): Set the finalizer as soon, as we have pod created. On"},{"line_number":67,"context_line":"        # subsequent updates of the pod, add_finalizer will ignore this if"},{"line_number":68,"context_line":"        # finalizer exists."},{"line_number":69,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":70,"context_line":"        k8s.add_finalizer(pod, constants.POD_FINALIZER)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if self._move_annotations_to_crd(pod):"},{"line_number":73,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1d1a8515","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":55},"updated":"2020-08-10 09:37:16.000000000","message":"would it be better to have this at line 92 instead? Otherwise we could end up in the status where the pod was deleted before being scheduled and we have a finalizer but the kuryrport will never get created, right?","commit_id":"a5badacb90966a8500d3aa2235f8a36891f29c98"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9e30bd1d7004cc46a5f18b80816638439aa22c50","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # NOTE(gryf): Set the finalizer as soon, as we have pod created. On"},{"line_number":67,"context_line":"        # subsequent updates of the pod, add_finalizer will ignore this if"},{"line_number":68,"context_line":"        # finalizer exists."},{"line_number":69,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":70,"context_line":"        k8s.add_finalizer(pod, constants.POD_FINALIZER)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if self._move_annotations_to_crd(pod):"},{"line_number":73,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a0f1b203","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":55},"in_reply_to":"9f560f44_00b21e49","updated":"2020-08-10 10:51:12.000000000","message":"umm, right.","commit_id":"a5badacb90966a8500d3aa2235f8a36891f29c98"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fb2e374ae8eeb94e8183a92252494a83abb28ff4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # NOTE(gryf): Set the finalizer as soon, as we have pod created. On"},{"line_number":67,"context_line":"        # subsequent updates of the pod, add_finalizer will ignore this if"},{"line_number":68,"context_line":"        # finalizer exists."},{"line_number":69,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":70,"context_line":"        k8s.add_finalizer(pod, constants.POD_FINALIZER)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        if self._move_annotations_to_crd(pod):"},{"line_number":73,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_00b21e49","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":55},"in_reply_to":"9f560f44_1d1a8515","updated":"2020-08-10 10:45:52.000000000","message":"Won\u0027t on_finalize handle such case just fine?","commit_id":"a5badacb90966a8500d3aa2235f8a36891f29c98"}]}