)]}'
{"kuryr_kubernetes/controller/handlers/lbaas.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"bd799b360233744c0df72d7ffdaede49ae61f097","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        # Load Balancer creation flow."},{"line_number":263,"context_line":"        # We need to set the requested load balancer provider"},{"line_number":264,"context_line":"        # according to \u0027endpoints_driver_octavia_provider\u0027 configuration."},{"line_number":265,"context_line":"        self._lb_provider \u003d None"},{"line_number":266,"context_line":"        if (config.CONF.kubernetes.endpoints_driver_octavia_provider"},{"line_number":267,"context_line":"                !\u003d \u0027default\u0027):"},{"line_number":268,"context_line":"            self._lb_provider \u003d ("},{"line_number":269,"context_line":"                config.CONF.kubernetes.endpoints_driver_octavia_provider)"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b344ef48","line":267,"range":{"start_line":265,"start_character":0,"end_line":267,"end_character":30},"updated":"2020-09-03 20:53:44.000000000","message":"The endpoints_driver_octavia_provider will always be set to either default(amphora) or ovn. Couldn\u0027t this check be removed, otherwise we might end up with _lb_provider None and consequently not adding it to the CRD?","commit_id":"052474f77ef16f27013314a8db3133c7c76b46ee"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a96f1136c1b5fa74aee786df9948344db7babeae","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        # Load Balancer creation flow."},{"line_number":263,"context_line":"        # We need to set the requested load balancer provider"},{"line_number":264,"context_line":"        # according to \u0027endpoints_driver_octavia_provider\u0027 configuration."},{"line_number":265,"context_line":"        self._lb_provider \u003d None"},{"line_number":266,"context_line":"        if (config.CONF.kubernetes.endpoints_driver_octavia_provider"},{"line_number":267,"context_line":"                !\u003d \u0027default\u0027):"},{"line_number":268,"context_line":"            self._lb_provider \u003d ("},{"line_number":269,"context_line":"                config.CONF.kubernetes.endpoints_driver_octavia_provider)"},{"line_number":270,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b6905897","line":267,"range":{"start_line":265,"start_character":0,"end_line":267,"end_character":30},"in_reply_to":"9f560f44_b344ef48","updated":"2020-09-04 07:04:42.000000000","message":"problem is that code seems to assume that when default is used, lb_provider \u003d None. But yeah, I agree, we should just set lb_provider to endpoints_driver_octavia_provider, and ensure it is properly handled on the other points.\n\nThat said, maybe it is not that easy, as \"default\" means \"amphora\" (or \"octavia\" in older OpenStack versions, like queen/osp13). Not sure if that could make upgrades more complex (there is no need to upgrade between octavia and amphora)","commit_id":"052474f77ef16f27013314a8db3133c7c76b46ee"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f980f121d7e81192c7a5fa91310d43e6c9d31659","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            self._update_crd_spec(loadbalancer_crd, endpoints)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if loadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027) !\u003d self._lb_provider:"},{"line_number":289,"context_line":"            self._update_crd_spec(loadbalancer_crd, endpoints)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def _has_pods(self, endpoints):"},{"line_number":292,"context_line":"        ep_subsets \u003d endpoints.get(\u0027subsets\u0027, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_69355aa8","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":62},"updated":"2020-09-03 07:49:49.000000000","message":"isn\u0027t this be called anyway in line 286?","commit_id":"052474f77ef16f27013314a8db3133c7c76b46ee"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"fb1df71b1a7c135db9758f5fb88f57bd9ebb3454","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            self._update_crd_spec(loadbalancer_crd, endpoints)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if loadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027) !\u003d self._lb_provider:"},{"line_number":289,"context_line":"            self._update_crd_spec(loadbalancer_crd, endpoints)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def _has_pods(self, endpoints):"},{"line_number":292,"context_line":"        ep_subsets \u003d endpoints.get(\u0027subsets\u0027, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_b3bfcfa8","line":289,"range":{"start_line":289,"start_character":12,"end_line":289,"end_character":62},"in_reply_to":"9f560f44_69355aa8","updated":"2020-09-03 20:39:04.000000000","message":"that is true, thanks","commit_id":"052474f77ef16f27013314a8db3133c7c76b46ee"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"78df1e9f1c5b8fe40ab44d66ea6695855943b32b","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                \u0027project_id\u0027: project_id,"},{"line_number":157,"context_line":"                \u0027security_groups_ids\u0027: sg_ids,"},{"line_number":158,"context_line":"                \u0027subnet_id\u0027: subnet_id,"},{"line_number":159,"context_line":"                \u0027type\u0027: spec_type"},{"line_number":160,"context_line":"                },"},{"line_number":161,"context_line":"            \u0027status\u0027: {"},{"line_number":162,"context_line":"                }"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3b8b51c0","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":33},"updated":"2020-09-09 10:03:47.000000000","message":"should this also include the provider?","commit_id":"aac00433fd3ad3f367043108359663b510162489"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d5f3a67925bb5d79509447266cf0e8e422c2763a","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            kubernetes.patch_crd("},{"line_number":373,"context_line":"                \u0027spec\u0027,"},{"line_number":374,"context_line":"                loadbalancer_crd[\u0027metadata\u0027][\u0027selfLink\u0027],"},{"line_number":375,"context_line":"                {\u0027endpointSlices\u0027: epslices, \u0027provider\u0027: provider})"},{"line_number":376,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":377,"context_line":"            LOG.debug(\u0027KuryrLoadbalancer CRD not found %s\u0027, loadbalancer_crd)"},{"line_number":378,"context_line":"        except k_exc.K8sConflict:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_4c893f24","line":375,"range":{"start_line":375,"start_character":1,"end_line":375,"end_character":67},"updated":"2020-09-08 15:55:22.000000000","message":"this is getting the next: http://paste.openstack.org/show/797597/","commit_id":"aac00433fd3ad3f367043108359663b510162489"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"963537fc94cdd193e5e64ed326b5fb66e340bfd4","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        epslices \u003d self._convert_subsets_to_endpointslice(endpoints)"},{"line_number":373,"context_line":"        endpointSlices \u003d {\u0027endpointSlices\u0027: epslices}"},{"line_number":374,"context_line":"        if self._lb_provider:"},{"line_number":375,"context_line":"            endpointSlices[\u0027provider\u0027] \u003d self._lb_provider"},{"line_number":376,"context_line":"        try:"},{"line_number":377,"context_line":"            kubernetes.patch_crd("},{"line_number":378,"context_line":"                \u0027spec\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a946fb79","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":26},"updated":"2020-09-09 12:38:37.000000000","message":"Could this get renamed to spec? It might be confusing as if the provider was included in the endpointsSlice field.","commit_id":"a0ec13daa9f80a70a789d951968b04d307d3bd55"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e078270f20c2102ae1c97bdc7caf5162e19e0cb3","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        epslices \u003d self._convert_subsets_to_endpointslice(endpoints)"},{"line_number":373,"context_line":"        endpointSlices \u003d {\u0027endpointSlices\u0027: epslices}"},{"line_number":374,"context_line":"        if self._lb_provider:"},{"line_number":375,"context_line":"            endpointSlices[\u0027provider\u0027] \u003d self._lb_provider"},{"line_number":376,"context_line":"        try:"},{"line_number":377,"context_line":"            kubernetes.patch_crd("},{"line_number":378,"context_line":"                \u0027spec\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_04f9ce7e","line":375,"range":{"start_line":375,"start_character":12,"end_line":375,"end_character":26},"in_reply_to":"9f560f44_a946fb79","updated":"2020-09-09 13:03:21.000000000","message":"right!","commit_id":"a0ec13daa9f80a70a789d951968b04d307d3bd55"}],"kuryr_kubernetes/controller/handlers/loadbalancer.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"764725b0ba9ca9e8f94051f7e9a190fceb2194b1","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        return changed"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    def _ensure_release_lbaas(self, loadbalancer_crd, svc\u003dNone):"},{"line_number":728,"context_line":"        attempts \u003d 0"},{"line_number":729,"context_line":"        deadline \u003d 0"},{"line_number":730,"context_line":"        retry \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_1c598c5a","line":727,"range":{"start_line":727,"start_character":53,"end_line":727,"end_character":63},"updated":"2020-09-02 12:06:49.000000000","message":"As this method is called once with only the loadbalancer_crd, this extra parameter can get removed.","commit_id":"ccde0a170bc285c80e7609226ad62654b1e8a52c"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"d3f3b44fc2b50341348781d53f67aad14d07c9fe","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        return changed"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"    def _ensure_release_lbaas(self, loadbalancer_crd, svc\u003dNone):"},{"line_number":728,"context_line":"        attempts \u003d 0"},{"line_number":729,"context_line":"        deadline \u003d 0"},{"line_number":730,"context_line":"        retry \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f20de1e8","line":727,"range":{"start_line":727,"start_character":53,"end_line":727,"end_character":63},"in_reply_to":"9f560f44_1c598c5a","updated":"2020-09-02 18:53:08.000000000","message":"Done","commit_id":"ccde0a170bc285c80e7609226ad62654b1e8a52c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"764725b0ba9ca9e8f94051f7e9a190fceb2194b1","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                          loadbalancer_crd[\u0027status\u0027][\u0027loadbalancer\u0027][\u0027name\u0027])"},{"line_number":750,"context_line":"                attempts +\u003d 1"},{"line_number":751,"context_line":"                retry \u003d True"},{"line_number":752,"context_line":"        if svc:"},{"line_number":753,"context_line":"            endpoints_link \u003d utils.get_endpoints_link(svc)"},{"line_number":754,"context_line":"            k8s \u003d clients.get_kubernetes_client()"},{"line_number":755,"context_line":"            try:"},{"line_number":756,"context_line":"                endpoints \u003d k8s.get(endpoints_link)"},{"line_number":757,"context_line":"            except k_exc.K8sResourceNotFound:"},{"line_number":758,"context_line":"                LOG.debug(\"Endpoint not Found.\")"},{"line_number":759,"context_line":"                return"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"            lbaas \u003d utils.get_lbaas_state(endpoints)"},{"line_number":762,"context_line":"            if lbaas:"},{"line_number":763,"context_line":"                loadbalancer_crd[\u0027status\u0027] \u003d {}"},{"line_number":764,"context_line":"                k8s \u003d clients.get_kubernetes_client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_dc471477","line":761,"range":{"start_line":752,"start_character":0,"end_line":761,"end_character":52},"updated":"2020-09-02 12:06:49.000000000","message":"Looks like this is not needed anymore.","commit_id":"ccde0a170bc285c80e7609226ad62654b1e8a52c"},{"author":{"_account_id":30963,"name":"Sarka Scavnicka","display_name":"sscavnic","email":"scavnicka.sarka@gmail.com","username":"sarka_scavnicka"},"change_message_id":"d3f3b44fc2b50341348781d53f67aad14d07c9fe","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                          loadbalancer_crd[\u0027status\u0027][\u0027loadbalancer\u0027][\u0027name\u0027])"},{"line_number":750,"context_line":"                attempts +\u003d 1"},{"line_number":751,"context_line":"                retry \u003d True"},{"line_number":752,"context_line":"        if svc:"},{"line_number":753,"context_line":"            endpoints_link \u003d utils.get_endpoints_link(svc)"},{"line_number":754,"context_line":"            k8s \u003d clients.get_kubernetes_client()"},{"line_number":755,"context_line":"            try:"},{"line_number":756,"context_line":"                endpoints \u003d k8s.get(endpoints_link)"},{"line_number":757,"context_line":"            except k_exc.K8sResourceNotFound:"},{"line_number":758,"context_line":"                LOG.debug(\"Endpoint not Found.\")"},{"line_number":759,"context_line":"                return"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"            lbaas \u003d utils.get_lbaas_state(endpoints)"},{"line_number":762,"context_line":"            if lbaas:"},{"line_number":763,"context_line":"                loadbalancer_crd[\u0027status\u0027] \u003d {}"},{"line_number":764,"context_line":"                k8s \u003d clients.get_kubernetes_client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_32f759d7","line":761,"range":{"start_line":752,"start_character":0,"end_line":761,"end_character":52},"in_reply_to":"9f560f44_dc471477","updated":"2020-09-02 18:53:08.000000000","message":"Done","commit_id":"ccde0a170bc285c80e7609226ad62654b1e8a52c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f980f121d7e81192c7a5fa91310d43e6c9d31659","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if crd_lb:"},{"line_number":64,"context_line":"            lb_provider \u003d crd_lb.get(\u0027provider\u0027)"},{"line_number":65,"context_line":"            if loadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027) !\u003d lb_provider:"},{"line_number":66,"context_line":"                eventlet.spawn(self._ensure_release_lbaas, loadbalancer_crd)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            name \u003d loadbalancer_crd[\u0027metadata\u0027][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_492fb63d","line":66,"range":{"start_line":66,"start_character":17,"end_line":66,"end_character":76},"updated":"2020-09-03 07:49:49.000000000","message":"should this be executed directly, not in a different thread? There may be problems if we try to delete the lbs and the CRD status while at the same time we are trying to remove/add members/listeners/pools and the loadbalancer (as there will be a VIP collision), and specially if we try to update the CRD status in parallel","commit_id":"052474f77ef16f27013314a8db3133c7c76b46ee"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3d94cb312a9337a6889b144f2eac3b38164648a5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if crd_lb:"},{"line_number":64,"context_line":"            lb_provider \u003d crd_lb.get(\u0027provider\u0027)"},{"line_number":65,"context_line":"            if loadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027) !\u003d lb_provider:"},{"line_number":66,"context_line":"                eventlet.spawn(self._ensure_release_lbaas, loadbalancer_crd)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        try:"},{"line_number":69,"context_line":"            name \u003d loadbalancer_crd[\u0027metadata\u0027][\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_81b23048","line":66,"range":{"start_line":66,"start_character":17,"end_line":66,"end_character":76},"in_reply_to":"9f560f44_492fb63d","updated":"2020-09-04 08:02:22.000000000","message":"+1","commit_id":"052474f77ef16f27013314a8db3133c7c76b46ee"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f980f121d7e81192c7a5fa91310d43e6c9d31659","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                attempts +\u003d 1"},{"line_number":751,"context_line":"                retry \u003d True"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"            endpoints \u003d loadbalancer_crd[\u0027spec\u0027].get(\u0027endpointSlices\u0027)"},{"line_number":754,"context_line":"            if endpoints:"},{"line_number":755,"context_line":"                loadbalancer_crd[\u0027status\u0027] \u003d {}"},{"line_number":756,"context_line":"                k8s \u003d clients.get_kubernetes_client()"},{"line_number":757,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a90db2e9","line":754,"range":{"start_line":753,"start_character":0,"end_line":754,"end_character":25},"updated":"2020-09-03 07:49:49.000000000","message":"do we need to check if there is endpoints? or it will be sufficient with cleaning up the status?","commit_id":"052474f77ef16f27013314a8db3133c7c76b46ee"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a96f1136c1b5fa74aee786df9948344db7babeae","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        crd_lb \u003d loadbalancer_crd[\u0027status\u0027].get(\u0027loadbalancer\u0027)"},{"line_number":62,"context_line":"        if crd_lb:"},{"line_number":63,"context_line":"            lb_provider \u003d crd_lb.get(\u0027provider\u0027)"},{"line_number":64,"context_line":"            if loadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027) !\u003d lb_provider:"},{"line_number":65,"context_line":"                self._ensure_release_lbaas(loadbalancer_crd)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f6d01056","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":71},"updated":"2020-09-04 07:04:42.000000000","message":"maybe here we need to be explicit about provider \"none|default\", \"amphora\", and \"octavia\" are the same","commit_id":"aac00433fd3ad3f367043108359663b510162489"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e92e7c093f80189c5ea9404027e5cda6af5e78ef","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        crd_lb \u003d loadbalancer_crd[\u0027status\u0027].get(\u0027loadbalancer\u0027)"},{"line_number":62,"context_line":"        if crd_lb:"},{"line_number":63,"context_line":"            lb_provider \u003d crd_lb.get(\u0027provider\u0027)"},{"line_number":64,"context_line":"            if loadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027) !\u003d lb_provider:"},{"line_number":65,"context_line":"                self._ensure_release_lbaas(loadbalancer_crd)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_61027c40","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":71},"in_reply_to":"9f560f44_f6d01056","updated":"2020-09-04 08:59:11.000000000","message":"Yes. We would need to check if the config is in (\u0027default\u0027, \u0027octavia\u0027, \u0027amphora\u0027), the lb provider should also be, otherwise remove it.","commit_id":"aac00433fd3ad3f367043108359663b510162489"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e92e7c093f80189c5ea9404027e5cda6af5e78ef","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                    security_groups_ids\u003dloadbalancer_crd[\u0027spec\u0027].get("},{"line_number":701,"context_line":"                        \u0027security_groups_ids\u0027),"},{"line_number":702,"context_line":"                    service_type\u003dloadbalancer_crd[\u0027spec\u0027].get(\u0027type\u0027),"},{"line_number":703,"context_line":"                    provider\u003dloadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027))"},{"line_number":704,"context_line":"                loadbalancer_crd[\u0027status\u0027][\u0027loadbalancer\u0027] \u003d lb"},{"line_number":705,"context_line":"                changed \u003d True"},{"line_number":706,"context_line":"            elif loadbalancer_crd[\u0027status\u0027].get(\u0027service_pub_ip_info\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_81a5104a","line":703,"range":{"start_line":703,"start_character":29,"end_line":703,"end_character":69},"updated":"2020-09-04 08:59:11.000000000","message":"With the suggestion to remove the None from _lb_provider definition, we need to ensure None is passed to the provider  only when loadbalancer_crd[\u0027spec\u0027].get(\u0027provider\u0027) is in (\u0027default\u0027, \u0027octavia\u0027, \u0027amphora\u0027) so we can let Octavia use whatever it has set as the default provider.","commit_id":"aac00433fd3ad3f367043108359663b510162489"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"963537fc94cdd193e5e64ed326b5fb66e340bfd4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                        spec_lb_provider not in OCTAVIA_DEFAULT_PROVIDERS):"},{"line_number":71,"context_line":"                    self._ensure_release_lbaas(loadbalancer_crd)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            # ovn to amphora downgrade"},{"line_number":74,"context_line":"            elif lb_provider and lb_provider not in OCTAVIA_DEFAULT_PROVIDERS:"},{"line_number":75,"context_line":"                if (not spec_lb_provider or"},{"line_number":76,"context_line":"                        spec_lb_provider in OCTAVIA_DEFAULT_PROVIDERS):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_84279eb6","line":73,"range":{"start_line":73,"start_character":12,"end_line":73,"end_character":38},"updated":"2020-09-09 12:38:37.000000000","message":"cool!","commit_id":"a0ec13daa9f80a70a789d951968b04d307d3bd55"}]}