)]}'
{"kuryr_kubernetes/controller/handlers/vif.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"642daf30aee0b7ae7e393f98705797ada259fc58","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            # annotations, force an emition of event to trigger on_finalize"},{"line_number":119,"context_line":"            # method on the KuryrPort."},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                k8s.annotate(kp[\u0027metadata\u0027][\u0027selfLink\u0027], {\u0027KuryrTrigger\u0027: \u00271\u0027})"},{"line_number":122,"context_line":"            except k_exc.K8sClientException:"},{"line_number":123,"context_line":"                LOG.error(\u0027Cannot annotate existsing KuryrPort %s.\u0027,"},{"line_number":124,"context_line":"                          kp[\u0027metadata\u0027][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7e7f6514","line":121,"range":{"start_line":121,"start_character":16,"end_line":121,"end_character":79},"updated":"2020-08-25 07:11:37.000000000","message":"is it possible to annotate terminating objects?","commit_id":"edf994391ececa59d190d1198152efa6eda1c6b8"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"303f22ecda385f66788cbcd5d4ba98d4c9e97439","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            # annotations, force an emition of event to trigger on_finalize"},{"line_number":119,"context_line":"            # method on the KuryrPort."},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                k8s.annotate(kp[\u0027metadata\u0027][\u0027selfLink\u0027], {\u0027KuryrTrigger\u0027: \u00271\u0027})"},{"line_number":122,"context_line":"            except k_exc.K8sClientException:"},{"line_number":123,"context_line":"                LOG.error(\u0027Cannot annotate existsing KuryrPort %s.\u0027,"},{"line_number":124,"context_line":"                          kp[\u0027metadata\u0027][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_e9d6214f","line":121,"range":{"start_line":121,"start_character":16,"end_line":121,"end_character":79},"in_reply_to":"9f560f44_7e7f6514","updated":"2020-08-25 08:22:26.000000000","message":"Yes. I\u0027ve tried that, and that works :)\n\nWithout this (which trigger change on kuryrport) we have to wait ~2 minutes for reconciliation, so that kuryrport handler will be poked again to see if anything changes.\n\nWith forcing changes, we will smoothly remove  both - pod and the kuryport.","commit_id":"edf994391ececa59d190d1198152efa6eda1c6b8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"642daf30aee0b7ae7e393f98705797ada259fc58","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                k8s.annotate(kp[\u0027metadata\u0027][\u0027selfLink\u0027], {\u0027KuryrTrigger\u0027: \u00271\u0027})"},{"line_number":122,"context_line":"            except k_exc.K8sClientException:"},{"line_number":123,"context_line":"                LOG.error(\u0027Cannot annotate existsing KuryrPort %s.\u0027,"},{"line_number":124,"context_line":"                          kp[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":125,"context_line":"                k8s.remove_finalizer(pod, constants.POD_FINALIZER)"},{"line_number":126,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fe8b751b","line":123,"range":{"start_line":123,"start_character":43,"end_line":123,"end_character":52},"updated":"2020-08-25 07:11:37.000000000","message":"exiting? or existing?","commit_id":"edf994391ececa59d190d1198152efa6eda1c6b8"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"303f22ecda385f66788cbcd5d4ba98d4c9e97439","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                k8s.annotate(kp[\u0027metadata\u0027][\u0027selfLink\u0027], {\u0027KuryrTrigger\u0027: \u00271\u0027})"},{"line_number":122,"context_line":"            except k_exc.K8sClientException:"},{"line_number":123,"context_line":"                LOG.error(\u0027Cannot annotate existsing KuryrPort %s.\u0027,"},{"line_number":124,"context_line":"                          kp[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":125,"context_line":"                k8s.remove_finalizer(pod, constants.POD_FINALIZER)"},{"line_number":126,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_c9199d22","line":123,"range":{"start_line":123,"start_character":43,"end_line":123,"end_character":52},"in_reply_to":"9f560f44_fe8b751b","updated":"2020-08-25 08:22:26.000000000","message":"Excellenting ;P Will correct that.","commit_id":"edf994391ececa59d190d1198152efa6eda1c6b8"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"a01f27e0796c3b57ea03460438153e9813a56a68","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # method on the KuryrPort."},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                k8s.annotate(kp[\u0027metadata\u0027][\u0027selfLink\u0027], {\u0027KuryrTrigger\u0027: \u00271\u0027})"},{"line_number":122,"context_line":"            except k_exc.K8sClientException:"},{"line_number":123,"context_line":"                LOG.error(\u0027Cannot annotate existing KuryrPort %s.\u0027,"},{"line_number":124,"context_line":"                          kp[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":125,"context_line":"                k8s.remove_finalizer(pod, constants.POD_FINALIZER)"},{"line_number":126,"context_line":"        else:"},{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                k8s.delete(KURYRPORT_URI"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_785c984a","line":125,"range":{"start_line":122,"start_character":0,"end_line":125,"end_character":66},"updated":"2020-08-25 11:03:26.000000000","message":"Shouldn\u0027t this get retried upon a general k8s exception and just remove the finalizer when a NotFound is raised?","commit_id":"d76a4fef1ee790430925ea8dcabc8e70c7b4ddb2"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"5442f2c13eb88bbcc954e65b235ad9d3056ecaab","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # method on the KuryrPort."},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                k8s.annotate(kp[\u0027metadata\u0027][\u0027selfLink\u0027], {\u0027KuryrTrigger\u0027: \u00271\u0027})"},{"line_number":122,"context_line":"            except k_exc.K8sClientException:"},{"line_number":123,"context_line":"                LOG.error(\u0027Cannot annotate existing KuryrPort %s.\u0027,"},{"line_number":124,"context_line":"                          kp[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":125,"context_line":"                k8s.remove_finalizer(pod, constants.POD_FINALIZER)"},{"line_number":126,"context_line":"        else:"},{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                k8s.delete(KURYRPORT_URI"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c3515064","line":125,"range":{"start_line":122,"start_character":0,"end_line":125,"end_character":66},"in_reply_to":"9f560f44_785c984a","updated":"2020-08-27 08:33:42.000000000","message":"Good point.","commit_id":"d76a4fef1ee790430925ea8dcabc8e70c7b4ddb2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f13db064b3db8ff1e56b6e848f806394b7a686b7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            # annotations, force an emition of event to trigger on_finalize"},{"line_number":119,"context_line":"            # method on the KuryrPort."},{"line_number":120,"context_line":"            try:"},{"line_number":121,"context_line":"                k8s.annotate(kp[\u0027metadata\u0027][\u0027selfLink\u0027], {\u0027KuryrTrigger\u0027: \u00271\u0027})"},{"line_number":122,"context_line":"            except k_exc.K8sResourceNotFound:"},{"line_number":123,"context_line":"                LOG.error(\u0027Cannot annotate existing KuryrPort %s.\u0027,"},{"line_number":124,"context_line":"                          kp[\u0027metadata\u0027][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_a6c53840","line":121,"range":{"start_line":121,"start_character":59,"end_line":121,"end_character":71},"updated":"2020-08-28 08:04:26.000000000","message":"We could probably came up with a better name but it\u0027s no biggie. ;)","commit_id":"98c78b75bb43c093039187612af05858c139a3b8"}]}