)]}'
{"kuryr_kubernetes/controller/handlers/kuryrport.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"45c70b1c3ead2d10276e1d09b7b6273f0fc54bd5","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            # TODO(gryf): Free resources"},{"line_number":135,"context_line":"            self.k8s.remove_finalizer(kuryrport_crd,"},{"line_number":136,"context_line":"                                      constants.KURYRPORT_FINALIZER)"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        project_id \u003d self._drv_project.get_project(pod)"},{"line_number":140,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_18975cee","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":17},"updated":"2020-08-25 10:56:30.000000000","message":"I guess, this could be exchanged with simply return. WDYT?","commit_id":"0e9097d37d365a0f1fd7f7576b07d4b16f302b18"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"50b312015052e938c9bf2b25c9088534ce6db9b9","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            # TODO(gryf): Free resources"},{"line_number":135,"context_line":"            self.k8s.remove_finalizer(kuryrport_crd,"},{"line_number":136,"context_line":"                                      constants.KURYRPORT_FINALIZER)"},{"line_number":137,"context_line":"            raise"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        project_id \u003d self._drv_project.get_project(pod)"},{"line_number":140,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2eac9a9d","line":137,"range":{"start_line":137,"start_character":12,"end_line":137,"end_character":17},"in_reply_to":"9f560f44_18975cee","updated":"2020-08-25 12:51:29.000000000","message":"I\u0027d just log and error and return - the problem with this is that we can\u0027t fix this on our own, no need to trigger potential restart of the controller here.","commit_id":"0e9097d37d365a0f1fd7f7576b07d4b16f302b18"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"50b312015052e938c9bf2b25c9088534ce6db9b9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            pod \u003d self.k8s.get(f\"{constants.K8S_API_NAMESPACES}\""},{"line_number":131,"context_line":"                               f\"/{namespace}/pods/{name}\")"},{"line_number":132,"context_line":"        except k_exc.K8sResourceNotFound as ex:"},{"line_number":133,"context_line":"            LOG.exception(\"Failed to get pod: %s\", ex)"},{"line_number":134,"context_line":"            # TODO(gryf): Free resources"},{"line_number":135,"context_line":"            self.k8s.remove_finalizer(kuryrport_crd,"},{"line_number":136,"context_line":"                                      constants.KURYRPORT_FINALIZER)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ee8e222c","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":54},"updated":"2020-08-25 12:51:29.000000000","message":"It might be good to make this more specific, like:\n\n f\"Pod {namespace}/{name} doesn\u0027t exist, deleting orphaned KuryrPort\"\n\nAlso I don\u0027t see a point in logging that traceback here, probably simple LOG.error will be enough.","commit_id":"9c96e64f0a7754d3e95c4f17f1b55839ae9ae2f8"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"c7754048005a35cd381303c74527e42a34e95c68","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            pod \u003d self.k8s.get(f\"{constants.K8S_API_NAMESPACES}\""},{"line_number":131,"context_line":"                               f\"/{namespace}/pods/{name}\")"},{"line_number":132,"context_line":"        except k_exc.K8sResourceNotFound as ex:"},{"line_number":133,"context_line":"            LOG.exception(\"Failed to get pod: %s\", ex)"},{"line_number":134,"context_line":"            # TODO(gryf): Free resources"},{"line_number":135,"context_line":"            self.k8s.remove_finalizer(kuryrport_crd,"},{"line_number":136,"context_line":"                                      constants.KURYRPORT_FINALIZER)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_6005f145","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":54},"in_reply_to":"9f560f44_ee8e222c","updated":"2020-08-26 08:04:07.000000000","message":"Done","commit_id":"9c96e64f0a7754d3e95c4f17f1b55839ae9ae2f8"}]}