)]}'
{"kuryr_kubernetes/controller/drivers/lb_public_ip.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e2edaba0ae6e625afcb0c8f008b9c72a84d42741","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(FloatingIpServicePubIPDriver, self).__init__()"},{"line_number":38,"context_line":"        self._drv_pub_ip \u003d public_ip.FipPubIpDriver()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def acquire_service_pub_ip_info(self, spec_type, spec_lb_ip, project_id,"},{"line_number":41,"context_line":"                                    port_id_to_be_associated\u003dNone):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if spec_type !\u003d \u0027LoadBalancer\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f27b4578","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":35},"updated":"2020-08-31 15:02:32.000000000","message":"removing the service does not need extra handling too?","commit_id":"794bd4e3098203f7f9641a593ba88da86543522a"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"329d1926960ad6f930838e36bd22aae0c0d68a45","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        super(FloatingIpServicePubIPDriver, self).__init__()"},{"line_number":38,"context_line":"        self._drv_pub_ip \u003d public_ip.FipPubIpDriver()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def acquire_service_pub_ip_info(self, spec_type, spec_lb_ip, project_id,"},{"line_number":41,"context_line":"                                    port_id_to_be_associated\u003dNone):"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if spec_type !\u003d \u0027LoadBalancer\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_599ded08","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":35},"in_reply_to":"9f560f44_f27b4578","updated":"2020-09-01 08:46:25.000000000","message":"It\u0027s not needed because the service_pub_ip_info field won\u0027t be present on the status of the lb crd and consequently not removed.","commit_id":"794bd4e3098203f7f9641a593ba88da86543522a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a5ba406bc1283ee077080b040837ea7eb0d7396a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if spec_lb_ip:"},{"line_number":47,"context_line":"            user_specified_ip \u003d spec_lb_ip.format()"},{"line_number":48,"context_line":"            res_id \u003d self._drv_pub_ip.is_ip_available(user_specified_ip,"},{"line_number":49,"context_line":"                                                      port_id_to_be_associated)"},{"line_number":50,"context_line":"            if res_id:"},{"line_number":51,"context_line":"                service_pub_ip_info \u003d {"},{"line_number":52,"context_line":"                    \u0027ip_id\u0027: res_id,"},{"line_number":53,"context_line":"                    \u0027ip_addr\u0027: str(user_specified_ip),"},{"line_number":54,"context_line":"                    \u0027alloc_method\u0027: \u0027user\u0027"},{"line_number":55,"context_line":"                }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                return service_pub_ip_info"},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                # user specified IP is not valid"},{"line_number":60,"context_line":"                LOG.error(\"IP\u003d%s is not available\", user_specified_ip)"},{"line_number":61,"context_line":"                return None"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            LOG.debug(\"Trying to allocate public ip from pool\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_94c90c5c","line":61,"range":{"start_line":47,"start_character":0,"end_line":61,"end_character":27},"updated":"2020-09-01 09:35:38.000000000","message":"I wonder how this works with FIP-less?","commit_id":"21a7fe8954ff91ddafd27fe6a2aec9b0da660795"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d09fce9f07728e61d96ea4ae999f5bbd7a800d0d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if spec_lb_ip:"},{"line_number":47,"context_line":"            user_specified_ip \u003d spec_lb_ip.format()"},{"line_number":48,"context_line":"            res_id \u003d self._drv_pub_ip.is_ip_available(user_specified_ip,"},{"line_number":49,"context_line":"                                                      port_id_to_be_associated)"},{"line_number":50,"context_line":"            if res_id:"},{"line_number":51,"context_line":"                service_pub_ip_info \u003d {"},{"line_number":52,"context_line":"                    \u0027ip_id\u0027: res_id,"},{"line_number":53,"context_line":"                    \u0027ip_addr\u0027: str(user_specified_ip),"},{"line_number":54,"context_line":"                    \u0027alloc_method\u0027: \u0027user\u0027"},{"line_number":55,"context_line":"                }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                return service_pub_ip_info"},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                # user specified IP is not valid"},{"line_number":60,"context_line":"                LOG.error(\"IP\u003d%s is not available\", user_specified_ip)"},{"line_number":61,"context_line":"                return None"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            LOG.debug(\"Trying to allocate public ip from pool\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_9f95a58b","line":61,"range":{"start_line":47,"start_character":0,"end_line":61,"end_character":27},"in_reply_to":"9f560f44_94c90c5c","updated":"2020-09-01 10:16:07.000000000","message":"hm, good question. I wonder how the user would provider a fip without having an external network present on the tenant. I guess that in case it manages to have a fip present the association to the lb port would fail as the fip network is not on the router.[1]\n\n[1] https://github.com/openshift/kuryr-kubernetes/blob/058ec188f2ad3e50d196078bc746e529fffcdf4d/kuryr_kubernetes/controller/drivers/public_ip.py#L174-L175","commit_id":"21a7fe8954ff91ddafd27fe6a2aec9b0da660795"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9a8e85e152ae8c3ec79d65644121d6c9c2762bf1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if spec_lb_ip:"},{"line_number":47,"context_line":"            user_specified_ip \u003d spec_lb_ip.format()"},{"line_number":48,"context_line":"            res_id \u003d self._drv_pub_ip.is_ip_available(user_specified_ip,"},{"line_number":49,"context_line":"                                                      port_id_to_be_associated)"},{"line_number":50,"context_line":"            if res_id:"},{"line_number":51,"context_line":"                service_pub_ip_info \u003d {"},{"line_number":52,"context_line":"                    \u0027ip_id\u0027: res_id,"},{"line_number":53,"context_line":"                    \u0027ip_addr\u0027: str(user_specified_ip),"},{"line_number":54,"context_line":"                    \u0027alloc_method\u0027: \u0027user\u0027"},{"line_number":55,"context_line":"                }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                return service_pub_ip_info"},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                # user specified IP is not valid"},{"line_number":60,"context_line":"                LOG.error(\"IP\u003d%s is not available\", user_specified_ip)"},{"line_number":61,"context_line":"                return None"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            LOG.debug(\"Trying to allocate public ip from pool\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_7f78912a","line":61,"range":{"start_line":47,"start_character":0,"end_line":61,"end_character":27},"in_reply_to":"9f560f44_9f95a58b","updated":"2020-09-01 10:32:39.000000000","message":"Hm, my bet is that it\u0027ll kinda work. That way user can specify any FIP even those that aren\u0027t connected to external network… Hm, okay, we can leave this untouched I think - worst case that can happen is we\u0027ll log an error that this is impossible to do.","commit_id":"21a7fe8954ff91ddafd27fe6a2aec9b0da660795"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"61e643de1022598980d16908beeb097f1c04ef89","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            return None"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if spec_lb_ip:"},{"line_number":47,"context_line":"            user_specified_ip \u003d spec_lb_ip.format()"},{"line_number":48,"context_line":"            res_id \u003d self._drv_pub_ip.is_ip_available(user_specified_ip,"},{"line_number":49,"context_line":"                                                      port_id_to_be_associated)"},{"line_number":50,"context_line":"            if res_id:"},{"line_number":51,"context_line":"                service_pub_ip_info \u003d {"},{"line_number":52,"context_line":"                    \u0027ip_id\u0027: res_id,"},{"line_number":53,"context_line":"                    \u0027ip_addr\u0027: str(user_specified_ip),"},{"line_number":54,"context_line":"                    \u0027alloc_method\u0027: \u0027user\u0027"},{"line_number":55,"context_line":"                }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                return service_pub_ip_info"},{"line_number":58,"context_line":"            else:"},{"line_number":59,"context_line":"                # user specified IP is not valid"},{"line_number":60,"context_line":"                LOG.error(\"IP\u003d%s is not available\", user_specified_ip)"},{"line_number":61,"context_line":"                return None"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            LOG.debug(\"Trying to allocate public ip from pool\")"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_df6b9d82","line":61,"range":{"start_line":47,"start_character":0,"end_line":61,"end_character":27},"in_reply_to":"9f560f44_9f95a58b","updated":"2020-09-01 10:25:18.000000000","message":"I thought this code was simply not called if we don\u0027t have the config for the external network","commit_id":"21a7fe8954ff91ddafd27fe6a2aec9b0da660795"}]}