)]}'
{"kuryr_kubernetes/controller/handlers/loadbalancer.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f8aebb84e07704f6cee86bef7503690452b58e9","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                f\u0027{k_const.K8S_API_NAMESPACES}/{svc_namespace}/\u0027"},{"line_number":221,"context_line":"                f\u0027services/{svc_name}\u0027)"},{"line_number":222,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":223,"context_line":"            LOG.debug(\u0027KuryrLoadBalancer CRD not found %s\u0027, svc_name)"},{"line_number":224,"context_line":"            return"},{"line_number":225,"context_line":"        except k_exc.K8sClientException:"},{"line_number":226,"context_line":"            LOG.exception(\u0027Error retrieving klb CRD %s\u0027, svc_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_8b61d8ab","line":223,"range":{"start_line":223,"start_character":23,"end_line":223,"end_character":40},"updated":"2020-09-02 08:17:43.000000000","message":"That\u0027s Service, isn\u0027t it?","commit_id":"4200c8ce9c1b81e75751de946380b49d007e8103"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f8aebb84e07704f6cee86bef7503690452b58e9","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            LOG.debug(\u0027KuryrLoadBalancer CRD not found %s\u0027, svc_name)"},{"line_number":224,"context_line":"            return"},{"line_number":225,"context_line":"        except k_exc.K8sClientException:"},{"line_number":226,"context_line":"            LOG.exception(\u0027Error retrieving klb CRD %s\u0027, svc_name)"},{"line_number":227,"context_line":"            raise"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        project_id \u003d self._drv_svc_project.get_project(service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_cb5bd0f3","line":226,"range":{"start_line":226,"start_character":44,"end_line":226,"end_character":47},"updated":"2020-09-02 08:17:43.000000000","message":"Same here?","commit_id":"4200c8ce9c1b81e75751de946380b49d007e8103"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f8aebb84e07704f6cee86bef7503690452b58e9","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                          klb_crd[\u0027metadata\u0027][\u0027selfLink\u0027],"},{"line_number":234,"context_line":"                          {\u0027security_groups\u0027: lb_sgs})"},{"line_number":235,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":236,"context_line":"            LOG.debug(\u0027KuryrLoadBalancer CRD not found %s\u0027, svc_name)"},{"line_number":237,"context_line":"        except k_exc.K8sClientException:"},{"line_number":238,"context_line":"            LOG.exception(\u0027Error syncing klb CRD %s\u0027, svc_name)"},{"line_number":239,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_2b724c7d","line":236,"range":{"start_line":236,"start_character":55,"end_line":236,"end_character":57},"updated":"2020-09-02 08:17:43.000000000","message":"I\u0027d move this to replace \"CRD\". Same in previous logs.","commit_id":"4200c8ce9c1b81e75751de946380b49d007e8103"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f8aebb84e07704f6cee86bef7503690452b58e9","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":236,"context_line":"            LOG.debug(\u0027KuryrLoadBalancer CRD not found %s\u0027, svc_name)"},{"line_number":237,"context_line":"        except k_exc.K8sClientException:"},{"line_number":238,"context_line":"            LOG.exception(\u0027Error syncing klb CRD %s\u0027, svc_name)"},{"line_number":239,"context_line":"            raise"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _add_new_members(self, loadbalancer_crd):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6b6c449c","line":238,"range":{"start_line":238,"start_character":45,"end_line":238,"end_character":48},"updated":"2020-09-02 08:17:43.000000000","message":"I\u0027d remove this.","commit_id":"4200c8ce9c1b81e75751de946380b49d007e8103"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f8aebb84e07704f6cee86bef7503690452b58e9","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":236,"context_line":"            LOG.debug(\u0027KuryrLoadBalancer CRD not found %s\u0027, svc_name)"},{"line_number":237,"context_line":"        except k_exc.K8sClientException:"},{"line_number":238,"context_line":"            LOG.exception(\u0027Error syncing klb CRD %s\u0027, svc_name)"},{"line_number":239,"context_line":"            raise"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _add_new_members(self, loadbalancer_crd):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_0b6dc898","line":238,"range":{"start_line":238,"start_character":41,"end_line":238,"end_character":44},"updated":"2020-09-02 08:17:43.000000000","message":"KuryrLoadBalancer?","commit_id":"4200c8ce9c1b81e75751de946380b49d007e8103"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c10d97a50e00397b06501d052753d48674eecb76","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _add_new_members(self, loadbalancer_crd):"},{"line_number":239,"context_line":"        changed \u003d False"},{"line_number":240,"context_line":"        try:"},{"line_number":241,"context_line":"            self._sync_lbaas_sgs(loadbalancer_crd)"},{"line_number":242,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":243,"context_line":"            LOG.debug(\"The svc has been deleted while processing the endpoints\""},{"line_number":244,"context_line":"                      \" update. No need to add new members.\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        lsnr_by_id \u003d {l[\u0027id\u0027]: l for l in loadbalancer_crd[\u0027status\u0027].get("},{"line_number":247,"context_line":"            \u0027listeners\u0027, [])}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_be297838","side":"PARENT","line":244,"range":{"start_line":240,"start_character":0,"end_line":244,"end_character":61},"updated":"2020-09-02 09:03:14.000000000","message":"Hm, but you\u0027re now reraising those exceptions in _sync_lbaas_sgs, is that fine to make it fatal error? Probably given that we have finalizers - yes, but I wanted to make sure. :)","commit_id":"75eb6236c6f976bdff9493656297c5529dbae6d1"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"c8e78a96adb1ce906c0139273153481349e300f6","unresolved":false,"context_lines":[{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _add_new_members(self, loadbalancer_crd):"},{"line_number":239,"context_line":"        changed \u003d False"},{"line_number":240,"context_line":"        try:"},{"line_number":241,"context_line":"            self._sync_lbaas_sgs(loadbalancer_crd)"},{"line_number":242,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":243,"context_line":"            LOG.debug(\"The svc has been deleted while processing the endpoints\""},{"line_number":244,"context_line":"                      \" update. No need to add new members.\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        lsnr_by_id \u003d {l[\u0027id\u0027]: l for l in loadbalancer_crd[\u0027status\u0027].get("},{"line_number":247,"context_line":"            \u0027listeners\u0027, [])}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_de6b8cee","side":"PARENT","line":244,"range":{"start_line":240,"start_character":0,"end_line":244,"end_character":61},"in_reply_to":"9f560f44_be297838","updated":"2020-09-02 09:30:16.000000000","message":"It would be working the same way as before but now with log messages. Note that the exception that was handled in here was K8sResourceNotFound, for any other exceptions this would have been fatal.","commit_id":"75eb6236c6f976bdff9493656297c5529dbae6d1"}]}