)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6b9e0a0546cf5354934a4c40e0260c712f49b867","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Maysa Macedo \u003cmaysa.macedo95@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-09-23 11:30:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up unused methods and not needed interecations to k8s API."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit removes some methods or variables definitions"},{"line_number":10,"context_line":"that are not used. Also, reorder or remove interactions to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_e55dc116","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":52},"updated":"2020-09-23 11:39:03.000000000","message":"interactions\n\n;)","commit_id":"9a940e000b6a0aa60aff0047d636288cb455564f"}],"kuryr_kubernetes/controller/handlers/loadbalancer.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"805be70903234e97f20bb431a8027042a437b450","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      loadbalancer_crd[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":68,"context_line":"            return"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            name \u003d loadbalancer_crd[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":72,"context_line":"            namespace \u003d loadbalancer_crd[\u0027metadata\u0027][\u0027namespace\u0027]"},{"line_number":73,"context_line":"            self._get_loadbalancer_crd(name, namespace)"},{"line_number":74,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":75,"context_line":"            LOG.debug(\u0027KuryrLoadbalancer CRD not found %s\u0027,"},{"line_number":76,"context_line":"                      loadbalancer_crd)"},{"line_number":77,"context_line":"        except KeyError:"},{"line_number":78,"context_line":"            LOG.debug(\u0027KuryrLoadbalancer CRD not found\u0027)"},{"line_number":79,"context_line":"            raise k_exc.ResourceNotReady(loadbalancer_crd)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if self._sync_lbaas_members(loadbalancer_crd):"},{"line_number":82,"context_line":"            # Note(yboaron) For LoadBalancer services, we should allocate FIP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_ae5e1d10","side":"PARENT","line":79,"range":{"start_line":70,"start_character":0,"end_line":79,"end_character":58},"updated":"2020-09-22 13:39:42.000000000","message":"I wonder if that wasn\u0027t to prevent processing events for Services that are gone…? Nevertheless the correct handling should probably be later on.","commit_id":"b890d99458daba09baee9073e0746a6bf4acb4b4"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6b548f7a70004a6a350f1c71d35f87a21958c6ca","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      loadbalancer_crd[\u0027metadata\u0027][\u0027name\u0027])"},{"line_number":68,"context_line":"            return"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            name \u003d loadbalancer_crd[\u0027metadata\u0027][\u0027name\u0027]"},{"line_number":72,"context_line":"            namespace \u003d loadbalancer_crd[\u0027metadata\u0027][\u0027namespace\u0027]"},{"line_number":73,"context_line":"            self._get_loadbalancer_crd(name, namespace)"},{"line_number":74,"context_line":"        except k_exc.K8sResourceNotFound:"},{"line_number":75,"context_line":"            LOG.debug(\u0027KuryrLoadbalancer CRD not found %s\u0027,"},{"line_number":76,"context_line":"                      loadbalancer_crd)"},{"line_number":77,"context_line":"        except KeyError:"},{"line_number":78,"context_line":"            LOG.debug(\u0027KuryrLoadbalancer CRD not found\u0027)"},{"line_number":79,"context_line":"            raise k_exc.ResourceNotReady(loadbalancer_crd)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if self._sync_lbaas_members(loadbalancer_crd):"},{"line_number":82,"context_line":"            # Note(yboaron) For LoadBalancer services, we should allocate FIP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_c5419d38","side":"PARENT","line":79,"range":{"start_line":70,"start_character":0,"end_line":79,"end_character":58},"in_reply_to":"9f560f44_ae5e1d10","updated":"2020-09-23 11:38:56.000000000","message":"hm, this is checking the existence of the CRD. I don\u0027t see a case when the CRD object passed to this event would be empty.","commit_id":"b890d99458daba09baee9073e0746a6bf4acb4b4"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f6839f9136e6eed0df9ae132fb4466a78e167cb7","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            service \u003d kubernetes.get(f\"{k_const.K8S_API_NAMESPACES}\""},{"line_number":157,"context_line":"                                     f\"/{namespace}/services/{name}\")"},{"line_number":158,"context_line":"        except k_exc.K8sResourceNotFound as ex:"},{"line_number":159,"context_line":"            LOG.exception(\"Failed to get service: %s\", ex)"},{"line_number":160,"context_line":"            return"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        LOG.debug(\u0027Removing finalizer from service %s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_45562d07","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":58},"updated":"2020-09-23 11:37:59.000000000","message":"If when Service is gone we don\u0027t really do anything, it\u0027s better log just a warning, without any traceback.","commit_id":"9a940e000b6a0aa60aff0047d636288cb455564f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"41393fb8e0d74e30ce726f90e8110f42806946b1","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            service \u003d kubernetes.get(f\"{k_const.K8S_API_NAMESPACES}\""},{"line_number":157,"context_line":"                                     f\"/{namespace}/services/{name}\")"},{"line_number":158,"context_line":"        except k_exc.K8sResourceNotFound as ex:"},{"line_number":159,"context_line":"            LOG.exception(\"Failed to get service: %s\", ex)"},{"line_number":160,"context_line":"            return"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        LOG.debug(\u0027Removing finalizer from service %s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_e5b2e149","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":58},"in_reply_to":"9f560f44_45562d07","updated":"2020-09-28 09:43:26.000000000","message":"Done","commit_id":"9a940e000b6a0aa60aff0047d636288cb455564f"}]}