)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f1d6b426d46aea18703b850fc5eca5b46f0a75b3","unresolved":false,"context_lines":[{"line_number":668,"context_line":"                      HTTP_INTERNAL_SERVER_ERROR_CODE)"},{"line_number":669,"context_line":"        try:"},{"line_number":670,"context_line":"            result \u003d create(args[0])"},{"line_number":671,"context_line":"            LOG.debug(\"Created %(obj)s\", {\u0027obj\u0027: result})"},{"line_number":672,"context_line":"            return result"},{"line_number":673,"context_line":"        except os_exc.HttpException as e:"},{"line_number":674,"context_line":"            if e.status_code in okay_codes:"},{"line_number":675,"context_line":"                result \u003d find(*args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2f9a946e","line":672,"range":{"start_line":671,"start_character":0,"end_line":672,"end_character":25},"updated":"2020-09-29 06:55:22.000000000","message":"perhaps this can be moved out of the try/except","commit_id":"4e278996631c724f9d18f4d95497f39692b82986"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"57ac540102048c541e0173daedeec544c16e397f","unresolved":false,"context_lines":[{"line_number":668,"context_line":"                      HTTP_INTERNAL_SERVER_ERROR_CODE)"},{"line_number":669,"context_line":"        try:"},{"line_number":670,"context_line":"            result \u003d create(args[0])"},{"line_number":671,"context_line":"            LOG.debug(\"Created %(obj)s\", {\u0027obj\u0027: result})"},{"line_number":672,"context_line":"            return result"},{"line_number":673,"context_line":"        except os_exc.HttpException as e:"},{"line_number":674,"context_line":"            if e.status_code in okay_codes:"},{"line_number":675,"context_line":"                result \u003d find(*args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e957f726","line":672,"range":{"start_line":671,"start_character":0,"end_line":672,"end_character":25},"in_reply_to":"9f560f44_2f9a946e","updated":"2020-09-29 11:04:08.000000000","message":"I think it\u0027s better to leave it with the exception handling to give a chance to find the resource.","commit_id":"4e278996631c724f9d18f4d95497f39692b82986"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6a3eae4e00e861235de318a6bb5314dc9cd650e8","unresolved":false,"context_lines":[{"line_number":668,"context_line":"                      HTTP_INTERNAL_SERVER_ERROR_CODE)"},{"line_number":669,"context_line":"        try:"},{"line_number":670,"context_line":"            result \u003d create(args[0])"},{"line_number":671,"context_line":"            LOG.debug(\"Created %(obj)s\", {\u0027obj\u0027: result})"},{"line_number":672,"context_line":"            return result"},{"line_number":673,"context_line":"        except os_exc.HttpException as e:"},{"line_number":674,"context_line":"            if e.status_code in okay_codes:"},{"line_number":675,"context_line":"                result \u003d find(*args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2dc8c5a6","line":672,"range":{"start_line":671,"start_character":0,"end_line":672,"end_character":25},"in_reply_to":"9f560f44_e957f726","updated":"2020-09-30 12:48:54.000000000","message":"I don\u0027t get this. I meant just the return result, to move it after the try/except. return should not raise any exception, right? Also, the Log can also be moved out","commit_id":"4e278996631c724f9d18f4d95497f39692b82986"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"a2ad90cb61526b6e4c8cca794001819e8d8f0c63","unresolved":false,"context_lines":[{"line_number":50,"context_line":"_OCTAVIA_PROVIDER_VERSION \u003d 2, 6"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# HTTP Codes raised by Octavia when a Resource already exists"},{"line_number":53,"context_line":"OKAY_CODES \u003d (409, 500)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class LBaaSv2Driver(base.LBaaSDriver):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_f7dea13a","line":53,"range":{"start_line":53,"start_character":19,"end_line":53,"end_character":22},"updated":"2020-09-30 04:25:21.000000000","message":"I guess 500 is totally not okay. Relying on internal server error (so probably Octavia crash) isn\u0027t best approach, unless there is something with Octavia I can\u0027t see at first glance. Perhaps we should raise not ready for further waiting?","commit_id":"464e82f56c73d5edd36c15f44a80bdc98b919500"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"ec99f71e4ad1a03fd1b3ccabaf218f340866f968","unresolved":false,"context_lines":[{"line_number":50,"context_line":"_OCTAVIA_PROVIDER_VERSION \u003d 2, 6"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# HTTP Codes raised by Octavia when a Resource already exists"},{"line_number":53,"context_line":"OKAY_CODES \u003d (409, 500)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class LBaaSv2Driver(base.LBaaSDriver):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_1f588255","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":23},"updated":"2020-09-30 15:13:46.000000000","message":"We will need to sort this out eventualy. Probably that\u0027s an issue on Octavia side.","commit_id":"47b9c196058767521bf31c3868959567121baeee"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"59beae36151bff0d3b2112e55bf4d78fb21d3873","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            \u0027provider\u0027: provider"},{"line_number":145,"context_line":"        }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        response \u003d self._ensure_loadbalancer(request)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if not response:"},{"line_number":150,"context_line":"            # NOTE(ivc): load balancer was present before \u0027create\u0027, but got"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_b5b7f7f8","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":53},"updated":"2020-09-30 16:20:40.000000000","message":"this is wrong... it is calling itself","commit_id":"47b9c196058767521bf31c3868959567121baeee"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9a249806b04496d6e693e83b7990715d6e65bf95","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            \u0027provider\u0027: provider"},{"line_number":145,"context_line":"        }"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        response \u003d self._ensure_loadbalancer(request)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if not response:"},{"line_number":150,"context_line":"            # NOTE(ivc): load balancer was present before \u0027create\u0027, but got"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_35cbe773","line":147,"range":{"start_line":147,"start_character":8,"end_line":147,"end_character":53},"in_reply_to":"9f560f44_b5b7f7f8","updated":"2020-09-30 16:21:27.000000000","message":"ahh, sorry... I missed the _","commit_id":"47b9c196058767521bf31c3868959567121baeee"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"9997ba99749d5c91305dd8ded30e632f6ec8f6ab","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        except os_exc.HttpException as e:"},{"line_number":675,"context_line":"            if e.status_code not in OKAY_CODES:"},{"line_number":676,"context_line":"                raise"},{"line_number":677,"context_line":"            else:"},{"line_number":678,"context_line":"                result \u003d find(obj, loadbalancer)"},{"line_number":679,"context_line":"                # check if member requires update"},{"line_number":680,"context_line":"                if (result and"},{"line_number":681,"context_line":"                        obj[\u0027name\u0027] !\u003d result.get(\u0027name\u0027) and"},{"line_number":682,"context_line":"                        update):"},{"line_number":683,"context_line":"                    update(result[\u0027id\u0027], obj[\u0027pool_id\u0027],"},{"line_number":684,"context_line":"                           name\u003dobj[\u0027name\u0027])"},{"line_number":685,"context_line":"                    result[\u0027name\u0027] \u003d obj[\u0027name\u0027]"},{"line_number":686,"context_line":"        if result:"},{"line_number":687,"context_line":"            LOG.debug(\"Found %(obj)s\", {\u0027obj\u0027: result})"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_df739d4d","line":684,"range":{"start_line":677,"start_character":8,"end_line":684,"end_character":44},"updated":"2020-10-01 11:22:56.000000000","message":"this can be unindented, since on successful try: you\u0027ll return, and raising will only occur on 409 and 500.\n\nso it can be wrote as:\n\n  try:\n     ...\n  except os_exc.HttpException as ex:\n    if ex.status_code not in OKAY_CODES: raise\n  \n  result \u003d find(…","commit_id":"6dd1877479ce2d086d4720583859001e2f684d4f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3155bb69b70f43eb0f5a4db4c3356c3b1bb7f462","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        except os_exc.HttpException as e:"},{"line_number":675,"context_line":"            if e.status_code not in OKAY_CODES:"},{"line_number":676,"context_line":"                raise"},{"line_number":677,"context_line":"            else:"},{"line_number":678,"context_line":"                result \u003d find(obj, loadbalancer)"},{"line_number":679,"context_line":"                # check if member requires update"},{"line_number":680,"context_line":"                if (result and"},{"line_number":681,"context_line":"                        obj[\u0027name\u0027] !\u003d result.get(\u0027name\u0027) and"},{"line_number":682,"context_line":"                        update):"},{"line_number":683,"context_line":"                    update(result[\u0027id\u0027], obj[\u0027pool_id\u0027],"},{"line_number":684,"context_line":"                           name\u003dobj[\u0027name\u0027])"},{"line_number":685,"context_line":"                    result[\u0027name\u0027] \u003d obj[\u0027name\u0027]"},{"line_number":686,"context_line":"        if result:"},{"line_number":687,"context_line":"            LOG.debug(\"Found %(obj)s\", {\u0027obj\u0027: result})"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_7f589156","line":684,"range":{"start_line":677,"start_character":8,"end_line":684,"end_character":44},"in_reply_to":"9f560f44_5fcdcd2e","updated":"2020-10-01 11:40:12.000000000","message":"true, thanks.","commit_id":"6dd1877479ce2d086d4720583859001e2f684d4f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"a583d71410f0249140e90040851ac7b031629ace","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        except os_exc.HttpException as e:"},{"line_number":675,"context_line":"            if e.status_code not in OKAY_CODES:"},{"line_number":676,"context_line":"                raise"},{"line_number":677,"context_line":"            else:"},{"line_number":678,"context_line":"                result \u003d find(obj, loadbalancer)"},{"line_number":679,"context_line":"                # check if member requires update"},{"line_number":680,"context_line":"                if (result and"},{"line_number":681,"context_line":"                        obj[\u0027name\u0027] !\u003d result.get(\u0027name\u0027) and"},{"line_number":682,"context_line":"                        update):"},{"line_number":683,"context_line":"                    update(result[\u0027id\u0027], obj[\u0027pool_id\u0027],"},{"line_number":684,"context_line":"                           name\u003dobj[\u0027name\u0027])"},{"line_number":685,"context_line":"                    result[\u0027name\u0027] \u003d obj[\u0027name\u0027]"},{"line_number":686,"context_line":"        if result:"},{"line_number":687,"context_line":"            LOG.debug(\"Found %(obj)s\", {\u0027obj\u0027: result})"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_5fcdcd2e","line":684,"range":{"start_line":677,"start_character":8,"end_line":684,"end_character":44},"in_reply_to":"9f560f44_df739d4d","updated":"2020-10-01 11:31:59.000000000","message":"…will occur on anything but 409 and 500 of course :)","commit_id":"6dd1877479ce2d086d4720583859001e2f684d4f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2adff8212a57b8e71260836467043f4c4ede4bf3","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        result \u003d find(obj, loadbalancer)"},{"line_number":678,"context_line":"        # check if member requires update"},{"line_number":679,"context_line":"        if result and obj[\u0027name\u0027] !\u003d result.get(\u0027name\u0027) and update:"},{"line_number":680,"context_line":"            update(result[\u0027id\u0027], obj[\u0027pool_id\u0027], name\u003dobj[\u0027name\u0027])"},{"line_number":681,"context_line":"            result[\u0027name\u0027] \u003d obj[\u0027name\u0027]"},{"line_number":682,"context_line":"        if result:"},{"line_number":683,"context_line":"            LOG.debug(\"Found %(obj)s\", {\u0027obj\u0027: result})"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ee14f4a1","line":680,"range":{"start_line":680,"start_character":0,"end_line":680,"end_character":66},"updated":"2020-10-01 13:06:21.000000000","message":"does this require try/except too? and a comment here will help too","commit_id":"b7578d2ded4b7914b84397808157dccdce60c75f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b91a26ca4b390e41e12057e7fe681982b7aa7d59","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        result \u003d find(obj, loadbalancer)"},{"line_number":678,"context_line":"        # check if member requires update"},{"line_number":679,"context_line":"        if result and obj[\u0027name\u0027] !\u003d result.get(\u0027name\u0027) and update:"},{"line_number":680,"context_line":"            update(result[\u0027id\u0027], obj[\u0027pool_id\u0027], name\u003dobj[\u0027name\u0027])"},{"line_number":681,"context_line":"            result[\u0027name\u0027] \u003d obj[\u0027name\u0027]"},{"line_number":682,"context_line":"        if result:"},{"line_number":683,"context_line":"            LOG.debug(\"Found %(obj)s\", {\u0027obj\u0027: result})"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_ee9514e5","line":680,"range":{"start_line":680,"start_character":0,"end_line":680,"end_character":66},"in_reply_to":"9f560f44_ee14f4a1","updated":"2020-10-01 13:12:19.000000000","message":"the try/except is not needed because it\u0027s handled at _ensure_provisioned on line 707.","commit_id":"b7578d2ded4b7914b84397808157dccdce60c75f"}],"kuryr_kubernetes/tests/unit/controller/drivers/test_lbaasv2.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27e97aea183e92368cd99d56daf7c8d8d20adc0b","unresolved":false,"context_lines":[{"line_number":930,"context_line":"            [mock.call(loadbalancer, t, d_lbaasv2._LB_STS_POLL_FAST_INTERVAL)"},{"line_number":931,"context_line":"             for t in timer])"},{"line_number":932,"context_line":"        m_driver._ensure.assert_has_calls("},{"line_number":933,"context_line":"            [mock.call(create, find,obj, loadbalancer)"},{"line_number":934,"context_line":"             for _ in timer])"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"    def test_release(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_d44b84ae","line":933,"updated":"2020-10-01 10:32:59.000000000","message":"pep8: E231 missing whitespace after \u0027,\u0027","commit_id":"e4efd4bb31200ef1a091a7aac05cb63464f54bd3"}]}