)]}'
{"kuryr_kubernetes/controller/handlers/kuryrport.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"99977099ede40f907d68c9d98202dbabafeac71b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            LOG.debug(\"Skipping SG rules deletion associated to the pod %s\","},{"line_number":169,"context_line":"                      pod)"},{"line_number":170,"context_line":"            crd_pod_selectors \u003d []"},{"line_number":171,"context_line":"        except k_exc.K8sClientException:"},{"line_number":172,"context_line":"            LOG.debug(\"Removing SG rules for pod %s failed - skipping.\", pod)"},{"line_number":173,"context_line":"            crd_pod_selectors \u003d []"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        try:"},{"line_number":176,"context_line":"            security_groups \u003d self._drv_sg.get_security_groups(pod, project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9c44ce1a","line":173,"range":{"start_line":171,"start_character":0,"end_line":173,"end_character":34},"updated":"2020-09-28 08:17:53.000000000","message":"I\u0027m not sure we can simply skip it... not sure if this could leak some NPs rules with some rules that should not be there. Perhaps we need to do a retry instead","commit_id":"021cf17853f534bace5faba12106f4b6938eb204"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"7fde1b992e24c31112cb06385df879957e42bf40","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            LOG.debug(\"Skipping SG rules deletion associated to the pod %s\","},{"line_number":169,"context_line":"                      pod)"},{"line_number":170,"context_line":"            crd_pod_selectors \u003d []"},{"line_number":171,"context_line":"        except k_exc.K8sClientException:"},{"line_number":172,"context_line":"            LOG.debug(\"Removing SG rules for pod %s failed - skipping.\", pod)"},{"line_number":173,"context_line":"            crd_pod_selectors \u003d []"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        try:"},{"line_number":176,"context_line":"            security_groups \u003d self._drv_sg.get_security_groups(pod, project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1f9710ed","line":173,"range":{"start_line":171,"start_character":0,"end_line":173,"end_character":34},"in_reply_to":"9f560f44_9c44ce1a","updated":"2020-09-28 10:03:05.000000000","message":"Do you think, that much more sense would be to add retry mechanism to \u0027get_kuryrnetworkpolicy_crds\u0027 function (which is used in delete_sg_rules method) instead?","commit_id":"021cf17853f534bace5faba12106f4b6938eb204"}]}
