)]}'
{"kuryr_kubernetes/controller/drivers/vif_pool.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"44d33415e5dae5f758a0cc3a0b86e4bf607a9616","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                except os_exc.SDKException:"},{"line_number":541,"context_line":"                    LOG.debug(\"Problem deleting leftover port %s. \""},{"line_number":542,"context_line":"                              \"Skipping.\", subport.id)"},{"line_number":543,"context_line":"                previous_ports_to_remove.remove(subport.id)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"            # normal ports, or subports not yet attached"},{"line_number":546,"context_line":"            existing_ports \u003d os_net.ports("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_3cdee73b","line":543,"range":{"start_line":543,"start_character":16,"end_line":543,"end_character":59},"updated":"2020-10-06 14:01:51.000000000","message":"Should it be removed from the list regardless if a failure to delete it happened?\nIt might be safer to only remove from the list if the actual deletion was successful.","commit_id":"4a17abdc8ddcacd9cec91878b54397c97297cb74"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"ea7c1c70e580c8022ba98a8420fd281ca9704e35","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                except os_exc.SDKException:"},{"line_number":541,"context_line":"                    LOG.debug(\"Problem deleting leftover port %s. \""},{"line_number":542,"context_line":"                              \"Skipping.\", subport.id)"},{"line_number":543,"context_line":"                previous_ports_to_remove.remove(subport.id)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"            # normal ports, or subports not yet attached"},{"line_number":546,"context_line":"            existing_ports \u003d os_net.ports("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5c7abb24","line":543,"range":{"start_line":543,"start_character":16,"end_line":543,"end_character":59},"in_reply_to":"9f560f44_3cdee73b","updated":"2020-10-06 14:02:40.000000000","message":"or if a not found issue was raised.","commit_id":"4a17abdc8ddcacd9cec91878b54397c97297cb74"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"bcdc7e5a3d667ad301785ff421c7f5428b232aa4","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                except os_exc.SDKException:"},{"line_number":541,"context_line":"                    LOG.debug(\"Problem deleting leftover port %s. \""},{"line_number":542,"context_line":"                              \"Skipping.\", subport.id)"},{"line_number":543,"context_line":"                previous_ports_to_remove.remove(subport.id)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"            # normal ports, or subports not yet attached"},{"line_number":546,"context_line":"            existing_ports \u003d os_net.ports("}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5cae3b2f","line":543,"range":{"start_line":543,"start_character":16,"end_line":543,"end_character":59},"in_reply_to":"9f560f44_5c7abb24","updated":"2020-10-06 14:19:06.000000000","message":"removing it from the list will only delay the removal, but yeah, I can add that","commit_id":"4a17abdc8ddcacd9cec91878b54397c97297cb74"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"44d33415e5dae5f758a0cc3a0b86e4bf607a9616","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                except os_exc.SDKException:"},{"line_number":571,"context_line":"                    LOG.debug(\"Problem deleting leftover port %s. \""},{"line_number":572,"context_line":"                              \"Skipping.\", port.id)"},{"line_number":573,"context_line":"                previous_ports_to_remove.remove(port.id)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"class NeutronVIFPool(BaseVIFPool):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5ccc7b89","line":573,"range":{"start_line":573,"start_character":16,"end_line":573,"end_character":56},"updated":"2020-10-06 14:01:51.000000000","message":"ditto","commit_id":"4a17abdc8ddcacd9cec91878b54397c97297cb74"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0f4c33d33d1a7f9371c76c3a48cb2edce89deb80","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                    LOG.debug(\"Problem deleting leftover port %s. \""},{"line_number":542,"context_line":"                              \"Skipping.\", subport.id)"},{"line_number":543,"context_line":"                else:"},{"line_number":544,"context_line":"                    previous_ports_to_remove.remove(subport.id)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"            # normal ports, or subports not yet attached"},{"line_number":547,"context_line":"            existing_ports \u003d os_net.ports("}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_47f028db","line":544,"range":{"start_line":544,"start_character":20,"end_line":544,"end_character":44},"updated":"2020-10-06 14:31:18.000000000","message":"If a not found is raised, I guess this wouldn\u0027t get cleaned up. But, it wouldn\u0027t be a problem, only the list would get bigger.","commit_id":"687a3cd20b2168b6062d5db4d9195b1513b31eb1"}]}