)]}'
{"kuryr_kubernetes/controller/drivers/utils.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"3c66e76e3c2a8009442dc9afdea6dc8a231dfbb6","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    return pairs"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"def zip_knp_np(knps, nps):"},{"line_number":364,"context_line":"    \"\"\"Returns tuples of matching KuryrNetworkPolicy and NetworkPolicy objs."},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    :param knps: List of KuryrNetworkPolicy objects"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_55bcb4ba","line":363,"range":{"start_line":363,"start_character":0,"end_line":363,"end_character":26},"updated":"2020-10-22 07:26:51.000000000","message":"should we simply change the name for this to zip_resources? And update where it is called from?","commit_id":"afbaa7320617252241a60ce7174f1d8681a1055f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"35731395cb7e96e24f60086ca2648752a408b54b","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    return nps.get(\u0027items\u0027, [])"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"def zip_resources(xs, ys):"},{"line_number":348,"context_line":"    \"\"\"Returns tuples of resources matched by namespace and name."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    :param xs: List of objects x, first level of iteration."},{"line_number":351,"context_line":"    :param ys: List of objects y."},{"line_number":352,"context_line":"    :return: List of tuples of matching (x, y)"},{"line_number":353,"context_line":"    \"\"\""},{"line_number":354,"context_line":"    pairs \u003d []"},{"line_number":355,"context_line":"    for x in xs:"},{"line_number":356,"context_line":"        for y in ys:"},{"line_number":357,"context_line":"            if utils.get_res_unique_name(x) \u003d\u003d utils.get_res_unique_name(y):"},{"line_number":358,"context_line":"                pairs.append((x, y))"},{"line_number":359,"context_line":"                break"},{"line_number":360,"context_line":"    return pairs"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"def zip_knp_np(knps, nps):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_6c7d9b1b","line":360,"range":{"start_line":347,"start_character":0,"end_line":360,"end_character":16},"updated":"2020-10-30 10:57:06.000000000","message":"it would be nice to eventually add a unit test for this method.","commit_id":"2296c8fbf2ab7ffe88147efc3a6efd0bb3da72cf"}],"kuryr_kubernetes/controller/handlers/kuryrport.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"2b94dc40a5ff93b425259ee8d0fa86e28a647a53","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        #               won\u0027t upgrade from version creating ports for host"},{"line_number":147,"context_line":"        #               networking pods."},{"line_number":148,"context_line":"        if (\u0027deletionTimestamp\u0027 not in pod[\u0027metadata\u0027] and"},{"line_number":149,"context_line":"                not driver_utils.is_host_network(pod)):"},{"line_number":150,"context_line":"            # NOTE(gryf): Ignore deleting KuryrPort, since most likely it was"},{"line_number":151,"context_line":"            # removed manually, while we need vifs for corresponding pod"},{"line_number":152,"context_line":"            # object which apperantely is still running."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_8608b3d9","line":149,"range":{"start_line":149,"start_character":16,"end_line":149,"end_character":19},"updated":"2020-10-27 09:54:56.000000000","message":"shouldn\u0027t it be skip in case the pod is on hostNetwork instead? and so avoid the attempt to delete the port.","commit_id":"2296c8fbf2ab7ffe88147efc3a6efd0bb3da72cf"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"35731395cb7e96e24f60086ca2648752a408b54b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        #               won\u0027t upgrade from version creating ports for host"},{"line_number":147,"context_line":"        #               networking pods."},{"line_number":148,"context_line":"        if (\u0027deletionTimestamp\u0027 not in pod[\u0027metadata\u0027] and"},{"line_number":149,"context_line":"                not driver_utils.is_host_network(pod)):"},{"line_number":150,"context_line":"            # NOTE(gryf): Ignore deleting KuryrPort, since most likely it was"},{"line_number":151,"context_line":"            # removed manually, while we need vifs for corresponding pod"},{"line_number":152,"context_line":"            # object which apperantely is still running."}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_2caba389","line":149,"range":{"start_line":149,"start_character":16,"end_line":149,"end_character":19},"in_reply_to":"3f65232a_7979b891","updated":"2020-10-30 10:57:06.000000000","message":"right.","commit_id":"2296c8fbf2ab7ffe88147efc3a6efd0bb3da72cf"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"431de1461a6794c899ae1226d3e5806c8bc48f54","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        #               won\u0027t upgrade from version creating ports for host"},{"line_number":147,"context_line":"        #               networking pods."},{"line_number":148,"context_line":"        if (\u0027deletionTimestamp\u0027 not in pod[\u0027metadata\u0027] and"},{"line_number":149,"context_line":"                not driver_utils.is_host_network(pod)):"},{"line_number":150,"context_line":"            # NOTE(gryf): Ignore deleting KuryrPort, since most likely it was"},{"line_number":151,"context_line":"            # removed manually, while we need vifs for corresponding pod"},{"line_number":152,"context_line":"            # object which apperantely is still running."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_7979b891","line":149,"range":{"start_line":149,"start_character":16,"end_line":149,"end_character":19},"in_reply_to":"3f65232a_8608b3d9","updated":"2020-10-27 10:59:12.000000000","message":"Uhm, I think no, here I wanted to make sure deletion of KuryrPorts for hostNetworking pods is possible. Without this change deletion of KuryrPorts for hostNetworking pods would be stopped here, so I needed to exclude them from early exit from on_finalize().","commit_id":"2296c8fbf2ab7ffe88147efc3a6efd0bb3da72cf"}]}