)]}'
{"kuryr_kubernetes/cni/binding/bridge.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1dc5d89da2223321cfb5190870d5342e0c8913e7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        with b_base.get_ipdb() as h_ipdb:"},{"line_number":40,"context_line":"            self._remove_ifaces(h_ipdb, (host_ifname,))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        interface_mtu \u003d vif.network.mtu"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        with b_base.get_ipdb(netns) as c_ipdb:"},{"line_number":45,"context_line":"            with c_ipdb.create(ifname\u003difname, peer\u003dhost_ifname,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_e75f08e3","line":42,"range":{"start_line":42,"start_character":7,"end_line":42,"end_character":39},"updated":"2020-10-23 06:54:18.000000000","message":"shouldn\u0027t we use network_device_mtu if its value is lower than the one on the network?","commit_id":"0a046585c95b6977434fe2f8f77f0ed24b273416"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"468d34c061f7d6d529580b3833a564cb7d3a881c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        interface_mtu \u003d vif.network.mtu"},{"line_number":43,"context_line":"        mtu_cfg \u003d CONF.neutron_defaults.network_device_mtu"},{"line_number":44,"context_line":"        if mtu_cfg and mtu_cfg \u003c interface_mtu:"},{"line_number":45,"context_line":"            interface_mtu \u003d CONF.neutron_defaults.network_device_mtu"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        with b_base.get_ipdb(netns) as c_ipdb:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_5103f6b8","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":18},"updated":"2020-10-27 06:40:56.000000000","message":"Default MTU is 1500. Do we even need checking if mtu_cfg is truthy?","commit_id":"17f99a71782caec0cbf73cb268fc55ef0d2dba06"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e57e8728c9b5012c5f5f75aa13003ce19dcdf7fb","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        interface_mtu \u003d vif.network.mtu"},{"line_number":43,"context_line":"        mtu_cfg \u003d CONF.neutron_defaults.network_device_mtu"},{"line_number":44,"context_line":"        if mtu_cfg and mtu_cfg \u003c interface_mtu:"},{"line_number":45,"context_line":"            interface_mtu \u003d CONF.neutron_defaults.network_device_mtu"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        with b_base.get_ipdb(netns) as c_ipdb:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_f11cc214","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":18},"in_reply_to":"3f65232a_5103f6b8","updated":"2020-10-27 06:45:30.000000000","message":"I changed the default value to be 0 to allow the default Neutron value is used.","commit_id":"17f99a71782caec0cbf73cb268fc55ef0d2dba06"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"4e3c3fa532077ce8365a83a58764ed3636a6e3e5","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        interface_mtu \u003d vif.network.mtu"},{"line_number":43,"context_line":"        mtu_cfg \u003d CONF.neutron_defaults.network_device_mtu"},{"line_number":44,"context_line":"        if mtu_cfg and mtu_cfg \u003c interface_mtu:"},{"line_number":45,"context_line":"            interface_mtu \u003d CONF.neutron_defaults.network_device_mtu"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        with b_base.get_ipdb(netns) as c_ipdb:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_ed6d0205","line":44,"range":{"start_line":44,"start_character":11,"end_line":44,"end_character":18},"in_reply_to":"3f65232a_f11cc214","updated":"2020-10-27 16:08:26.000000000","message":"Oh, right, I totally miss it :)","commit_id":"17f99a71782caec0cbf73cb268fc55ef0d2dba06"}],"kuryr_kubernetes/config.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"df5442030616f7049b4b96ef41759afe2b20a8d9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    cfg.IntOpt(\u0027network_device_mtu\u0027,"},{"line_number":225,"context_line":"               help\u003d\u0027Default MTU setting for network interface.\u0027,"},{"line_number":226,"context_line":"               default\u003d1500,),"},{"line_number":227,"context_line":"    cfg.IntOpt(\u0027network_mtu\u0027,"},{"line_number":228,"context_line":"               help\u003d\u0027MTU setting for network interface.\u0027,"},{"line_number":229,"context_line":"               default\u003d0),"},{"line_number":230,"context_line":"    cfg.IntOpt(\u0027lbaas_activation_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_553b149b","line":227,"range":{"start_line":227,"start_character":16,"end_line":227,"end_character":28},"updated":"2020-10-22 06:57:38.000000000","message":"shouldn\u0027t we use the above parameter network_device_mtu?","commit_id":"8f1934445831165c51afbf6cac1c2c3316cb504b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e18f8a60fcbcbea1614f7aa4e43f2d5df59a9912","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    cfg.StrOpt(\u0027external_svc_subnet\u0027,"},{"line_number":222,"context_line":"               help\u003d_(\"Optional external subnet ID for Kubernetes services\"),"},{"line_number":223,"context_line":"               default\u003dNone),"},{"line_number":224,"context_line":"    cfg.IntOpt(\u0027network_device_mtu\u0027,"},{"line_number":225,"context_line":"               help\u003d\u0027Default MTU setting for network interface.\u0027,"},{"line_number":226,"context_line":"               default\u003d0,),"},{"line_number":227,"context_line":"    cfg.IntOpt(\u0027lbaas_activation_timeout\u0027,"},{"line_number":228,"context_line":"               help\u003d_(\"Time (in seconds) that kuryr controller waits for \""},{"line_number":229,"context_line":"                      \"neutron LBaaS to be activated\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_64f021cb","line":226,"range":{"start_line":224,"start_character":0,"end_line":226,"end_character":27},"updated":"2020-10-29 14:40:09.000000000","message":"Oh, I haven\u0027t noticed we\u0027re changing the default. We should add a release note saying that.","commit_id":"17f99a71782caec0cbf73cb268fc55ef0d2dba06"}]}