)]}'
{"kuryr_cni/main.go":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9b210f4059402f32925101aa56ba5b24a590ca49","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\t\tif len(body) \u003e 1 {"},{"line_number":84,"context_line":"\t\t\tvar err types.Error"},{"line_number":85,"context_line":"\t\t\tjson.Unmarshal(body, \u0026err)"},{"line_number":86,"context_line":"\t\t\treturn []byte{}, err.Print()"},{"line_number":87,"context_line":"\t\t}"},{"line_number":88,"context_line":"\t\treturn []byte{}, errors.Errorf(\"CNI Daemon returned error %d %s\", resp.StatusCode, body)"},{"line_number":89,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":8,"id":"1f621f24_0346757d","line":86,"range":{"start_line":86,"start_character":20,"end_line":86,"end_character":31},"updated":"2020-10-30 14:24:23.000000000","message":"You shouldn\u0027t do Print() here, just return the error, I assume skel is able to handle printing it. Also I\u0027m not sure if json.Unmarshal is fine with the names in JSON from kuryr-daemon starting with lowercase, while properties of types.Error struct are starting from uppercase.","commit_id":"c3c8c536ca1e8081fd14b9482a72285316988527"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1de5af7d77a74bf52be7cde7bd87147585702d05","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\t\tif len(body) \u003e 1 {"},{"line_number":84,"context_line":"\t\t\tvar err types.Error"},{"line_number":85,"context_line":"\t\t\tjson.Unmarshal(body, \u0026err)"},{"line_number":86,"context_line":"\t\t\treturn []byte{}, errors.Errorf(\"CNI Daemon returned error %d; %s\", err.Code, err.Error())"},{"line_number":87,"context_line":"\t\t}"},{"line_number":88,"context_line":"\t\treturn []byte{}, errors.Errorf(\"CNI Daemon returned error %d %s\", resp.StatusCode, body)"},{"line_number":89,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":11,"id":"1f621f24_d05ff83e","line":86,"range":{"start_line":86,"start_character":3,"end_line":86,"end_character":92},"updated":"2020-11-03 12:51:58.000000000","message":"Looking at [1] and [2] we need to make sure what\u0027s returned is types.Error to make sure it\u0027ll print it correctly using the correct CNI code we returned. Otherwise we\u0027ll get generic 100 error.\n\nIt\u0027s probably best to change definitions of cmdAdd, cmdDel, makeDaemonRequest and transformData to return types.Error and always convert errors to it before returning.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/245eb078f40def87d37fb64a8101edf538200383/kuryr_cni/vendor/github.com/containernetworking/cni/pkg/skel/skel.go#L258-L264\n[2] https://github.com/openstack/kuryr-kubernetes/blob/245eb078f40def87d37fb64a8101edf538200383/kuryr_cni/vendor/github.com/containernetworking/cni/pkg/skel/skel.go#L164-L169","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1de5af7d77a74bf52be7cde7bd87147585702d05","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\t\tif len(body) \u003e 1 {"},{"line_number":84,"context_line":"\t\t\tvar err types.Error"},{"line_number":85,"context_line":"\t\t\tjson.Unmarshal(body, \u0026err)"},{"line_number":86,"context_line":"\t\t\treturn []byte{}, errors.Errorf(\"CNI Daemon returned error %d; %s\", err.Code, err.Error())"},{"line_number":87,"context_line":"\t\t}"},{"line_number":88,"context_line":"\t\treturn []byte{}, errors.Errorf(\"CNI Daemon returned error %d %s\", resp.StatusCode, body)"},{"line_number":89,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":12,"id":"1f621f24_b33b66c6","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":92},"updated":"2020-11-03 12:51:58.000000000","message":"Looking at [1] and [2] we need to make sure what\u0027s returned from cmdAdd and cmdDelete is types.Error to make sure it\u0027ll print it correctly using the correct CNI code we returned. Otherwise we\u0027ll get generic 100 error created at [2].\n\nIt\u0027s probably best to change definitions of cmdAdd, cmdDel, makeDaemonRequest and transformData to return types.Error and always convert errors to it before returning them.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/245eb078f40def87d37fb64a8101edf538200383/kuryr_cni/vendor/github.com/containernetworking/cni/pkg/skel/skel.go#L258-L264 [2] https://github.com/openstack/kuryr-kubernetes/blob/245eb078f40def87d37fb64a8101edf538200383/kuryr_cni/vendor/github.com/containernetworking/cni/pkg/skel/skel.go#L164-L169","commit_id":"58cc4299e50065fdc51b1fc3c072cb13a67983d6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"590dcb651e587a9100d5acf67152ff04d6185e39","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\t\tif len(body) \u003e 1 {"},{"line_number":84,"context_line":"\t\t\tvar err types.Error"},{"line_number":85,"context_line":"\t\t\tjson.Unmarshal(body, \u0026err)"},{"line_number":86,"context_line":"\t\t\treturn []byte{}, errors.Errorf(\"CNI Daemon returned error %d; %s\", err.Code, err.Error())"},{"line_number":87,"context_line":"\t\t}"},{"line_number":88,"context_line":"\t\treturn []byte{}, errors.Errorf(\"CNI Daemon returned error %d %s\", resp.StatusCode, body)"},{"line_number":89,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":12,"id":"1f621f24_f3b31e4c","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":92},"in_reply_to":"1f621f24_b33b66c6","updated":"2020-11-03 12:55:40.000000000","message":"Even better, it\u0027s supposed to be a types.Error pointer as the argument, so *types.Error. (and then you can return it as \u0026err).","commit_id":"58cc4299e50065fdc51b1fc3c072cb13a67983d6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"053358bd6e2e517bf53d69879e23fe298fbd6f72","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\t\tnewErr :\u003d types.Error{"},{"line_number":46,"context_line":"\t\t\tCode:    types.ErrDecodingFailure,"},{"line_number":47,"context_line":"\t\t\tMsg:     fmt.Sprintf(\"Error when reading configuration: %v\", err),"},{"line_number":48,"context_line":"\t\t\tDetails: \"\","},{"line_number":49,"context_line":"\t\t}"},{"line_number":50,"context_line":"\t\treturn KuryrDaemonData{}, \u0026newErr"},{"line_number":51,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":18,"id":"1f621f24_a37acaed","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":15},"updated":"2020-11-06 11:31:08.000000000","message":"You can probably omit that, but it\u0027s not a big deal.","commit_id":"508e078fb8e632bcc5f64ad117b7b22ac570fbc0"}],"kuryr_kubernetes/cni/daemon/service.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            self._check_failure()"},{"line_number":102,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":103,"context_line":"                error \u003d self._error(999, \"Maximum CNI ADD Failures Reached.\", \\"},{"line_number":104,"context_line":"                    \"Error when processing addNetwork request.\""},{"line_number":105,"context_line":"                    \"CNI Params: {}\".format(params))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_a5eb60ae","line":102,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E712 comparison to False should be \u0027if cond is False:\u0027 or \u0027if not cond:\u0027","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            self._check_failure()"},{"line_number":102,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":103,"context_line":"                error \u003d self._error(999, \"Maximum CNI ADD Failures Reached.\", \\"},{"line_number":104,"context_line":"                    \"Error when processing addNetwork request.\""},{"line_number":105,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":106,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_05d054f7","line":103,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E502 the backslash is redundant between brackets","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            self._check_failure()"},{"line_number":102,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":103,"context_line":"                error \u003d self._error(999, \"Maximum CNI ADD Failures Reached.\", \\"},{"line_number":104,"context_line":"                    \"Error when processing addNetwork request.\""},{"line_number":105,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":106,"context_line":"            else:"},{"line_number":107,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_e5cc3863","line":104,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":103,"context_line":"                error \u003d self._error(999, \"Maximum CNI ADD Failures Reached.\", \\"},{"line_number":104,"context_line":"                    \"Error when processing addNetwork request.\""},{"line_number":105,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":106,"context_line":"            else:"},{"line_number":107,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":108,"context_line":"                    \"Failure processing addNetwork request.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_45da4c17","line":105,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \"Error when processing addNetwork request.\""},{"line_number":105,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":106,"context_line":"            else:"},{"line_number":107,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":108,"context_line":"                    \"Failure processing addNetwork request.\""},{"line_number":109,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":110,"context_line":"            LOG.exception(\u0027Error when processing addNetwork request. CNI \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_25d750f0","line":107,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E502 the backslash is redundant between brackets","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":106,"context_line":"            else:"},{"line_number":107,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":108,"context_line":"                    \"Failure processing addNetwork request.\""},{"line_number":109,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":110,"context_line":"            LOG.exception(\u0027Error when processing addNetwork request. CNI \u0027"},{"line_number":111,"context_line":"                          \u0027Params: %s\u0027, params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_8505847d","line":108,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            else:"},{"line_number":107,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":108,"context_line":"                    \"Failure processing addNetwork request.\""},{"line_number":109,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":110,"context_line":"            LOG.exception(\u0027Error when processing addNetwork request. CNI \u0027"},{"line_number":111,"context_line":"                          \u0027Params: %s\u0027, params)"},{"line_number":112,"context_line":"            return error, httplib.INTERNAL_SERVER_ERROR, self.headers"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_650ae88a","line":109,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            return \u0027\u0027, httplib.NO_CONTENT, self.headers"},{"line_number":135,"context_line":"        except Exception:"},{"line_number":136,"context_line":"            self._check_failure()"},{"line_number":137,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":138,"context_line":"                error \u003d self._error(999, \"Maximum CNI DEL Failures Reached.\",\\"},{"line_number":139,"context_line":"                    \"Error when processing delNetwork request.\""},{"line_number":140,"context_line":"                    \"CNI Params: {}\".format(params))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_c5ff7c65","line":137,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E712 comparison to False should be \u0027if cond is False:\u0027 or \u0027if not cond:\u0027","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        except Exception:"},{"line_number":136,"context_line":"            self._check_failure()"},{"line_number":137,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":138,"context_line":"                error \u003d self._error(999, \"Maximum CNI DEL Failures Reached.\",\\"},{"line_number":139,"context_line":"                    \"Error when processing delNetwork request.\""},{"line_number":140,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":141,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_a504007d","line":138,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E502 the backslash is redundant between brackets","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            self._check_failure()"},{"line_number":137,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":138,"context_line":"                error \u003d self._error(999, \"Maximum CNI DEL Failures Reached.\",\\"},{"line_number":139,"context_line":"                    \"Error when processing delNetwork request.\""},{"line_number":140,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_05f9747f","line":139,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            if self.healthy.value \u003d\u003d False:"},{"line_number":138,"context_line":"                error \u003d self._error(999, \"Maximum CNI DEL Failures Reached.\",\\"},{"line_number":139,"context_line":"                    \"Error when processing delNetwork request.\""},{"line_number":140,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":143,"context_line":"                    \"Failure processing delNetwork request.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_e5f55885","line":140,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                    \"Error when processing delNetwork request.\""},{"line_number":140,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":143,"context_line":"                    \"Failure processing delNetwork request.\""},{"line_number":144,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":145,"context_line":"            LOG.exception(\u0027Error when processing delNetwork request. CNI \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_45f36c9f","line":142,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E502 the backslash is redundant between brackets","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":143,"context_line":"                    \"Failure processing delNetwork request.\""},{"line_number":144,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":145,"context_line":"            LOG.exception(\u0027Error when processing delNetwork request. CNI \u0027"},{"line_number":146,"context_line":"                          \u0027Params: %s.\u0027, params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_25f0f090","line":143,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"27752db8e58ac5ba75a292573b7aca4e620091fb","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            else:"},{"line_number":142,"context_line":"                error \u003d self._error(999, \"Error processing request\", \\"},{"line_number":143,"context_line":"                    \"Failure processing delNetwork request.\""},{"line_number":144,"context_line":"                    \"CNI Params: {}\".format(params))"},{"line_number":145,"context_line":"            LOG.exception(\u0027Error when processing delNetwork request. CNI \u0027"},{"line_number":146,"context_line":"                          \u0027Params: %s.\u0027, params)"},{"line_number":147,"context_line":"            return error, httplib.INTERNAL_SERVER_ERROR, self.headers"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_852aa4e4","line":144,"updated":"2020-10-29 01:04:32.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"58ae5aef223ea48fe090cee6c3e7cde4cbe61f95"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"24c0ee21b6ec61fe8ca153e455fb15d9acf06551","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def _error(self, error_code, message, details\u003d\"\"):"},{"line_number":74,"context_line":"        template \u003d {"},{"line_number":75,"context_line":"            \"cniVersion\": \"0.3.1\","},{"line_number":76,"context_line":"            \"code\": error_code,"},{"line_number":77,"context_line":"            \"msg\": message,"},{"line_number":78,"context_line":"            \"details\": details"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_7fef0d87","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":34},"updated":"2020-10-29 11:45:16.000000000","message":"No need to put that here, CNI version is returned by kuryr-cni (https://opendev.org/openstack/kuryr-kubernetes/src/branch/master/kuryr_cni/main.go).","commit_id":"b4727550da7b1c979dea887a9ffb38598be8281c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"bd5d0fe9879e13fbeace4fb87643e992f1e1c31c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        except Exception:"},{"line_number":87,"context_line":"            self._check_failure()"},{"line_number":88,"context_line":"            LOG.exception(\u0027Exception when reading CNI params.\u0027)"},{"line_number":89,"context_line":"            error \u003d self._error(4, \"Required CNI params missing.\")"},{"line_number":90,"context_line":"            return error, httplib.BAD_REQUEST, self.headers"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_b998a56a","line":89,"range":{"start_line":89,"start_character":32,"end_line":89,"end_character":33},"updated":"2020-10-29 10:11:16.000000000","message":"why number 4?\n\nIt would be nice to define these error codes as constants in this service file, or in here https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/constants.py","commit_id":"b4727550da7b1c979dea887a9ffb38598be8281c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"24c0ee21b6ec61fe8ca153e455fb15d9acf06551","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        except Exception:"},{"line_number":87,"context_line":"            self._check_failure()"},{"line_number":88,"context_line":"            LOG.exception(\u0027Exception when reading CNI params.\u0027)"},{"line_number":89,"context_line":"            error \u003d self._error(4, \"Required CNI params missing.\")"},{"line_number":90,"context_line":"            return error, httplib.BAD_REQUEST, self.headers"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_dfff4132","line":89,"range":{"start_line":89,"start_character":32,"end_line":89,"end_character":33},"in_reply_to":"1f621f24_b998a56a","updated":"2020-10-29 11:45:16.000000000","message":"Yeah, according to spec [1] we can\u0027t use 1-99 for custom codes, let\u0027s put something else here.\n\n[1] https://github.com/containernetworking/cni/blob/spec-v0.4.0/SPEC.md#well-known-error-codes","commit_id":"b4727550da7b1c979dea887a9ffb38598be8281c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"bd5d0fe9879e13fbeace4fb87643e992f1e1c31c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            vif \u003d self.plugin.add(params)"},{"line_number":94,"context_line":"            data \u003d jsonutils.dumps(vif.obj_to_primitive())"},{"line_number":95,"context_line":"        except exceptions.ResourceNotReady:"},{"line_number":96,"context_line":"            self._check_failure()"},{"line_number":97,"context_line":"            LOG.error(\u0027Error when processing addNetwork request\u0027)"},{"line_number":98,"context_line":"            error \u003d self._error(11, \"Resource Not Ready, Try Again Later.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_99396943","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":43},"updated":"2020-10-29 10:11:16.000000000","message":"we could also return error code 11 when this exception is raised https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/cni/binding/nested.py#L153-L154  as the interface might get cleaned up soon.","commit_id":"b4727550da7b1c979dea887a9ffb38598be8281c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"24c0ee21b6ec61fe8ca153e455fb15d9acf06551","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            vif \u003d self.plugin.add(params)"},{"line_number":94,"context_line":"            data \u003d jsonutils.dumps(vif.obj_to_primitive())"},{"line_number":95,"context_line":"        except exceptions.ResourceNotReady:"},{"line_number":96,"context_line":"            self._check_failure()"},{"line_number":97,"context_line":"            LOG.error(\u0027Error when processing addNetwork request\u0027)"},{"line_number":98,"context_line":"            error \u003d self._error(11, \"Resource Not Ready, Try Again Later.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_9fa30950","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":43},"in_reply_to":"1f621f24_99396943","updated":"2020-10-29 11:45:16.000000000","message":"Yup, let\u0027s catch it here and return 11 for it.","commit_id":"b4727550da7b1c979dea887a9ffb38598be8281c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"24c0ee21b6ec61fe8ca153e455fb15d9acf06551","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        except exceptions.ResourceNotReady:"},{"line_number":96,"context_line":"            self._check_failure()"},{"line_number":97,"context_line":"            LOG.error(\u0027Error when processing addNetwork request\u0027)"},{"line_number":98,"context_line":"            error \u003d self._error(11, \"Resource Not Ready, Try Again Later.\")"},{"line_number":99,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"},{"line_number":100,"context_line":"        except Exception:"},{"line_number":101,"context_line":"            self._check_failure()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_ff75ddcd","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":75},"updated":"2020-10-29 11:45:16.000000000","message":"It\u0027d great to be some more specific here. There are 3 places we raise ResourceNotReady in k8s_cni_registry.py, let\u0027s make sure we always add an error message explaining what timed out there.","commit_id":"b4727550da7b1c979dea887a9ffb38598be8281c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"24c0ee21b6ec61fe8ca153e455fb15d9acf06551","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            params \u003d self._prepare_request()"},{"line_number":119,"context_line":"        except Exception:"},{"line_number":120,"context_line":"            LOG.exception(\u0027Exception when reading CNI params.\u0027)"},{"line_number":121,"context_line":"            error \u003d self._error(4, \"Required CNI params missing.\")"},{"line_number":122,"context_line":"            return error, httplib.BAD_REQUEST, self.headers"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_ff5e7d43","line":121,"range":{"start_line":121,"start_character":32,"end_line":121,"end_character":33},"updated":"2020-10-29 11:45:16.000000000","message":"Again, we can\u0027t use 4.","commit_id":"b4727550da7b1c979dea887a9ffb38598be8281c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa145887f5433ace8fcf84df16ea749642731f38","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.error(\u0027NetlinkError\u0027)"},{"line_number":109,"context_line":"            args \u003d {\u0027kind\u0027: VLAN_KIND, \u0027vlan_id\u0027: vif.vlan_id}"},{"line_number":110,"context_line":"            error \u003d self._error(ErrTryAgainLater, \"Try Again Later\","},{"line_number":111,"context_line":"                                f\u0027Creation of pod interface failed due to VLAN ID \u0027"},{"line_number":112,"context_line":"                                f\u0027(vlan_info\u003d{args}) conflict. Probably the CRI had not \u0027"},{"line_number":113,"context_line":"                                f\u0027cleaned up the network namespace of deleted pods. \u0027"},{"line_number":114,"context_line":"                                f\u0027Attempting to find and delete offending interface and \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_3a6639ef","line":111,"updated":"2020-10-29 23:11:49.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"3034857e28dda1c338ce14ba10218a9ac9245b13"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa145887f5433ace8fcf84df16ea749642731f38","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            args \u003d {\u0027kind\u0027: VLAN_KIND, \u0027vlan_id\u0027: vif.vlan_id}"},{"line_number":110,"context_line":"            error \u003d self._error(ErrTryAgainLater, \"Try Again Later\","},{"line_number":111,"context_line":"                                f\u0027Creation of pod interface failed due to VLAN ID \u0027"},{"line_number":112,"context_line":"                                f\u0027(vlan_info\u003d{args}) conflict. Probably the CRI had not \u0027"},{"line_number":113,"context_line":"                                f\u0027cleaned up the network namespace of deleted pods. \u0027"},{"line_number":114,"context_line":"                                f\u0027Attempting to find and delete offending interface and \u0027"},{"line_number":115,"context_line":"                                f\u0027retry.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_9a630ddd","line":112,"updated":"2020-10-29 23:11:49.000000000","message":"pep8: E501 line too long (89 \u003e 79 characters)","commit_id":"3034857e28dda1c338ce14ba10218a9ac9245b13"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa145887f5433ace8fcf84df16ea749642731f38","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            error \u003d self._error(ErrTryAgainLater, \"Try Again Later\","},{"line_number":111,"context_line":"                                f\u0027Creation of pod interface failed due to VLAN ID \u0027"},{"line_number":112,"context_line":"                                f\u0027(vlan_info\u003d{args}) conflict. Probably the CRI had not \u0027"},{"line_number":113,"context_line":"                                f\u0027cleaned up the network namespace of deleted pods. \u0027"},{"line_number":114,"context_line":"                                f\u0027Attempting to find and delete offending interface and \u0027"},{"line_number":115,"context_line":"                                f\u0027retry.\u0027)"},{"line_number":116,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_7a60b1cf","line":113,"updated":"2020-10-29 23:11:49.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"3034857e28dda1c338ce14ba10218a9ac9245b13"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa145887f5433ace8fcf84df16ea749642731f38","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                f\u0027Creation of pod interface failed due to VLAN ID \u0027"},{"line_number":112,"context_line":"                                f\u0027(vlan_info\u003d{args}) conflict. Probably the CRI had not \u0027"},{"line_number":113,"context_line":"                                f\u0027cleaned up the network namespace of deleted pods. \u0027"},{"line_number":114,"context_line":"                                f\u0027Attempting to find and delete offending interface and \u0027"},{"line_number":115,"context_line":"                                f\u0027retry.\u0027)"},{"line_number":116,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"},{"line_number":117,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_da9aa5c3","line":114,"updated":"2020-10-29 23:11:49.000000000","message":"pep8: E501 line too long (89 \u003e 79 characters)","commit_id":"3034857e28dda1c338ce14ba10218a9ac9245b13"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa145887f5433ace8fcf84df16ea749642731f38","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        except Exception:"},{"line_number":118,"context_line":"            self._check_failure()"},{"line_number":119,"context_line":"            if not self.healthy.value:"},{"line_number":120,"context_line":"                error \u003d self._error(ErrInternal, \"Maximum CNI ADD Failures Reached.\","},{"line_number":121,"context_line":"                                    \"Error when processing addNetwork request.\""},{"line_number":122,"context_line":"                                    \"CNI Params: {}\".format(params))"},{"line_number":123,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_ba9fe9b2","line":120,"updated":"2020-10-29 23:11:49.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"3034857e28dda1c338ce14ba10218a9ac9245b13"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa145887f5433ace8fcf84df16ea749642731f38","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        except Exception:"},{"line_number":154,"context_line":"            self._check_failure()"},{"line_number":155,"context_line":"            if not self.healthy.value:"},{"line_number":156,"context_line":"                error \u003d self._error(ErrInternal, \"Maximum CNI DEL Failures Reached.\","},{"line_number":157,"context_line":"                                    \"Error when processing delNetwork request.\""},{"line_number":158,"context_line":"                                    \"CNI Params: {}\".format(params))"},{"line_number":159,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_1aa53d05","line":156,"updated":"2020-10-29 23:11:49.000000000","message":"pep8: E501 line too long (85 \u003e 79 characters)","commit_id":"3034857e28dda1c338ce14ba10218a9ac9245b13"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c012357e5fc483ef9fa81fbf6ed4672035c923c5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            self._check_failure()"},{"line_number":108,"context_line":"            LOG.error(\u0027NetlinkError\u0027)"},{"line_number":109,"context_line":"            error \u003d self._error(ErrTryAgainLater,"},{"line_number":110,"context_line":"                                \"Creation of pod interface failed due to vlan_id. Try Again Later\","},{"line_number":111,"context_line":"                                f\"vlan_id:{vif.vlan_id}\")"},{"line_number":112,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"},{"line_number":113,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_a6b8742a","line":110,"updated":"2020-10-30 07:36:06.000000000","message":"pep8: E501 line too long (99 \u003e 79 characters)","commit_id":"eecec269a214d7f155ddd966c055f124665a6257"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"7122da4e8d6b2e4867e2763c5993112c0c0be4be","unresolved":false,"context_lines":[{"line_number":49,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":50,"context_line":"CONF \u003d cfg.CONF"},{"line_number":51,"context_line":"HEALTH_CHECKER_DELAY \u003d 5"},{"line_number":52,"context_line":"VLAN_KIND \u003d \u0027vlan\u0027"},{"line_number":53,"context_line":"ErrInvalidEnvironmentVariables \u003d 4"},{"line_number":54,"context_line":"ErrTryAgainLater \u003d 11"},{"line_number":55,"context_line":"ErrInternal \u003d 999"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f621f24_7188d4c5","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":18},"updated":"2020-10-30 10:17:17.000000000","message":"I don\u0027t see this constant being used. Should it get removed?","commit_id":"878ac6804accc316a2204f701609215b9f7075ec"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"7122da4e8d6b2e4867e2763c5993112c0c0be4be","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            error \u003d self._error(ErrTryAgainLater,"},{"line_number":104,"context_line":"                                f\"{e}. Try Again Later.\")"},{"line_number":105,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"},{"line_number":106,"context_line":"        except pyroute2.NetlinkError:"},{"line_number":107,"context_line":"            self._check_failure()"},{"line_number":108,"context_line":"            LOG.error(\u0027NetlinkError\u0027)"},{"line_number":109,"context_line":"            error \u003d self._error(ErrTryAgainLater,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f621f24_912bf092","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":37},"updated":"2020-10-30 10:17:17.000000000","message":"could we also check if this specific error code was raised [1] and if not just raise again the exception?\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/9067b45a06aca07861a226f41cfb1b1b59934eed/kuryr_kubernetes/cni/binding/nested.py#L154","commit_id":"878ac6804accc316a2204f701609215b9f7075ec"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"7122da4e8d6b2e4867e2763c5993112c0c0be4be","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"},{"line_number":106,"context_line":"        except pyroute2.NetlinkError:"},{"line_number":107,"context_line":"            self._check_failure()"},{"line_number":108,"context_line":"            LOG.error(\u0027NetlinkError\u0027)"},{"line_number":109,"context_line":"            error \u003d self._error(ErrTryAgainLater,"},{"line_number":110,"context_line":"                                \"Creation of pod interface failed due to vlan\""},{"line_number":111,"context_line":"                                \"_id. Try Again Later\","}],"source_content_type":"text/x-python","patch_set":5,"id":"1f621f24_11efe084","line":108,"range":{"start_line":108,"start_character":12,"end_line":108,"end_character":37},"updated":"2020-10-30 10:17:17.000000000","message":"leftover?","commit_id":"878ac6804accc316a2204f701609215b9f7075ec"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d5961454c52b8c226768710865a202fee3e0bc87","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                f\"{e}. Try Again Later.\")"},{"line_number":105,"context_line":"            return error, httplib.GATEWAY_TIMEOUT, self.headers"},{"line_number":106,"context_line":"        except pyroute2.NetlinkError as e:"},{"line_number":107,"context_line":"            self._check_failure()"},{"line_number":108,"context_line":"            if e.code \u003d\u003d errno.EEXIST:"},{"line_number":109,"context_line":"                args \u003d {\u0027kind\u0027: \u0027vlan\u0027, \u0027vlan_id\u0027: vif.vlan_id}"},{"line_number":110,"context_line":"                LOG.warning("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_8ca9177d","line":107,"range":{"start_line":107,"start_character":12,"end_line":107,"end_character":33},"updated":"2020-10-30 11:01:07.000000000","message":"could you move this check to line 109? otherwise we might increase the failure count twice for the same issue. Here and at line 123.","commit_id":"2ad844cfd43e5fb1ebf27fa50dd570a91d77aeb3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"afb1ef9b70181fdafd34690398a50822c96a7f1f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import urllib.parse"},{"line_number":24,"context_line":"import urllib3"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import errno"},{"line_number":27,"context_line":"import cotyledon"},{"line_number":28,"context_line":"import flask"},{"line_number":29,"context_line":"import pyroute2"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_4c853fad","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":12},"updated":"2020-11-03 06:57:44.000000000","message":"errno origins from stdlib, so, according to PEP8[1], it should go to the first section of imports. We are trying to follow PEP8 rules :)\n\n[1] https://www.python.org/dev/peps/pep-0008/#id23","commit_id":"3e0dceab109ad5ffbc77c3cef9f4e70d2bfe3a29"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0d4aef62eb08473356c931ac88e964a8cc0613f7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import urllib3"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"import errno"},{"line_number":27,"context_line":"import cotyledon"},{"line_number":28,"context_line":"import flask"},{"line_number":29,"context_line":"import pyroute2"},{"line_number":30,"context_line":"from pyroute2.ipdb import transactional"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_63c2c935","line":27,"updated":"2020-10-30 13:53:01.000000000","message":"pep8: H306: imports not in alphabetical order (errno, cotyledon)","commit_id":"3e0dceab109ad5ffbc77c3cef9f4e70d2bfe3a29"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9b210f4059402f32925101aa56ba5b24a590ca49","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \"msg\": message,"},{"line_number":82,"context_line":"            \"details\": details"},{"line_number":83,"context_line":"        }"},{"line_number":84,"context_line":"        data \u003d jsonutils.dumps(template)"},{"line_number":85,"context_line":"        return data"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def add(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_e3189982","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":40},"updated":"2020-10-30 14:24:23.000000000","message":"This is not needed we should return dict to our web framework (Flask) and it\u0027ll encode it as JSON for us.","commit_id":"c3c8c536ca1e8081fd14b9482a72285316988527"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"c5d641150f39a1307e31137decce9a70dc066c98","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \"msg\": message,"},{"line_number":82,"context_line":"            \"details\": details"},{"line_number":83,"context_line":"        }"},{"line_number":84,"context_line":"        data \u003d jsonutils.dumps(template)"},{"line_number":85,"context_line":"        return data"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def add(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_fb7dc71c","line":84,"updated":"2020-11-02 12:59:38.000000000","message":"I left this line because when removed kuryr-kubernetes-tempest-containerized-lower-constraints failed with dict() object not callable.\nAlso, in L99, L138 we used jsonutils to dump the output of successful ADD request","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4349ce449f80c55f06c3798e5c27feeb9e1e2492","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            \"msg\": message,"},{"line_number":82,"context_line":"            \"details\": details"},{"line_number":83,"context_line":"        }"},{"line_number":84,"context_line":"        data \u003d jsonutils.dumps(template)"},{"line_number":85,"context_line":"        return data"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def add(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_70ea64ac","line":84,"in_reply_to":"1f621f24_fb7dc71c","updated":"2020-11-03 12:15:05.000000000","message":"Yep, makes sense, thanks.","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d6a56fcf17c4392ab8ee6089e0798fe90a92a808","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    f\u0027Creation of pod interface failed due to VLAN ID \u0027"},{"line_number":112,"context_line":"                    f\u0027(vlan_info\u003d{args}) conflict. Probably the CRI had not \u0027"},{"line_number":113,"context_line":"                    f\u0027cleaned up the network namespace of deleted pods. \u0027"},{"line_number":114,"context_line":"                    f\u0027Attempting to find and delete offending interface and \u0027"},{"line_number":115,"context_line":"                    f\u0027retry.\u0027)"},{"line_number":116,"context_line":"                error \u003d self._error(ErrTryAgainLater,"},{"line_number":117,"context_line":"                                    \"Creation of pod interface failed due to\""},{"line_number":118,"context_line":"                                    \" vlan_id. Try Again Later\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_aa5f7770","line":115,"range":{"start_line":114,"start_character":21,"end_line":115,"end_character":29},"updated":"2020-11-02 17:43:08.000000000","message":"This part of the LOG is misleading as it won\u0027t attempt to find and delete.","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d6a56fcf17c4392ab8ee6089e0798fe90a92a808","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            if not self.healthy.value:"},{"line_number":124,"context_line":"                error \u003d self._error(ErrInternal,"},{"line_number":125,"context_line":"                                    \"Maximum CNI ADD Failures Reached.\","},{"line_number":126,"context_line":"                                    \"Error when processing addNetwork request.\""},{"line_number":127,"context_line":"                                    \"CNI Params: {}\".format(params))"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                self._check_failure()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_cab8f377","line":126,"range":{"start_line":126,"start_character":77,"end_line":126,"end_character":79},"updated":"2020-11-02 17:43:08.000000000","message":"Could you add a space in the end of the String?","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d6a56fcf17c4392ab8ee6089e0798fe90a92a808","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                self._check_failure()"},{"line_number":130,"context_line":"                error \u003d self._error(ErrInternal,"},{"line_number":131,"context_line":"                                    \"Error processing request\","},{"line_number":132,"context_line":"                                    \"Failure processing addNetwork request.\""},{"line_number":133,"context_line":"                                    \"CNI Params: {}\".format(params))"},{"line_number":134,"context_line":"            LOG.exception(\u0027Error when processing addNetwork request. CNI \u0027"},{"line_number":135,"context_line":"                          \u0027Params: %s\u0027, params)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_aabbf76f","line":132,"range":{"start_line":132,"start_character":74,"end_line":132,"end_character":76},"updated":"2020-11-02 17:43:08.000000000","message":"ditto","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d6a56fcf17c4392ab8ee6089e0798fe90a92a808","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            if not self.healthy.value:"},{"line_number":162,"context_line":"                error \u003d self._error(ErrInternal,"},{"line_number":163,"context_line":"                                    \"Maximum CNI DEL Failures Reached.\","},{"line_number":164,"context_line":"                                    \"Error processing delNetwork request.\""},{"line_number":165,"context_line":"                                    \"CNI Params: {}\".format(params))"},{"line_number":166,"context_line":"            else:"},{"line_number":167,"context_line":"                self._check_failure()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_4aace333","line":164,"range":{"start_line":164,"start_character":72,"end_line":164,"end_character":74},"updated":"2020-11-02 17:43:08.000000000","message":"ditto","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d6a56fcf17c4392ab8ee6089e0798fe90a92a808","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                self._check_failure()"},{"line_number":168,"context_line":"                error \u003d self._error(ErrInternal,"},{"line_number":169,"context_line":"                                    \"Error processing request\","},{"line_number":170,"context_line":"                                    \"Failure processing delNetwork request.\""},{"line_number":171,"context_line":"                                    \"CNI Params: {}\".format(params))"},{"line_number":172,"context_line":"            LOG.exception(\u0027Error when processing delNetwork request. CNI \u0027"},{"line_number":173,"context_line":"                          \u0027Params: %s.\u0027, params)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_2aa7e751","line":170,"range":{"start_line":170,"start_character":73,"end_line":170,"end_character":76},"updated":"2020-11-02 17:43:08.000000000","message":"ditto","commit_id":"0217179dc59ca7072356494e751a53b5e186fe33"}]}