)]}'
{"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dbce589795daf8413a8e042aed79fb8872e07f45","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                    lb_sg \u003d vip_port.security_group_ids[0]"},{"line_number":232,"context_line":"                except IndexError:"},{"line_number":233,"context_line":"                    LOG.warning(\"We still waiting for SG to be created for \""},{"line_number":234,"context_line":"                                \"vip_port %s\", vip_port)"},{"line_number":235,"context_line":"                    raise k_exc.ResourceNotReady(listener_id)"},{"line_number":236,"context_line":"        else:"},{"line_number":237,"context_line":"            LOG.debug(\"Skipping sg update for lb %s\", loadbalancer[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_ce9fc24d","line":234,"range":{"start_line":234,"start_character":33,"end_line":234,"end_character":41},"updated":"2020-11-16 17:04:49.000000000","message":"I\u0027d just say VIP.","commit_id":"e43f1b2d012863140a8c2bf0919774689d3d1a5b"}],"kuryr_kubernetes/controller/handlers/kuryrport.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"95008d20b7289460d1e47ecb1fc6c8ac39d2abad","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            main_vif \u003d self._drv_vif_pool.request_vif(pod, project_id,"},{"line_number":230,"context_line":"                                                      subnets,"},{"line_number":231,"context_line":"                                                      security_groups)"},{"line_number":232,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":233,"context_line":"            LOG.warning(\"We don\u0027t have all the needed resources for creating \""},{"line_number":234,"context_line":"                        \"vif for the kuryrport %s. Let\u0027s retry.\","},{"line_number":235,"context_line":"                        kuryrport_crd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_0729cb99","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":39},"updated":"2020-11-12 08:15:52.000000000","message":"what is returning here resourceNotFound? I thought request_vif should only return resourceNotReady","commit_id":"bdf6bf77b993619c76c8be4dc96b5eac33268b33"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"1ab6780c4eaaf71126136c81ac78a73b0f9476dd","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            main_vif \u003d self._drv_vif_pool.request_vif(pod, project_id,"},{"line_number":230,"context_line":"                                                      subnets,"},{"line_number":231,"context_line":"                                                      security_groups)"},{"line_number":232,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":233,"context_line":"            LOG.warning(\"We don\u0027t have all the needed resources for creating \""},{"line_number":234,"context_line":"                        \"vif for the kuryrport %s. Let\u0027s retry.\","},{"line_number":235,"context_line":"                        kuryrport_crd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_14ba926c","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":39},"in_reply_to":"1f621f24_0729cb99","updated":"2020-11-12 13:22:13.000000000","message":"In neutron_vif driver there is a call to openstack, when we passing project_id, subnets and SG. I\u0027ve seen that sometimes, openstack returns complain about missing SG. So my thinking is, that we don\u0027t have it yet.","commit_id":"bdf6bf77b993619c76c8be4dc96b5eac33268b33"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"44fb71a835e8c1a38ea8d5a815ef239792d7d013","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            main_vif \u003d self._drv_vif_pool.request_vif(pod, project_id,"},{"line_number":230,"context_line":"                                                      subnets,"},{"line_number":231,"context_line":"                                                      security_groups)"},{"line_number":232,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":233,"context_line":"            LOG.warning(\"We don\u0027t have all the needed resources for creating \""},{"line_number":234,"context_line":"                        \"vif for the kuryrport %s. Let\u0027s retry.\","},{"line_number":235,"context_line":"                        kuryrport_crd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_7d063d22","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":39},"in_reply_to":"1f621f24_14ba926c","updated":"2020-11-13 08:02:05.000000000","message":"you mean the os_net_update_port (vif_pool.py) that updates the SG of a port to reuse it? Otherwise I don\u0027t see any other call being done from the vif_pool request_vif. The request vif function creates the port. Only reason for that resourceNotFound it could be the follow up call that adds the tag to the port.  And if that is the point, the right thing will be for the request_vif to either retry or try to delete the port. Otherwise that port is a leftover","commit_id":"bdf6bf77b993619c76c8be4dc96b5eac33268b33"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6f48233dedd654a02b7b4add5f16e80605697be5","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            main_vif \u003d self._drv_vif_pool.request_vif(pod, project_id,"},{"line_number":230,"context_line":"                                                      subnets,"},{"line_number":231,"context_line":"                                                      security_groups)"},{"line_number":232,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":233,"context_line":"            LOG.warning(\"We don\u0027t have all the needed resources for creating \""},{"line_number":234,"context_line":"                        \"vif for the kuryrport %s. Let\u0027s retry.\","},{"line_number":235,"context_line":"                        kuryrport_crd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_b871f1aa","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":39},"in_reply_to":"1f621f24_35496cb6","updated":"2020-11-16 07:59:59.000000000","message":"umm, right! perhaps there was a NP being applied to all the pods in the default namespace, and this test was running in parallel and creating pods on the default namespace. Then, at the same time the NP was deleted, the pod was being created. The NP deletion removed the SG and then, in the request_vif retry the SG is already gone and the port creating fails with resource not found.\n\nIf that is the case I would update the warning to say something about SG being deleted during pod creating, so retrying to get the right SG. Or at least a note about how/why a ResourceNotFound can happen in the port creation","commit_id":"bdf6bf77b993619c76c8be4dc96b5eac33268b33"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"d65f90fa17faa6a60da5128184a9b53780e92733","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            main_vif \u003d self._drv_vif_pool.request_vif(pod, project_id,"},{"line_number":230,"context_line":"                                                      subnets,"},{"line_number":231,"context_line":"                                                      security_groups)"},{"line_number":232,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":233,"context_line":"            LOG.warning(\"We don\u0027t have all the needed resources for creating \""},{"line_number":234,"context_line":"                        \"vif for the kuryrport %s. Let\u0027s retry.\","},{"line_number":235,"context_line":"                        kuryrport_crd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_35496cb6","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":39},"in_reply_to":"1f621f24_7d063d22","updated":"2020-11-16 07:25:34.000000000","message":"Hm.\n\nThe full traceback, which you can find on bug report tells, that we do vif_pool request_vif(), which than pass the call to the driver (in my case it\u0027s neutron_vif) and than neutron_vif request_vif is called, and there were an issue regarding non-existing security groups.\n\nMaybe the issue is different, than I first thought. Maybe there is a test run in parallel which creates network policy (so the SG) which applies on the pod, which we don\u0027t fully configure yet, and then that NP was removed, hence the error. WDYT?","commit_id":"bdf6bf77b993619c76c8be4dc96b5eac33268b33"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"5cc65ab2879b19e4f32c2b13291991b1a13ef5cd","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            main_vif \u003d self._drv_vif_pool.request_vif(pod, project_id,"},{"line_number":230,"context_line":"                                                      subnets,"},{"line_number":231,"context_line":"                                                      security_groups)"},{"line_number":232,"context_line":"        except os_exc.ResourceNotFound:"},{"line_number":233,"context_line":"            LOG.warning(\"We don\u0027t have all the needed resources for creating \""},{"line_number":234,"context_line":"                        \"vif for the kuryrport %s. Let\u0027s retry.\","},{"line_number":235,"context_line":"                        kuryrport_crd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f621f24_38ea01d7","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":39},"in_reply_to":"1f621f24_b871f1aa","updated":"2020-11-16 08:25:46.000000000","message":"Right! I\u0027ll update the warning and add the note.","commit_id":"bdf6bf77b993619c76c8be4dc96b5eac33268b33"}]}