)]}'
{"kuryr_kubernetes/controller/drivers/utils.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a5dbbf8948b1a18c410553f7bf08b8797d9d441f","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def is_pod_scheduled(pod):"},{"line_number":87,"context_line":"    try:"},{"line_number":88,"context_line":"        return bool(pod[\u0027spec\u0027][\u0027nodeName\u0027])"},{"line_number":89,"context_line":"    except KeyError:"},{"line_number":90,"context_line":"        return False"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_43a564a1","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":44},"updated":"2020-11-13 10:50:14.000000000","message":"is there an option to have the pod scheduled from k8s point of view but kuryr has not yet assigned an IP, thus making kuryrnetworkpolicy.py to fail? Perhaps we need to check it has IP instead?","commit_id":"dce5939c242d44417b74e00382fd0a08a8c34f7b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0a88cce58a83c4da0b653a85d2b90e26fb2e18fd","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def is_pod_scheduled(pod):"},{"line_number":87,"context_line":"    try:"},{"line_number":88,"context_line":"        return bool(pod[\u0027spec\u0027][\u0027nodeName\u0027])"},{"line_number":89,"context_line":"    except KeyError:"},{"line_number":90,"context_line":"        return False"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_b7a3ceb1","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":44},"in_reply_to":"1f621f24_43a564a1","updated":"2020-11-13 16:04:23.000000000","message":"There is such possibility for sure, but will it fail there? It previously was failing on lack of nodeName preventing pool driver to get vif type.","commit_id":"dce5939c242d44417b74e00382fd0a08a8c34f7b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c1bfb401370c0d4dbd495997edd4d1dba3a59e6a","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def is_pod_scheduled(pod):"},{"line_number":87,"context_line":"    try:"},{"line_number":88,"context_line":"        return bool(pod[\u0027spec\u0027][\u0027nodeName\u0027])"},{"line_number":89,"context_line":"    except KeyError:"},{"line_number":90,"context_line":"        return False"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_d70f6a85","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":44},"in_reply_to":"1f621f24_b7a3ceb1","updated":"2020-11-13 16:20:24.000000000","message":"Yup, seems like get_security_groups will be fine with pod without IPs, and update_vif_sgs has protection too [1].\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/a458fa68942ed13957cf1a443e2d2bbf287d0bda/kuryr_kubernetes/controller/drivers/neutron_vif.py#L96-L102","commit_id":"dce5939c242d44417b74e00382fd0a08a8c34f7b"}]}