)]}'
{"kuryr_kubernetes/controller/drivers/network_policy.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"0bfceace4917092c746cc6e6b6839bea807ade25","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        b[\u0027security_group_rule\u0027].pop(\u0027id\u0027, None)"},{"line_number":75,"context_line":"        return a \u003d\u003d b"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def update_security_group_rules_from_network_policy(self, policy):"},{"line_number":78,"context_line":"        \"\"\"Update security group rules"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        This method updates security group rules based on CRUD events gotten"}],"source_content_type":"text/x-python","patch_set":5,"id":"cd7c69ea_737df6bf","line":77,"updated":"2020-12-08 09:03:30.000000000","message":"This method doesn\u0027t have a unit test. Could you provide proper coverage?","commit_id":"6240ad74787b3c17b2c4d6a471f9fa817e661225"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"b83e683a20aa438e63d24ed995e12854a3b7e544","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        b[\u0027security_group_rule\u0027].pop(\u0027id\u0027, None)"},{"line_number":75,"context_line":"        return a \u003d\u003d b"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def update_security_group_rules_from_network_policy(self, policy):"},{"line_number":78,"context_line":"        \"\"\"Update security group rules"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        This method updates security group rules based on CRUD events gotten"}],"source_content_type":"text/x-python","patch_set":5,"id":"5e3feff8_b72c906d","line":77,"in_reply_to":"480074c7_ccdd2f8b","updated":"2020-12-08 09:54:58.000000000","message":"cool, thanks!","commit_id":"6240ad74787b3c17b2c4d6a471f9fa817e661225"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9baa3f06704df12ca2008b38361c7b98bd6d08e0","unresolved":true,"context_lines":[{"line_number":74,"context_line":"        b[\u0027security_group_rule\u0027].pop(\u0027id\u0027, None)"},{"line_number":75,"context_line":"        return a \u003d\u003d b"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def update_security_group_rules_from_network_policy(self, policy):"},{"line_number":78,"context_line":"        \"\"\"Update security group rules"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        This method updates security group rules based on CRUD events gotten"}],"source_content_type":"text/x-python","patch_set":5,"id":"480074c7_ccdd2f8b","line":77,"in_reply_to":"cd7c69ea_737df6bf","updated":"2020-12-08 09:43:21.000000000","message":"I changed the existing test to make sure an SG is deleted and added here and to validate that create_security_group_rule and delete_security_group_rule are correctly called.","commit_id":"6240ad74787b3c17b2c4d6a471f9fa817e661225"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1c8d418525eae77aa161787324de3dba8f9000d7","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                    if sg_rule \u003d\u003d e_rule:"},{"line_number":125,"context_line":"                        e_rule[\"security_group_rule\"][\"id\"] \u003d sgr_id"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        for sg_rule in sg_rules_to_delete:"},{"line_number":128,"context_line":"            driver_utils.delete_security_group_rule("},{"line_number":129,"context_line":"                sg_rule[\u0027security_group_rule\u0027][\u0027id\u0027])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        # Annotate kuryrnetpolicy CRD with current policy and ruleset"},{"line_number":132,"context_line":"        pod_selector \u003d policy[\u0027spec\u0027].get(\u0027podSelector\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7e9ee172_f861ae72","line":129,"range":{"start_line":127,"start_character":0,"end_line":129,"end_character":53},"updated":"2020-12-09 08:47:01.000000000","message":"perhaps add a note about why moving the delete after the add","commit_id":"a7535369375dcab092d933fc18bcd12c834d57a3"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5b1c74f310623e0d6ad70f12b2dee36a0abda995","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                    if sg_rule \u003d\u003d e_rule:"},{"line_number":125,"context_line":"                        e_rule[\"security_group_rule\"][\"id\"] \u003d sgr_id"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Only delete old rules after we created new ones to limit possibility"},{"line_number":128,"context_line":"        # of creating a breach."},{"line_number":129,"context_line":"        for sg_rule in sg_rules_to_delete:"},{"line_number":130,"context_line":"            driver_utils.delete_security_group_rule("},{"line_number":131,"context_line":"                sg_rule[\u0027security_group_rule\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"0b317a0e_8d312919","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":31},"updated":"2020-12-15 08:18:39.000000000","message":"shouldn\u0027t it be the other way around? with security groups everything is blocked unless specifically allowed. So it is safer to first remove and then add, right?","commit_id":"5bf8c3bbbfa6f6fd07c8a63d0bde736fa73aa579"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"45952fdb323019c5b74ddbfa12ae9de240ce673a","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                    if sg_rule \u003d\u003d e_rule:"},{"line_number":125,"context_line":"                        e_rule[\"security_group_rule\"][\"id\"] \u003d sgr_id"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Only delete old rules after we created new ones to limit possibility"},{"line_number":128,"context_line":"        # of creating a breach."},{"line_number":129,"context_line":"        for sg_rule in sg_rules_to_delete:"},{"line_number":130,"context_line":"            driver_utils.delete_security_group_rule("},{"line_number":131,"context_line":"                sg_rule[\u0027security_group_rule\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"c68aa4d7_49808a01","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":31},"in_reply_to":"0b317a0e_8d312919","updated":"2020-12-15 09:59:48.000000000","message":"Hm, right. It\u0027s not a trivial question really, but if we want to make sure we open as little as possible then you\u0027re right. I\u0027ll fix the comment.","commit_id":"5bf8c3bbbfa6f6fd07c8a63d0bde736fa73aa579"}],"kuryr_kubernetes/tests/unit/controller/drivers/test_network_policy.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"14763f6d1fe3ebbcba748cf200852bb78007a984","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                      \u0027port_range_min\u0027: 5978,"},{"line_number":125,"context_line":"                      \u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":126,"context_line":"                      \u0027security_group_id\u0027: self._sg_id,"},{"line_number":127,"context_line":"                      \u0027id\u0027: \u0027sgr-id-egress\u0027,"},{"line_number":128,"context_line":"                      }}],"},{"line_number":129,"context_line":"                \u0027ingressSgRules\u0027: ["},{"line_number":130,"context_line":"                    {\u0027security_group_rule\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"fb9e6dc2_539c6ce8","line":127,"range":{"start_line":127,"start_character":23,"end_line":127,"end_character":44},"updated":"2020-12-16 07:53:29.000000000","message":"ohh, nice finding! we completely missed this...","commit_id":"81e5350868744d50f0a52302210f6ce06a83c9b2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f0c70cefd019907d8db6109d3ec80009c0ff9e0","unresolved":true,"context_lines":[{"line_number":124,"context_line":"                      \u0027port_range_min\u0027: 5978,"},{"line_number":125,"context_line":"                      \u0027protocol\u0027: \u0027tcp\u0027,"},{"line_number":126,"context_line":"                      \u0027security_group_id\u0027: self._sg_id,"},{"line_number":127,"context_line":"                      \u0027id\u0027: \u0027sgr-id-egress\u0027,"},{"line_number":128,"context_line":"                      }}],"},{"line_number":129,"context_line":"                \u0027ingressSgRules\u0027: ["},{"line_number":130,"context_line":"                    {\u0027security_group_rule\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9584cd31_3f457ee9","line":127,"range":{"start_line":127,"start_character":23,"end_line":127,"end_character":44},"in_reply_to":"fb9e6dc2_539c6ce8","updated":"2020-12-16 09:00:32.000000000","message":"It\u0027s not a finding, just tests began to fail when I started to compare those. Sentinels should work just fine for that purpose but somehow not in 3.6.","commit_id":"81e5350868744d50f0a52302210f6ce06a83c9b2"}]}