)]}'
{"kuryr_kubernetes/tests/unit/test_utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6e00bd3b116744028d0180b01f16d73035480868","unresolved":true,"context_lines":[{"line_number":377,"context_line":"                     \u00274472fab1-f01c-46a7-b197-5cba4f2d7135\u0027))"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def test_get_res_link_core_res(self):"},{"line_number":380,"context_line":"        res \u003d {\u0027apiVersion\u0027: \u0027v1\u0027,"},{"line_number":381,"context_line":"               \u0027kind\u0027: \u0027Pod\u0027,"},{"line_number":382,"context_line":"               \u0027metadata\u0027: {\u0027name\u0027: \u0027pod-1\u0027,"},{"line_number":383,"context_line":"                            \u0027namespace\u0027: \u0027default\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7dfc0469_16fb6a77","line":380,"range":{"start_line":380,"start_character":30,"end_line":380,"end_character":32},"updated":"2020-12-23 10:40:27.000000000","message":"I\u0027d love to have a test with v1beta1 too.","commit_id":"e64f3e0890df2d40581e8520ca627c8a0e73a7ac"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"409d66bccff82bdc5a87d3ee19df44f1d78c79c6","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                     \u00274472fab1-f01c-46a7-b197-5cba4f2d7135\u0027))"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def test_get_res_link_core_res(self):"},{"line_number":380,"context_line":"        res \u003d {\u0027apiVersion\u0027: \u0027v1\u0027,"},{"line_number":381,"context_line":"               \u0027kind\u0027: \u0027Pod\u0027,"},{"line_number":382,"context_line":"               \u0027metadata\u0027: {\u0027name\u0027: \u0027pod-1\u0027,"},{"line_number":383,"context_line":"                            \u0027namespace\u0027: \u0027default\u0027}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"be9e75fa_16dc46f7","line":380,"range":{"start_line":380,"start_character":30,"end_line":380,"end_character":32},"in_reply_to":"7dfc0469_16fb6a77","updated":"2020-12-23 12:38:03.000000000","message":"Ack","commit_id":"e64f3e0890df2d40581e8520ca627c8a0e73a7ac"}],"kuryr_kubernetes/utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6e00bd3b116744028d0180b01f16d73035480868","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    namespace \u003d \u0027\u0027"},{"line_number":98,"context_line":"    if obj[\u0027metadata\u0027].get(\u0027namespace\u0027):"},{"line_number":99,"context_line":"        namespace \u003d f\"/namespaces/{obj[\u0027metadata\u0027][\u0027namespace\u0027]}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    api \u003d f\"/apis/{obj[\u0027apiVersion\u0027]}\""},{"line_number":102,"context_line":"    if API_RE.match(obj[\u0027apiVersion\u0027]):"},{"line_number":103,"context_line":"        api \u003d f\"/api/{obj[\u0027apiVersion\u0027]}\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    return f\"{api}{namespace}/{res_type}/{obj[\u0027metadata\u0027][\u0027name\u0027]}\""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"89969ebc_0b5d6397","line":103,"range":{"start_line":100,"start_character":0,"end_line":103,"end_character":41},"updated":"2020-12-23 10:40:27.000000000","message":"Ah right, I didn\u0027t liked it either, but yeah, that\u0027s probably the only way to figure out if it\u0027s \u0027api\u0027 or \u0027apis\u0027. I assume you\u0027ve taken into account names like \"v1beta\"?","commit_id":"e64f3e0890df2d40581e8520ca627c8a0e73a7ac"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"409d66bccff82bdc5a87d3ee19df44f1d78c79c6","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    namespace \u003d \u0027\u0027"},{"line_number":98,"context_line":"    if obj[\u0027metadata\u0027].get(\u0027namespace\u0027):"},{"line_number":99,"context_line":"        namespace \u003d f\"/namespaces/{obj[\u0027metadata\u0027][\u0027namespace\u0027]}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    api \u003d f\"/apis/{obj[\u0027apiVersion\u0027]}\""},{"line_number":102,"context_line":"    if API_RE.match(obj[\u0027apiVersion\u0027]):"},{"line_number":103,"context_line":"        api \u003d f\"/api/{obj[\u0027apiVersion\u0027]}\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    return f\"{api}{namespace}/{res_type}/{obj[\u0027metadata\u0027][\u0027name\u0027]}\""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"eb279c85_eafedc16","line":103,"range":{"start_line":100,"start_character":0,"end_line":103,"end_character":41},"in_reply_to":"89969ebc_0b5d6397","updated":"2020-12-23 12:38:03.000000000","message":"As far as I can find the information regarding beta releases, they are under \u0027something/v1beta2\u0027. I didn\u0027t found anything regarding beta versions for core APIs.","commit_id":"e64f3e0890df2d40581e8520ca627c8a0e73a7ac"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f56477e426a6574b1d42af02617bf39c02ff374d","unresolved":true,"context_lines":[{"line_number":97,"context_line":"    namespace \u003d \u0027\u0027"},{"line_number":98,"context_line":"    if obj[\u0027metadata\u0027].get(\u0027namespace\u0027):"},{"line_number":99,"context_line":"        namespace \u003d f\"/namespaces/{obj[\u0027metadata\u0027][\u0027namespace\u0027]}\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    api \u003d f\"/apis/{obj[\u0027apiVersion\u0027]}\""},{"line_number":102,"context_line":"    if API_RE.match(obj[\u0027apiVersion\u0027]):"},{"line_number":103,"context_line":"        api \u003d f\"/api/{obj[\u0027apiVersion\u0027]}\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    return f\"{api}{namespace}/{res_type}/{obj[\u0027metadata\u0027][\u0027name\u0027]}\""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"12766307_aeaa34b8","line":103,"range":{"start_line":100,"start_character":0,"end_line":103,"end_character":41},"in_reply_to":"eb279c85_eafedc16","updated":"2020-12-23 12:42:54.000000000","message":"True, seems like the core APIs are considered pretty stable.","commit_id":"e64f3e0890df2d40581e8520ca627c8a0e73a7ac"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"be12cb266a4116ed114b7ba4f68bea97d682dcd2","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_res_link(obj):"},{"line_number":90,"context_line":"    \"\"\"Return selfLink equivalent for provided resource\"\"\""},{"line_number":91,"context_line":"    # First try, if we still have it"},{"line_number":92,"context_line":"    try:"},{"line_number":93,"context_line":"        return obj[\u0027metadata\u0027][\u0027selfLink\u0027]"},{"line_number":94,"context_line":"    except KeyError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"337b2fe9_bfe480f3","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":36},"updated":"2021-01-07 10:23:10.000000000","message":"nice addition!! though it may \"hide\" problems as it will currently be there, right?","commit_id":"e3ff9547a6d54a04d3620128bcbfdd61033c0b12"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"8cbf1415db06f8000d18f0f0c4c1c6f3fad20e2f","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_res_link(obj):"},{"line_number":90,"context_line":"    \"\"\"Return selfLink equivalent for provided resource\"\"\""},{"line_number":91,"context_line":"    # First try, if we still have it"},{"line_number":92,"context_line":"    try:"},{"line_number":93,"context_line":"        return obj[\u0027metadata\u0027][\u0027selfLink\u0027]"},{"line_number":94,"context_line":"    except KeyError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a5c6c31e_a562a3dd","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":36},"in_reply_to":"337b2fe9_bfe480f3","updated":"2021-01-07 10:32:13.000000000","message":"I thought it might be a fast path in case we still do have selfLink in place, as for hide potential issues - well, I can\u0027t think of anything go wrong with this approach. If there k8s doesn\u0027t provide selfLink, it will simply not be there. Note, that in k8s_client, we don\u0027t provide \"fake\" selfLink to the response objects, but only kind/apiVersion.\n\nAlthough, if you think, we shouldn\u0027t be reach out for potential existing selfLink, I\u0027ll update the patch.","commit_id":"e3ff9547a6d54a04d3620128bcbfdd61033c0b12"}]}