)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"1ced50ca198e303cf132015574f85228877265b3","unresolved":true,"context_lines":[{"line_number":424,"context_line":"            --description \"k8s pod subnet allowed from k8s-pod-subnet\" \\"},{"line_number":425,"context_line":"            --remote-ip \"$pod_cidr\" --ethertype \"$KURYR_ETHERTYPE\" --protocol udp \\"},{"line_number":426,"context_line":"            \"$octavia_pod_access_sg_id\""},{"line_number":427,"context_line":"\t# Octavia supports SCTP load balancing, we need to also support SCTP traffic"},{"line_number":428,"context_line":"        openstack --os-cloud devstack-admin --os-region \"$REGION_NAME\" \\"},{"line_number":429,"context_line":"            security group rule create --project \"$project_id\" \\"},{"line_number":430,"context_line":"            --description \"k8s pod subnet allowed from k8s-pod-subnet\" \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"d2383292_16381253","line":427,"updated":"2020-12-23 17:30:17.000000000","message":"Space should be used instead of Tabs.","commit_id":"aa553c6ed98aac7b7d23bab301d592e96b685584"}],"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"439c88c435a3d66adb399ddb70964edd8440bf68","unresolved":true,"context_lines":[{"line_number":361,"context_line":"            result \u003d self._ensure_provisioned("},{"line_number":362,"context_line":"                loadbalancer, listener, self._create_listener,"},{"line_number":363,"context_line":"                self._find_listener, interval\u003d_LB_STS_POLL_SLOW_INTERVAL)"},{"line_number":364,"context_line":"        except os_exc.HttpException:"},{"line_number":365,"context_line":"            LOG.exception(\"Listener creation failed, most probably because \""},{"line_number":366,"context_line":"                          \"protocol %(prot)s is not supported\","},{"line_number":367,"context_line":"                          {\u0027prot\u0027: protocol})"},{"line_number":368,"context_line":"            return None"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        # NOTE(maysams): When ovn-octavia provider is used"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d251dee_cf6ea43b","line":367,"range":{"start_line":364,"start_character":0,"end_line":367,"end_character":45},"updated":"2020-12-24 22:01:31.000000000","message":"This exception or SDKException will never be handled here. As the _ensure_provisioned already handles it.","commit_id":"9778595371181611f9dcacc4ea600f552b05d737"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"439c88c435a3d66adb399ddb70964edd8440bf68","unresolved":true,"context_lines":[{"line_number":726,"context_line":"                    return result"},{"line_number":727,"context_line":"            except os_exc.BadRequestException:"},{"line_number":728,"context_line":"                raise"},{"line_number":729,"context_line":"            except os_exc.HttpException:"},{"line_number":730,"context_line":"                raise k_exc.ProviderUnsupportedOptionError(obj)"},{"line_number":731,"context_line":"                return"},{"line_number":732,"context_line":"            except os_exc.SDKException:"},{"line_number":733,"context_line":"                pass"},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c36ef45e_893aa56f","line":731,"range":{"start_line":729,"start_character":0,"end_line":731,"end_character":22},"updated":"2020-12-24 22:01:31.000000000","message":"Instead of re-raise the exception you could just add a log message and a return to ensure this operation is not retried. Also, make sure that only the following Octavia exception is handled: \"octavia.common.exceptions.ProviderUnsupportedOptionError\" you can see it being raised on the Octavia logs (sudo journalctl -u devstack@o-api.service)","commit_id":"9778595371181611f9dcacc4ea600f552b05d737"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"45daa4e24d73ff2d5edd3c423189022aa277cc53","unresolved":true,"context_lines":[{"line_number":370,"context_line":"                loadbalancer, listener, self._create_listener,"},{"line_number":371,"context_line":"                self._find_listener, interval\u003d_LB_STS_POLL_SLOW_INTERVAL)"},{"line_number":372,"context_line":"        except os_exc.SDKException:"},{"line_number":373,"context_line":"            LOG.exception(\"Listener creation failed, most probably because \""},{"line_number":374,"context_line":"                          \"protocol %(prot)s is not supported\","},{"line_number":375,"context_line":"                          {\u0027prot\u0027: protocol})"},{"line_number":376,"context_line":"            return None"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        # NOTE(maysams): When ovn-octavia provider is used"}],"source_content_type":"text/x-python","patch_set":4,"id":"f9b07fe6_0c932983","line":375,"range":{"start_line":373,"start_character":0,"end_line":375,"end_character":45},"updated":"2020-12-27 15:05:16.000000000","message":"This LOG message could be updated as the not implemented exception is already being handled before.","commit_id":"036a260683afaf75a6c5cd62fb58708ff6ef6dee"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"45daa4e24d73ff2d5edd3c423189022aa277cc53","unresolved":true,"context_lines":[{"line_number":734,"context_line":"                    return result"},{"line_number":735,"context_line":"            except os_exc.BadRequestException:"},{"line_number":736,"context_line":"                raise"},{"line_number":737,"context_line":"            except os_exc.HttpException:"},{"line_number":738,"context_line":"                LOG.exception(\"Listener creation failed, most probably because\""},{"line_number":739,"context_line":"                              \" protocol %(prot)s is not supported\","},{"line_number":740,"context_line":"                              {\u0027prot\u0027: obj[\u0027protocol\u0027]})"},{"line_number":741,"context_line":"                return None"},{"line_number":742,"context_line":"            except os_exc.SDKException:"},{"line_number":743,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae1743a6_848019fe","line":740,"range":{"start_line":737,"start_character":0,"end_line":740,"end_character":56},"updated":"2020-12-27 15:05:16.000000000","message":"The status of the exception should be checked to match 501(Not Implemented), if it doesn\u0027t match then it should be raised again to make sure other exceptions are properly handled.\n\nThis handling of this exception is needed just to ensure the lb resource creation is skipped if the octavia providers does not support the protocol, but the api does.","commit_id":"036a260683afaf75a6c5cd62fb58708ff6ef6dee"}],"kuryr_kubernetes/controller/handlers/loadbalancer.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b7793fa60ab4f0b982281881524ca4abfe601e40","unresolved":true,"context_lines":[{"line_number":591,"context_line":"                LOG.warning(\"Skipping listener creation for %s as another one\""},{"line_number":592,"context_line":"                            \" already exists with port %s\", name, port)"},{"line_number":593,"context_line":"                continue"},{"line_number":594,"context_line":"            if not self._drv_lbaas.sctp_supported():"},{"line_number":595,"context_line":"                LOG.warning(\"Skipping listener creation as provider does\""},{"line_number":596,"context_line":"                            \" not support %s protocol\", protocol)"},{"line_number":597,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"9b8e2c0c_9afc1eca","line":594,"range":{"start_line":594,"start_character":12,"end_line":594,"end_character":52},"updated":"2021-01-04 08:43:33.000000000","message":"you should only skip listener creation if listener protocol is sctp, right?","commit_id":"29adec9afd8515609aa58b7b5fd82a8bd7c56850"},{"author":{"_account_id":32533,"name":"Tabitha Fasoyin","email":"fifedolapo02@gmail.com","username":"tabbie-fash"},"change_message_id":"e0586f101eb44bf068e6e69cbf17feda1287876d","unresolved":true,"context_lines":[{"line_number":591,"context_line":"                LOG.warning(\"Skipping listener creation for %s as another one\""},{"line_number":592,"context_line":"                            \" already exists with port %s\", name, port)"},{"line_number":593,"context_line":"                continue"},{"line_number":594,"context_line":"            if not self._drv_lbaas.sctp_supported():"},{"line_number":595,"context_line":"                LOG.warning(\"Skipping listener creation as provider does\""},{"line_number":596,"context_line":"                            \" not support %s protocol\", protocol)"},{"line_number":597,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"5107dbeb_a1ac5af0","line":594,"range":{"start_line":594,"start_character":12,"end_line":594,"end_character":52},"in_reply_to":"9b8e2c0c_9afc1eca","updated":"2021-01-04 10:42:12.000000000","message":"Right, thank you.","commit_id":"29adec9afd8515609aa58b7b5fd82a8bd7c56850"}]}