)]}'
{"kuryr_kubernetes/k8s_client.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dc129a34f0b8b5fc800e0f5df7158c3b37f29dce","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            # equivalent, we need to have both: kind and apiVersion, while the"},{"line_number":132,"context_line":"            # latter is not present on items list for core resources, while"},{"line_number":133,"context_line":"            # for custom resources there are both kind and apiVersion.."},{"line_number":134,"context_line":"            if kind.endswith(\u0027List\u0027) and result[\u0027items\u0027]:"},{"line_number":135,"context_line":"                kind \u003d kind[:-4]"},{"line_number":136,"context_line":"                for item in result[\u0027items\u0027]:"},{"line_number":137,"context_line":"                    if not item.get(\u0027kind\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3dffa494_d0b527b1","line":134,"range":{"start_line":134,"start_character":41,"end_line":134,"end_character":56},"updated":"2021-01-08 14:54:38.000000000","message":"It\u0027s really weird that `.items` element of *List might be null, according to K8s API reference it\u0027s always supposed to be an array. If we won\u0027t understand why this happens, it deserves a comment.","commit_id":"f89b98d2996b38cfa08876475d97681d8c6606f3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f64f78769a9056276dd89f1441469d2ffb13fa4d","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            # equivalent, we need to have both: kind and apiVersion, while the"},{"line_number":132,"context_line":"            # latter is not present on items list for core resources, while"},{"line_number":133,"context_line":"            # for custom resources there are both kind and apiVersion.."},{"line_number":134,"context_line":"            if kind.endswith(\u0027List\u0027) and result[\u0027items\u0027]:"},{"line_number":135,"context_line":"                kind \u003d kind[:-4]"},{"line_number":136,"context_line":"                for item in result[\u0027items\u0027]:"},{"line_number":137,"context_line":"                    if not item.get(\u0027kind\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"36408432_24fafc53","line":134,"range":{"start_line":134,"start_character":41,"end_line":134,"end_character":56},"in_reply_to":"3dffa494_d0b527b1","updated":"2021-01-08 16:44:19.000000000","message":"For some reason I could get:\n\n    {\u0027kind\u0027: \u0027PodList\u0027, \u0027apiVersion\u0027: \u0027v1\u0027, \u0027metadata\u0027: {\u0027resourceVersion\u0027: \u0027266\u0027}, \u0027items\u0027: None}\n\ninstead of:\n\n    {\u0027kind\u0027: \u0027PodList\u0027, \u0027apiVersion\u0027: \u0027v1\u0027, \u0027metadata\u0027: {\u0027resourceVersion\u0027: \u0027266\u0027}, \u0027items\u0027: []}\n\nfor the request k8s_client.get(\u0027/api/v1/pods\u0027), on environment, where there are exactly 0 pods, event though documentation states it should be list. Same result I get using curl, so it\u0027s 100% k8s thing, not kuryr.\n\nThis is the reason why we can observe kuryr-kuberetest-tempest gate failing occasionally at the top patches in this very chain.","commit_id":"f89b98d2996b38cfa08876475d97681d8c6606f3"}],"kuryr_kubernetes/watcher.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"9776f58b0bf87f8ac9e9cc65ec200832ea7ed69c","unresolved":true,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # NOTE(gryf): For some resources (like pods) we could observe that"},{"line_number":147,"context_line":"        # \u0027items\u0027 is set to None. I\u0027m not sure if that\u0027s a K8s issue, since"},{"line_number":148,"context_line":"        # accroding to the documentation is should be list."},{"line_number":149,"context_line":"        if not resources:"},{"line_number":150,"context_line":"            return"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7da298a7_20e8751a","line":148,"range":{"start_line":148,"start_character":10,"end_line":148,"end_character":19},"updated":"2021-01-12 01:43:57.000000000","message":"typo","commit_id":"9bc33d9b786c1be7afb2d07f6cf066edcbda3549"}]}