)]}'
{"kuryr_kubernetes/controller/drivers/network_policy.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"e3d9a0e0019fda9e2990bbf322be1240b3c47375","unresolved":true,"context_lines":[{"line_number":555,"context_line":"                            resource\u003dresource)"},{"line_number":556,"context_line":"                if allowed_cidrs:"},{"line_number":557,"context_line":"                    for cidr in allowed_cidrs:"},{"line_number":558,"context_line":"                        rule \u003d _create_sg_rule_body(direction, cidr\u003dcidr)"},{"line_number":559,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":560,"context_line":"            else:"},{"line_number":561,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"71b1dda6_3c953439","line":558,"updated":"2021-02-11 11:22:29.000000000","message":"Note, that I didn\u0027t provided the range for ports to be opened, relying on previous implementation of drivers_utils.create_security_group_rule_body.","commit_id":"35783a51fa4505aaaf20e290871711a5368fecfc"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"12a5d580b80b236b295e85844800ce5929525d74","unresolved":false,"context_lines":[{"line_number":555,"context_line":"                            resource\u003dresource)"},{"line_number":556,"context_line":"                if allowed_cidrs:"},{"line_number":557,"context_line":"                    for cidr in allowed_cidrs:"},{"line_number":558,"context_line":"                        rule \u003d _create_sg_rule_body(direction, cidr\u003dcidr)"},{"line_number":559,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":560,"context_line":"            else:"},{"line_number":561,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aa50fff_c0f72eb0","line":558,"in_reply_to":"56859f49_ec581b24","updated":"2021-02-11 13:41:10.000000000","message":"Ack","commit_id":"35783a51fa4505aaaf20e290871711a5368fecfc"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a79d7d39e08e15edc9b6d66d9795bbcfb2c8834b","unresolved":true,"context_lines":[{"line_number":555,"context_line":"                            resource\u003dresource)"},{"line_number":556,"context_line":"                if allowed_cidrs:"},{"line_number":557,"context_line":"                    for cidr in allowed_cidrs:"},{"line_number":558,"context_line":"                        rule \u003d _create_sg_rule_body(direction, cidr\u003dcidr)"},{"line_number":559,"context_line":"                        sg_rule_body_list.append(rule)"},{"line_number":560,"context_line":"            else:"},{"line_number":561,"context_line":"                LOG.debug(\u0027This network policy specifies no %(direction)s \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"56859f49_ec581b24","line":558,"in_reply_to":"71b1dda6_3c953439","updated":"2021-02-11 12:39:18.000000000","message":"No range provided for SG rule \u003d\u003d whole range (but compatible with `any`/`null` protocol)","commit_id":"35783a51fa4505aaaf20e290871711a5368fecfc"}],"kuryr_kubernetes/controller/drivers/utils.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"e3d9a0e0019fda9e2990bbf322be1240b3c47375","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        description\u003d\"Kuryr-Kubernetes NetPolicy SG rule\", namespace\u003dNone,"},{"line_number":263,"context_line":"        pods\u003dNone):"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if port_range_min and not port_range_max:"},{"line_number":266,"context_line":"        port_range_max \u003d port_range_min"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    if cidr and netaddr.IPNetwork(cidr).version \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5997af06_2ddda262","line":265,"range":{"start_line":265,"start_character":4,"end_line":265,"end_character":45},"updated":"2021-02-11 11:22:29.000000000","message":"Wait, we still need to set the range in case we don\u0027t provide any, so there is an assumption, that if no range is provided, we are opening whole range.","commit_id":"35783a51fa4505aaaf20e290871711a5368fecfc"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a79d7d39e08e15edc9b6d66d9795bbcfb2c8834b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        description\u003d\"Kuryr-Kubernetes NetPolicy SG rule\", namespace\u003dNone,"},{"line_number":263,"context_line":"        pods\u003dNone):"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if port_range_min and not port_range_max:"},{"line_number":266,"context_line":"        port_range_max \u003d port_range_min"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    if cidr and netaddr.IPNetwork(cidr).version \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":4,"id":"c5936ada_d8ea41f6","line":265,"range":{"start_line":265,"start_character":4,"end_line":265,"end_character":45},"in_reply_to":"5997af06_2ddda262","updated":"2021-02-11 12:39:18.000000000","message":"When we don\u0027t supply range to an SG rule it will open all the ports.","commit_id":"35783a51fa4505aaaf20e290871711a5368fecfc"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"12a5d580b80b236b295e85844800ce5929525d74","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        description\u003d\"Kuryr-Kubernetes NetPolicy SG rule\", namespace\u003dNone,"},{"line_number":263,"context_line":"        pods\u003dNone):"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if port_range_min and not port_range_max:"},{"line_number":266,"context_line":"        port_range_max \u003d port_range_min"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    if cidr and netaddr.IPNetwork(cidr).version \u003d\u003d 6:"}],"source_content_type":"text/x-python","patch_set":4,"id":"24eec7da_27787098","line":265,"range":{"start_line":265,"start_character":4,"end_line":265,"end_character":45},"in_reply_to":"c5936ada_d8ea41f6","updated":"2021-02-11 13:41:10.000000000","message":"Oh, okay, I thought that we should provide the whole range when we wanted to fully open.","commit_id":"35783a51fa4505aaaf20e290871711a5368fecfc"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ea3204c7c9c1a609647d2d636b608c59c2ae9f2c","unresolved":true,"context_lines":[{"line_number":275,"context_line":"            \u0027direction\u0027: direction,"},{"line_number":276,"context_line":"        }"},{"line_number":277,"context_line":"    }"},{"line_number":278,"context_line":"    if port_range_min and port_range_max:"},{"line_number":279,"context_line":"        security_group_rule_body[\u0027sgRule\u0027][\u0027port_range_min\u0027] \u003d port_range_min"},{"line_number":280,"context_line":"        security_group_rule_body[\u0027sgRule\u0027][\u0027port_range_max\u0027] \u003d port_range_max"},{"line_number":281,"context_line":"    if protocol:"}],"source_content_type":"text/x-python","patch_set":5,"id":"83033428_ffb1ac3a","line":278,"range":{"start_line":278,"start_character":22,"end_line":278,"end_character":40},"updated":"2021-02-17 09:04:28.000000000","message":"this is redundant, only \"if port_range_min\" is needed as you are ensuring that if there is port_range_min, port_range_max is either defined or assigned the port_range_min value at line 265/266","commit_id":"10ea8698586bd172a3d4b0215f6774102348ac69"}]}