)]}'
{"kuryr_kubernetes/controller/drivers/vif_pool.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9890cb1eda13c9eb00f3757775d03590caea4ba0","unresolved":true,"context_lines":[{"line_number":438,"context_line":"                                    port.network_id)}"},{"line_number":439,"context_line":"                        else:"},{"line_number":440,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":441,"context_line":"                                subnet_id: utils.get_subnet(subnet_id)}"},{"line_number":442,"context_line":"        return parent_ports, subports, subnets"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _cleanup_leftover_ports(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"81571e27_26f45a9a","line":441,"updated":"2021-02-10 07:57:27.000000000","message":"don\u0027t you need to get the subnet id from here?","commit_id":"489598ab066b809b59c63867aa9e6cc2edb0a131"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d9744d13e8e4fb6b88e1be15e34c1984733b719d","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                    # per subnet in use"},{"line_number":429,"context_line":"                    subnet_id \u003d port.fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":430,"context_line":"                    if not subnets.get(subnet_id):"},{"line_number":431,"context_line":"                        # NOTE(maysams): Avoid calling Neutron by"},{"line_number":432,"context_line":"                        # getting the Network and Subnet info from"},{"line_number":433,"context_line":"                        # Network defined on an existing KuryrPort CR."},{"line_number":434,"context_line":"                        # This assumes only one Subnet exists per Network."},{"line_number":435,"context_line":"                        if in_use_networks.get(port.network_id):"},{"line_number":436,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":437,"context_line":"                                subnet_id: in_use_networks.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"d68e3079_af1cd016","line":434,"range":{"start_line":431,"start_character":0,"end_line":434,"end_character":74},"updated":"2021-02-11 13:21:29.000000000","message":"The assumption will be fine at least until we introduce dual stack. I believe VIF info never lists all the subnets in the network but only the subnets the port got created in, and at the moment we never create it in multiple subnets.","commit_id":"e54532421232f5b6e49f225b05617f89e3006957"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3c83a35a2186f99d4e5295b61dd436a7b27633b6","unresolved":true,"context_lines":[{"line_number":428,"context_line":"                    # per subnet in use"},{"line_number":429,"context_line":"                    subnet_id \u003d port.fixed_ips[0][\u0027subnet_id\u0027]"},{"line_number":430,"context_line":"                    if not subnets.get(subnet_id):"},{"line_number":431,"context_line":"                        # NOTE(maysams): Avoid calling Neutron by"},{"line_number":432,"context_line":"                        # getting the Network and Subnet info from"},{"line_number":433,"context_line":"                        # Network defined on an existing KuryrPort CR."},{"line_number":434,"context_line":"                        # This assumes only one Subnet exists per Network."},{"line_number":435,"context_line":"                        if in_use_networks.get(port.network_id):"},{"line_number":436,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":437,"context_line":"                                subnet_id: in_use_networks.get("}],"source_content_type":"text/x-python","patch_set":5,"id":"59286a58_bc36b64c","line":434,"range":{"start_line":431,"start_character":0,"end_line":434,"end_character":74},"in_reply_to":"d68e3079_af1cd016","updated":"2021-02-11 13:45:49.000000000","message":"Yup and if I checked correctly the SubnetList inside the Network isn\u0027t really used anywhere, so I believe it\u0027s safe.","commit_id":"e54532421232f5b6e49f225b05617f89e3006957"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"59c12ce94e790f94eed6ce44786ee8f620cf0f52","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                        # getting the Network and Subnet info from"},{"line_number":433,"context_line":"                        # Network defined on an existing KuryrPort CR."},{"line_number":434,"context_line":"                        # This assumes only one Subnet exists per Network."},{"line_number":435,"context_line":"                        if in_use_networks.get(port.network_id):"},{"line_number":436,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":437,"context_line":"                                subnet_id: in_use_networks.get("},{"line_number":438,"context_line":"                                    port.network_id)}"},{"line_number":439,"context_line":"                        else:"},{"line_number":440,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":441,"context_line":"                                subnet_id: utils.get_subnet(subnet_id)}"},{"line_number":442,"context_line":"        return parent_ports, subports, subnets"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _cleanup_leftover_ports(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"b63d2251_8bc5cd88","line":441,"range":{"start_line":435,"start_character":0,"end_line":441,"end_character":71},"updated":"2021-02-11 12:56:38.000000000","message":"Wait, I don\u0027t get it. In `_get_in_use_ports_info()` the info of network is saved and I believe we expect subnet here?","commit_id":"e54532421232f5b6e49f225b05617f89e3006957"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"44efdd67ba040a72c911bc62252ddc549170414c","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                        # getting the Network and Subnet info from"},{"line_number":433,"context_line":"                        # Network defined on an existing KuryrPort CR."},{"line_number":434,"context_line":"                        # This assumes only one Subnet exists per Network."},{"line_number":435,"context_line":"                        if in_use_networks.get(port.network_id):"},{"line_number":436,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":437,"context_line":"                                subnet_id: in_use_networks.get("},{"line_number":438,"context_line":"                                    port.network_id)}"},{"line_number":439,"context_line":"                        else:"},{"line_number":440,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":441,"context_line":"                                subnet_id: utils.get_subnet(subnet_id)}"},{"line_number":442,"context_line":"        return parent_ports, subports, subnets"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _cleanup_leftover_ports(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ef86007d_6b8c60c5","line":441,"range":{"start_line":435,"start_character":0,"end_line":441,"end_character":71},"in_reply_to":"b63d2251_8bc5cd88","updated":"2021-02-11 13:10:35.000000000","message":"The get_subnet method returns the Network object[1](the name is a bit misleading), which contains a list of Subnet. At line 437 I tried getting the Network plus Subnet info from an existent Custom Resource.\n\n[1]https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/utils.py#L289","commit_id":"e54532421232f5b6e49f225b05617f89e3006957"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d9744d13e8e4fb6b88e1be15e34c1984733b719d","unresolved":true,"context_lines":[{"line_number":432,"context_line":"                        # getting the Network and Subnet info from"},{"line_number":433,"context_line":"                        # Network defined on an existing KuryrPort CR."},{"line_number":434,"context_line":"                        # This assumes only one Subnet exists per Network."},{"line_number":435,"context_line":"                        if in_use_networks.get(port.network_id):"},{"line_number":436,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":437,"context_line":"                                subnet_id: in_use_networks.get("},{"line_number":438,"context_line":"                                    port.network_id)}"},{"line_number":439,"context_line":"                        else:"},{"line_number":440,"context_line":"                            subnets[subnet_id] \u003d {"},{"line_number":441,"context_line":"                                subnet_id: utils.get_subnet(subnet_id)}"},{"line_number":442,"context_line":"        return parent_ports, subports, subnets"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    def _cleanup_leftover_ports(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3eac953f_024317f4","line":441,"range":{"start_line":435,"start_character":0,"end_line":441,"end_character":71},"in_reply_to":"ef86007d_6b8c60c5","updated":"2021-02-11 13:21:29.000000000","message":"Ah, I see now!","commit_id":"e54532421232f5b6e49f225b05617f89e3006957"}]}