)]}'
{"kuryr_kubernetes/controller/drivers/default_subnet.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e1d9d0f194f50e17e3a620c7f82b09d8f2c65f5f","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            ip_version \u003d netaddr.IPAddress(cluster_ip).version"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        # This is 1.20+ with IPv6DualStack feature gate enabled."},{"line_number":70,"context_line":"        ip_family_policy \u003d service[\u0027spec\u0027].get(\u0027ipFamilyPolicy\u0027, \u0027SingleStack\u0027)"},{"line_number":71,"context_line":"        if ip_family_policy \u003d\u003d \u0027RequireDualStack\u0027:"},{"line_number":72,"context_line":"            raise NotImplementedError("},{"line_number":73,"context_line":"                \u0027Kuryr does not support RequireDualStack set for \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"06af105e_ef74d54a","line":70,"updated":"2021-04-08 06:55:29.000000000","message":"perhaps worth to add a fixme/removeme for when this is supported","commit_id":"2a6fda9cc4f5d0cbe137e597f922faba02696ba7"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"27fd6651d6a8c979e3e4f2207de5d499d924f24d","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        for subnet_id in subnets_ids:"},{"line_number":81,"context_line":"            if (not ip_version or"},{"line_number":82,"context_line":"                    ip_version \u003d\u003d utils.get_subnet_ip_version(subnet_id)):"},{"line_number":83,"context_line":"                return {subnet_id: utils.get_os_vif_network(subnet_id)}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        raise k_exc.InvalidKuryrConfig("},{"line_number":86,"context_line":"            \u0027[neutron_defaults]service_subnets does not list IPv%d subnet \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d045140_7db4afa5","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":71},"updated":"2021-04-07 23:03:50.000000000","message":"Does this mean that we only support \"ipFamilyPolicy: SingleStack\"?","commit_id":"2a6fda9cc4f5d0cbe137e597f922faba02696ba7"}],"kuryr_kubernetes/utils.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"aac375b22ee63950baab3809c7c8307302550dc1","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":"@MEMOIZE"},{"line_number":308,"context_line":"def get_subnet_ip_version(subnet_id):"},{"line_number":309,"context_line":"    return _get_subnet(subnet_id).ip_version"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"def get_subnet_id(**filters):"}],"source_content_type":"text/x-python","patch_set":3,"id":"39fd5643_1bde00ba","line":309,"updated":"2021-03-29 09:57:37.000000000","message":"nit: For those two functions, caching return values have no point, I guess. Main reason for caching was costly API requests, and I believe, responses are already cached within _get_subnet function.","commit_id":"2a6fda9cc4f5d0cbe137e597f922faba02696ba7"}]}