)]}'
{"cni.Dockerfile":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b78730c69137bc4c7935005dc05ee694dff0dfa6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM quay.io/kuryr/golang:1.16 as builder"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"WORKDIR /go/src/opendev.com/kuryr-kubernetes"},{"line_number":4,"context_line":"COPY . ."}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"ee916ad0_351f92ab","line":1,"range":{"start_line":1,"start_character":5,"end_line":1,"end_character":30},"updated":"2021-05-03 11:12:31.000000000","message":"This image needs to be published on the kuryr repository in quay.io first. It should be available tomorrow","commit_id":"d37bbc8cf39d9c3894905f271fa9b1e635e73b03"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b78730c69137bc4c7935005dc05ee694dff0dfa6","unresolved":true,"context_lines":[{"line_number":3,"context_line":"WORKDIR /go/src/opendev.com/kuryr-kubernetes"},{"line_number":4,"context_line":"COPY . ."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN GO111MODULE\u003dauto go build -o /go/bin/kuryr-cni ./kuryr_cni/pkg/*"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"FROM registry.centos.org/centos:8"},{"line_number":9,"context_line":"LABEL authors\u003d\"Antoni Segura Puimedon\u003ctoni@kuryr.org\u003e, Michał Dulko\u003cmdulko@redhat.com\u003e\""}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"ee086cfe_63717ac1","line":6,"updated":"2021-05-03 11:12:31.000000000","message":"the \"GO111MODULE\u003dauto\" can be removed as go 1.16 enables use on go modules by default.\n\nBTW, to test if the image is being build properly you can run:\n$cd kuryr-kubernetes\n$ docker build -t kuryr/cni -f cni.Dockerfile .\n\nAlso, to test it out on your local PC you can use \"amd64/golang:1.16\" until quay.io/kuryr/golang:1.16 becomes available.","commit_id":"d37bbc8cf39d9c3894905f271fa9b1e635e73b03"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e880b34729bb6c4a3e1d6004af26e85d64be496d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"WORKDIR /go/src/opendev.com/kuryr-kubernetes"},{"line_number":4,"context_line":"COPY . ."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN GO111MODULE\u003dauto go build -o /go/bin/kuryr-cni ./kuryr_cni/pkg/*"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"FROM registry.centos.org/centos:8"},{"line_number":9,"context_line":"LABEL authors\u003d\"Antoni Segura Puimedon\u003ctoni@kuryr.org\u003e, Michał Dulko\u003cmdulko@redhat.com\u003e\""}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"91b1d871_149034c8","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":68},"updated":"2021-05-07 11:54:33.000000000","message":"Looks like you need to retain `GO111MODULE\u003dauto` because not every dependency we used is updated to use go modules. :/","commit_id":"da0ab7211a64023938d279c11e9cf5deb54b7056"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"13bb5e03d55a2c16cc1895ed41965469101f529c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"WORKDIR /go/src/opendev.com/kuryr-kubernetes"},{"line_number":4,"context_line":"COPY . ."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN GO111MODULE\u003dauto go build -o /go/bin/kuryr-cni ./kuryr_cni/pkg/*"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"FROM registry.centos.org/centos:8"},{"line_number":9,"context_line":"LABEL authors\u003d\"Antoni Segura Puimedon\u003ctoni@kuryr.org\u003e, Michał Dulko\u003cmdulko@redhat.com\u003e\""}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"d84cd634_1805efb2","side":"PARENT","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":68},"in_reply_to":"91b1d871_149034c8","updated":"2021-05-10 09:45:52.000000000","message":"which deps does not use go mod? I thought only moving go.mod to root folder could help here, but no strong opinion.","commit_id":"da0ab7211a64023938d279c11e9cf5deb54b7056"}]}