)]}'
{"kuryr_kubernetes/controller/handlers/loadbalancer.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3857319d80e8c2788a6dcd0a0f079671d98f99f9","unresolved":true,"context_lines":[{"line_number":179,"context_line":"            LOG.debug(\u0027KuryrLoadBalancer CRD not found %s\u0027, loadbalancer_crd)"},{"line_number":180,"context_line":"            return False"},{"line_number":181,"context_line":"        except k_exc.K8sUnprocessableEntity:"},{"line_number":182,"context_line":"            LOG.warning(\u0027KuryrLoadBalancer %s modified, retrying later.\u0027,"},{"line_number":183,"context_line":"                        utils.get_res_unique_name(loadbalancer_crd))"},{"line_number":184,"context_line":"            return False"},{"line_number":185,"context_line":"        except k_exc.K8sClientException:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8437954f_1f2201b3","line":182,"updated":"2021-05-12 10:02:32.000000000","message":"Nice, make sense, the following event will handle it.","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"00ba84a42303e29abad685159d0a6355835f0255","unresolved":true,"context_lines":[{"line_number":179,"context_line":"            LOG.debug(\u0027KuryrLoadBalancer CRD not found %s\u0027, loadbalancer_crd)"},{"line_number":180,"context_line":"            return False"},{"line_number":181,"context_line":"        except k_exc.K8sUnprocessableEntity:"},{"line_number":182,"context_line":"            LOG.warning(\u0027KuryrLoadBalancer %s modified, retrying later.\u0027,"},{"line_number":183,"context_line":"                        utils.get_res_unique_name(loadbalancer_crd))"},{"line_number":184,"context_line":"            return False"},{"line_number":185,"context_line":"        except k_exc.K8sClientException:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed7d2a00_65a3fe67","line":182,"in_reply_to":"8437954f_1f2201b3","updated":"2021-05-12 13:14:40.000000000","message":"That\u0027s the idea, yes. I was concerned if the event won\u0027t get skipped at [1] but this shouldn\u0027t affect cases when we\u0027re already in `self._handler()` execution - which is right here.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/9f722e620042f9d148def00b523d19b5ce5cdd6b/kuryr_kubernetes/handlers/asynchronous.py#L100-L104","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4b640df35ab4db0da2b1c25a77de6bc50102a2a","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                        loadbalancer_crd[\u0027status\u0027][\u0027members\u0027] \u003d []"},{"line_number":347,"context_line":"                        loadbalancer_crd[\u0027status\u0027].get(\u0027members\u0027, []).append("},{"line_number":348,"context_line":"                            member)"},{"line_number":349,"context_line":"                    if not self._patch_status(loadbalancer_crd):"},{"line_number":350,"context_line":"                        return False"},{"line_number":351,"context_line":"                    changed \u003d True"},{"line_number":352,"context_line":"        return changed"}],"source_content_type":"text/x-python","patch_set":1,"id":"f30e0e50_2e62a5c1","line":349,"range":{"start_line":349,"start_character":20,"end_line":349,"end_character":64},"updated":"2021-05-12 10:16:11.000000000","message":"here previously we were continuing for the K8sReousrceNotFound case (instead of returning)","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c528b9a3cf46cc9798b121ba2e91b5b3ff222db3","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                        loadbalancer_crd[\u0027status\u0027][\u0027members\u0027] \u003d []"},{"line_number":347,"context_line":"                        loadbalancer_crd[\u0027status\u0027].get(\u0027members\u0027, []).append("},{"line_number":348,"context_line":"                            member)"},{"line_number":349,"context_line":"                    if not self._patch_status(loadbalancer_crd):"},{"line_number":350,"context_line":"                        return False"},{"line_number":351,"context_line":"                    changed \u003d True"},{"line_number":352,"context_line":"        return changed"}],"source_content_type":"text/x-python","patch_set":1,"id":"d313c806_4a0bc523","line":349,"range":{"start_line":349,"start_character":20,"end_line":349,"end_character":64},"in_reply_to":"b814bcfd_87c6fa08","updated":"2021-05-12 14:09:42.000000000","message":"Done","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"fc1f7d8b6430c5f5392a07bfe1f5d453698c7275","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                        loadbalancer_crd[\u0027status\u0027][\u0027members\u0027] \u003d []"},{"line_number":347,"context_line":"                        loadbalancer_crd[\u0027status\u0027].get(\u0027members\u0027, []).append("},{"line_number":348,"context_line":"                            member)"},{"line_number":349,"context_line":"                    if not self._patch_status(loadbalancer_crd):"},{"line_number":350,"context_line":"                        return False"},{"line_number":351,"context_line":"                    changed \u003d True"},{"line_number":352,"context_line":"        return changed"}],"source_content_type":"text/x-python","patch_set":1,"id":"b814bcfd_87c6fa08","line":349,"range":{"start_line":349,"start_character":20,"end_line":349,"end_character":64},"in_reply_to":"ecb43c1b_694f0092","updated":"2021-05-12 13:54:18.000000000","message":"Umm, right. Perhaps worth to mention it on the commit message, as then it is not only about the 422, but also about better dealing with 404 errors","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"00ba84a42303e29abad685159d0a6355835f0255","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                        loadbalancer_crd[\u0027status\u0027][\u0027members\u0027] \u003d []"},{"line_number":347,"context_line":"                        loadbalancer_crd[\u0027status\u0027].get(\u0027members\u0027, []).append("},{"line_number":348,"context_line":"                            member)"},{"line_number":349,"context_line":"                    if not self._patch_status(loadbalancer_crd):"},{"line_number":350,"context_line":"                        return False"},{"line_number":351,"context_line":"                    changed \u003d True"},{"line_number":352,"context_line":"        return changed"}],"source_content_type":"text/x-python","patch_set":1,"id":"ecb43c1b_694f0092","line":349,"range":{"start_line":349,"start_character":20,"end_line":349,"end_character":64},"in_reply_to":"f30e0e50_2e62a5c1","updated":"2021-05-12 13:14:40.000000000","message":"Yes, but what\u0027s the point of continuing in such cases? If we get 404, it means that there should be a DELETED event waiting for us in the queue that will cause us to delete the LB.","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4b640df35ab4db0da2b1c25a77de6bc50102a2a","unresolved":true,"context_lines":[{"line_number":454,"context_line":"                       if m[\u0027id\u0027] not in removed_ids]"},{"line_number":455,"context_line":"            loadbalancer_crd[\u0027status\u0027][\u0027members\u0027] \u003d members"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"            if not self._patch_status(loadbalancer_crd):"},{"line_number":458,"context_line":"                return False"},{"line_number":459,"context_line":"        return bool(removed_ids)"},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d506638b_0b1c4d59","line":457,"range":{"start_line":457,"start_character":12,"end_line":457,"end_character":56},"updated":"2021-05-12 10:16:11.000000000","message":"ditto","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4b640df35ab4db0da2b1c25a77de6bc50102a2a","unresolved":true,"context_lines":[{"line_number":494,"context_line":"                loadbalancer_crd[\u0027status\u0027].get(\u0027pools\u0027, []).append("},{"line_number":495,"context_line":"                    pool)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"            if not self._patch_status(loadbalancer_crd):"},{"line_number":498,"context_line":"                return False"},{"line_number":499,"context_line":"            changed \u003d True"},{"line_number":500,"context_line":"        return changed"}],"source_content_type":"text/x-python","patch_set":1,"id":"84640361_870483d8","line":497,"range":{"start_line":497,"start_character":12,"end_line":497,"end_character":56},"updated":"2021-05-12 10:16:11.000000000","message":"ditto","commit_id":"e4d33f689ee1569ddb1d14e2bf3ad31b7b21d3be"}]}