)]}'
{".zuul.d/base.yaml":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"80cc00a4f8594a871616b0f1ca35b00dc23ab225","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        etcd3: true"},{"line_number":87,"context_line":"        kubernetes-master: true"},{"line_number":88,"context_line":"        kuryr-kubernetes: true"},{"line_number":89,"context_line":"        kuryr-daemon: true"},{"line_number":90,"context_line":"        coredns: false"},{"line_number":91,"context_line":"        neutron-tag-ports-during-bulk-creation: true"},{"line_number":92,"context_line":"      zuul_copy_output:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"29e61274_e8c4386b","line":89,"updated":"2021-05-24 11:43:15.000000000","message":"why kuryr-daemon needs to be enabled? Isn\u0027t kuryr running on container for this job and kuryr-kubernetes-k8s-base?","commit_id":"11a34d0e5d3b90ef4a38fe1f6a25d1b42608b06d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f7f80a176d03971a8d122f3fd8d8c8a5731e0199","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        etcd3: true"},{"line_number":87,"context_line":"        kubernetes-master: true"},{"line_number":88,"context_line":"        kuryr-kubernetes: true"},{"line_number":89,"context_line":"        kuryr-daemon: true"},{"line_number":90,"context_line":"        coredns: false"},{"line_number":91,"context_line":"        neutron-tag-ports-during-bulk-creation: true"},{"line_number":92,"context_line":"      zuul_copy_output:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6c738f0f_508476a7","line":89,"in_reply_to":"29e61274_e8c4386b","updated":"2021-05-24 12:13:53.000000000","message":"It\u0027ll force building the kuryr-cni image. Seems better than my previous approach with an option doing it.","commit_id":"11a34d0e5d3b90ef4a38fe1f6a25d1b42608b06d"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"cf4202b38b7390c3e803f3f34b92dcf5286a1650","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        etcd3: true"},{"line_number":87,"context_line":"        kubernetes-master: true"},{"line_number":88,"context_line":"        kuryr-kubernetes: true"},{"line_number":89,"context_line":"        kuryr-daemon: true"},{"line_number":90,"context_line":"        coredns: false"},{"line_number":91,"context_line":"        neutron-tag-ports-during-bulk-creation: true"},{"line_number":92,"context_line":"      zuul_copy_output:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"6a008108_3c127886","line":89,"in_reply_to":"6c738f0f_508476a7","updated":"2021-05-24 12:32:40.000000000","message":"kurur-daemon and kuryr-kubernetes needs to be set regardless if we have it containerized or not. I found it misleading like it was before, so I\u0027ve change that, to be explicitly set, which services we do expect.","commit_id":"11a34d0e5d3b90ef4a38fe1f6a25d1b42608b06d"}],"devstack/lib/kubernetes":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"724b136db8d9a2c84ca0b60d1b5a470711eca2c8","unresolved":true,"context_lines":[{"line_number":152,"context_line":"nodeRegistration:"},{"line_number":153,"context_line":"  kubeletExtraArgs:"},{"line_number":154,"context_line":"    cgroup-driver: \"$(docker info -f \u0027{{.CgroupDriver}}\u0027)\""},{"line_number":155,"context_line":"    cni-bin-dir: \"$CNI_BIN_DIR\""},{"line_number":156,"context_line":"    cni-conf-dir: \"$CNI_CONF_DIR\""},{"line_number":157,"context_line":"    enable-server: \"true\""},{"line_number":158,"context_line":"  taints:"},{"line_number":159,"context_line":"    []"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3e74016f_d26053b2","line":156,"range":{"start_line":155,"start_character":0,"end_line":156,"end_character":33},"updated":"2021-05-21 10:46:09.000000000","message":"Nice, so it was possible in the end?","commit_id":"dbe652ed3633aca63770a21060b49b0507e48d94"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6170c4c226efaeb09a7b7a661fd9498b2204a4c4","unresolved":true,"context_lines":[{"line_number":152,"context_line":"nodeRegistration:"},{"line_number":153,"context_line":"  kubeletExtraArgs:"},{"line_number":154,"context_line":"    cgroup-driver: \"$(docker info -f \u0027{{.CgroupDriver}}\u0027)\""},{"line_number":155,"context_line":"    cni-bin-dir: \"$CNI_BIN_DIR\""},{"line_number":156,"context_line":"    cni-conf-dir: \"$CNI_CONF_DIR\""},{"line_number":157,"context_line":"    enable-server: \"true\""},{"line_number":158,"context_line":"  taints:"},{"line_number":159,"context_line":"    []"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"be738f7b_49a15127","line":156,"range":{"start_line":155,"start_character":0,"end_line":156,"end_character":33},"in_reply_to":"3e74016f_d26053b2","updated":"2021-05-21 10:49:33.000000000","message":"Yes! Note, that the kind is set to JoinConfiguration, which was a way to go, as I was guided on kubernetes slack.","commit_id":"dbe652ed3633aca63770a21060b49b0507e48d94"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"80cc00a4f8594a871616b0f1ca35b00dc23ab225","unresolved":true,"context_lines":[{"line_number":158,"context_line":"  taints:"},{"line_number":159,"context_line":"    []"},{"line_number":160,"context_line":"EOF"},{"line_number":161,"context_line":"    sudo -E kubeadm join --ignore-preflight-errors Swap \\"},{"line_number":162,"context_line":"        --config ${output_dir}/kubeadm-join.yaml"},{"line_number":163,"context_line":"}"},{"line_number":164,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"2e19e80a_6f187e32","line":161,"updated":"2021-05-24 11:43:15.000000000","message":"It would be good to have a NOTE about this","commit_id":"11a34d0e5d3b90ef4a38fe1f6a25d1b42608b06d"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"cf4202b38b7390c3e803f3f34b92dcf5286a1650","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  taints:"},{"line_number":159,"context_line":"    []"},{"line_number":160,"context_line":"EOF"},{"line_number":161,"context_line":"    sudo -E kubeadm join --ignore-preflight-errors Swap \\"},{"line_number":162,"context_line":"        --config ${output_dir}/kubeadm-join.yaml"},{"line_number":163,"context_line":"}"},{"line_number":164,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ab356ac2_13c0eab9","line":161,"in_reply_to":"2e19e80a_6f187e32","updated":"2021-05-24 12:32:40.000000000","message":"Ack\n\nNote, that the same goes for the init part. (line 113)","commit_id":"11a34d0e5d3b90ef4a38fe1f6a25d1b42608b06d"}],"devstack/plugin.sh":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"aa371a098da4a75ebc312ff6c166a3eae5131364","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":55,"context_line":"        echo_summary \"Installing kuryr CNI and Controller\""},{"line_number":56,"context_line":"        setup_develop \"$KURYR_HOME\""},{"line_number":57,"context_line":"        build_install_kuryr_cni"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":60,"context_line":"        echo_summary \"Configure kuryr bits\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"77ce2d91_66220f17","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":31},"updated":"2021-05-21 10:52:04.000000000","message":"Just a thought, so this shouldn\u0027t be required for containerized deployments. This should get you around the problem with golang missing on the subnode.","commit_id":"bb55d110f5bad323fded38c060b8647547f4a192"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"1016287ce484b03ffbe41e1648c0cdc768418b1b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"install\" ]]; then"},{"line_number":55,"context_line":"        echo_summary \"Installing kuryr CNI and Controller\""},{"line_number":56,"context_line":"        setup_develop \"$KURYR_HOME\""},{"line_number":57,"context_line":"        build_install_kuryr_cni"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    elif [[ \"$1\" \u003d\u003d \"stack\" \u0026\u0026 \"$2\" \u003d\u003d \"post-config\" ]]; then"},{"line_number":60,"context_line":"        echo_summary \"Configure kuryr bits\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"322ed57d_a1e0ed7c","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":31},"in_reply_to":"77ce2d91_66220f17","updated":"2021-05-21 11:10:04.000000000","message":"Ack","commit_id":"bb55d110f5bad323fded38c060b8647547f4a192"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"aa371a098da4a75ebc312ff6c166a3eae5131364","unresolved":true,"context_lines":[{"line_number":136,"context_line":"            # create LB until test-config phase. We can revisit this once"},{"line_number":137,"context_line":"            # Octavia\u0027s DevStack plugin will get improved."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"                if [ \"${KURYR_CONT}\" \u003d\u003d \"True\" ]; then"},{"line_number":140,"context_line":"                    run_containerized_kuryr_resources"},{"line_number":141,"context_line":"                else"},{"line_number":142,"context_line":"                    run_kuryr_kubernetes"},{"line_number":143,"context_line":"                    run_kuryr_daemon"},{"line_number":144,"context_line":"                fi"},{"line_number":145,"context_line":"        fi"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if is_service_enabled tempest; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"2985a67b_baeb0a8b","line":144,"range":{"start_line":139,"start_character":0,"end_line":144,"end_character":18},"updated":"2021-05-21 10:52:04.000000000","message":"This indentation seems to be a mistake?","commit_id":"bb55d110f5bad323fded38c060b8647547f4a192"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"1016287ce484b03ffbe41e1648c0cdc768418b1b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            # create LB until test-config phase. We can revisit this once"},{"line_number":137,"context_line":"            # Octavia\u0027s DevStack plugin will get improved."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"                if [ \"${KURYR_CONT}\" \u003d\u003d \"True\" ]; then"},{"line_number":140,"context_line":"                    run_containerized_kuryr_resources"},{"line_number":141,"context_line":"                else"},{"line_number":142,"context_line":"                    run_kuryr_kubernetes"},{"line_number":143,"context_line":"                    run_kuryr_daemon"},{"line_number":144,"context_line":"                fi"},{"line_number":145,"context_line":"        fi"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if is_service_enabled tempest; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"6d2913ab_0b43bd84","line":144,"range":{"start_line":139,"start_character":0,"end_line":144,"end_character":18},"in_reply_to":"2985a67b_baeb0a8b","updated":"2021-05-21 11:10:04.000000000","message":"Ack","commit_id":"bb55d110f5bad323fded38c060b8647547f4a192"}]}