)]}'
{"kuryr_kubernetes/controller/drivers/default_subnet.py":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"4341b6ef96c438fd5abad2cbcf78ecb2cd984e95","unresolved":true,"context_lines":[{"line_number":23,"context_line":"class DefaultPodSubnetDriver(base.PodSubnetsDriver):"},{"line_number":24,"context_line":"    \"\"\"Provides subnet for Pod or VM port based on a configuration option.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_subnets(self, pod, vm, project_id):"},{"line_number":27,"context_line":"        subnet_id \u003d config.CONF.neutron_defaults.pod_subnet"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        if not subnet_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"23a2ea11_3b5148f8","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":46},"updated":"2021-08-19 00:32:37.000000000","message":"This new vm param needs to be added to the test file:\nTypeError: get_subnets() missing 1 required positional argument: \u0027project_id\u0027\n\nhttps://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/drivers/test_default_subnet.py#L76-L77","commit_id":"6854223ff0e000981a520866c749e26063a28a5c"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"d7810bfc5eea840c97a8e2f1bb1592b2a821e4ec","unresolved":true,"context_lines":[{"line_number":23,"context_line":"class DefaultPodSubnetDriver(base.PodSubnetsDriver):"},{"line_number":24,"context_line":"    \"\"\"Provides subnet for Pod or VM port based on a configuration option.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_subnets(self, pod, vm, project_id):"},{"line_number":27,"context_line":"        subnet_id \u003d config.CONF.neutron_defaults.pod_subnet"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        if not subnet_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"d650aeac_db157e3e","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":46},"in_reply_to":"23a2ea11_3b5148f8","updated":"2021-08-19 00:36:08.000000000","message":"Sorry, wrong place in that link. It\u0027s here:\nhttps://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/drivers/test_default_subnet.py#L66","commit_id":"6854223ff0e000981a520866c749e26063a28a5c"}],"kuryr_kubernetes/controller/handlers/loadbalancer.py":[{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"4341b6ef96c438fd5abad2cbcf78ecb2cd984e95","unresolved":true,"context_lines":[{"line_number":447,"context_line":"            subnet_id \u003d lb_crd[\u0027status\u0027][\u0027loadbalancer\u0027][\u0027subnet_id\u0027]"},{"line_number":448,"context_line":"        return subnet_id"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    def _get_pod_subnet(self, pod, vm, ip):"},{"line_number":451,"context_line":"        project_id \u003d self._drv_pod_project.get_project(pod)"},{"line_number":452,"context_line":"        subnets_map \u003d self._drv_pod_subnets.get_subnets(pod, vm, project_id)"},{"line_number":453,"context_line":"        subnet_ids \u003d [subnet_id for subnet_id, network in subnets_map.items()"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5bec45d_23fa03bd","line":450,"range":{"start_line":450,"start_character":4,"end_line":450,"end_character":43},"updated":"2021-08-19 00:32:37.000000000","message":"The unittest for this will need to be updated to include the new \u0027vm\u0027 parameter as well. Currently failing because of this:\n TypeError: _get_pod_subnet() missing 1 required positional argument: \u0027ip\u0027\n\nhttps://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/tests/unit/controller/handlers/test_loadbalancer.py#L475-L476","commit_id":"6854223ff0e000981a520866c749e26063a28a5c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"fef301721cfd765ee3477289dec0e4a84a0134fb","unresolved":true,"context_lines":[{"line_number":367,"context_line":"                    if (target_ip, target_port, pool[\u0027id\u0027]) in current_targets:"},{"line_number":368,"context_line":"                        continue"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"                    member_subnet_id \u003d self._get_subnet_by_octavia_mode("},{"line_number":371,"context_line":"                        target_pod, target_vm, target_ip, loadbalancer_crd)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"                    if not member_subnet_id:"},{"line_number":374,"context_line":"                        LOG.warning(\"Skipping member creation for %s\","}],"source_content_type":"text/x-python","patch_set":11,"id":"cc616ef1_25baf2c6","line":371,"range":{"start_line":370,"start_character":20,"end_line":371,"end_character":75},"updated":"2021-08-23 08:26:03.000000000","message":"Following previous discussion, we could make target_pod and target_vm more generic and handled together, by just looking for ACTIVE port(s) with the IP address that are connected to the Router being used by Kuryr.","commit_id":"74d4b7810c8a56818bad75ae85bdb1e79642a093"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4bc59672f3f39ec5cc1cfd35171a4e709abb09dd","unresolved":true,"context_lines":[{"line_number":346,"context_line":"                            target_ip):"},{"line_number":347,"context_line":"                        neutron_port \u003d {}"},{"line_number":348,"context_line":"                    else:"},{"line_number":349,"context_line":"                        neutron_port \u003d utils.get_port_by_ip("},{"line_number":350,"context_line":"                            target_ip, target_namespace)"},{"line_number":351,"context_line":"                except KeyError:"},{"line_number":352,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":13,"id":"1de793de_a57e9390","line":349,"range":{"start_line":349,"start_character":45,"end_line":349,"end_character":59},"updated":"2021-08-27 16:06:45.000000000","message":"This seems like a significant increase in Neutron calls if this is inside the loop. I\u0027d consider trying to do get_port_by_ip() only if get_pod_by_ip() rendered no results.","commit_id":"30d1a120ca1fa957abad0a2ce348054cab0a7d1b"}]}