)]}'
{"kuryr_kubernetes/cmd/sanity/checks.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6bcc9d5eab18abb292d8de4f6a8deada6fda0d6b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"from kuryr_kubernetes import config"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":12,"id":"177e6f91_0e05617f","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":35},"updated":"2021-08-27 16:01:49.000000000","message":"You should divide the internal imports from external by a newline.","commit_id":"c79e57140b4795c08ce3be3a00a7db7b6ac26179"}],"kuryr_kubernetes/cmd/sanity_checks.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"eac9932c547c68fb719e0b9bb583e88dadcc1a88","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2021 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":13,"id":"16474526_05ea20af","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":30},"updated":"2021-09-20 19:58:10.000000000","message":"minor: redhat, e.g. https://github.com/openshift/kuryr-kubernetes/blob/51c0d2ff8f6ea77c0ca2c968ee94d230e1a93416/kuryr_kubernetes/controller/handlers/kuryrnetwork.py#L1\n\nsame apply for the other files","commit_id":"d8989990a049ebbcb3a27efb1d03ab4983692165"},{"author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"change_message_id":"dc2cf14f0a95c31d8748a06a7453e4f46c0549de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2021 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":13,"id":"bd060d0e_a0147b15","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":30},"in_reply_to":"16474526_05ea20af","updated":"2021-09-24 03:59:24.000000000","message":"Sanity checks code is based off other OpenStack Foundation projects, for example neutron: https://github.com/openstack/neutron/blob/master/neutron/cmd/sanity_check.py#L418-L422 hence the OpenStack Foundation.","commit_id":"d8989990a049ebbcb3a27efb1d03ab4983692165"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"eac9932c547c68fb719e0b9bb583e88dadcc1a88","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    return result"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Define CLI opts to test specific features, with a callback for the test"},{"line_number":61,"context_line":"OPTS \u003d ["},{"line_number":62,"context_line":"    BoolOptCallback(\u0027vif_pool_min_max\u0027, check_ports_pool_min_max,"},{"line_number":63,"context_line":"                    default\u003dFalse,"},{"line_number":64,"context_line":"                    help\u003d\u0027Check configuration sanity of ports_pool_max and \u0027"},{"line_number":65,"context_line":"                         \u0027ports_pool_max.\u0027),"},{"line_number":66,"context_line":"    BoolOptCallback(\u0027vif_pool_max_batch\u0027, check_ports_pool_max_batch,"},{"line_number":67,"context_line":"                    default\u003dFalse,"},{"line_number":68,"context_line":"                    help\u003d\u0027Check configuration sanity of ports_pool_max and \u0027"},{"line_number":69,"context_line":"                         \u0027ports_pool_batch.\u0027),"},{"line_number":70,"context_line":"]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"507722ad_c61b1820","line":69,"range":{"start_line":60,"start_character":0,"end_line":69,"end_character":46},"updated":"2021-09-20 19:58:10.000000000","message":"I believe there is one scenario missing, min \u003c batch (e.g. https://github.com/openshift/cluster-network-operator/blame/master/pkg/network/kuryr.go#L177-L178)","commit_id":"d8989990a049ebbcb3a27efb1d03ab4983692165"},{"author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"change_message_id":"dc2cf14f0a95c31d8748a06a7453e4f46c0549de","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    return result"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"# Define CLI opts to test specific features, with a callback for the test"},{"line_number":61,"context_line":"OPTS \u003d ["},{"line_number":62,"context_line":"    BoolOptCallback(\u0027vif_pool_min_max\u0027, check_ports_pool_min_max,"},{"line_number":63,"context_line":"                    default\u003dFalse,"},{"line_number":64,"context_line":"                    help\u003d\u0027Check configuration sanity of ports_pool_max and \u0027"},{"line_number":65,"context_line":"                         \u0027ports_pool_max.\u0027),"},{"line_number":66,"context_line":"    BoolOptCallback(\u0027vif_pool_max_batch\u0027, check_ports_pool_max_batch,"},{"line_number":67,"context_line":"                    default\u003dFalse,"},{"line_number":68,"context_line":"                    help\u003d\u0027Check configuration sanity of ports_pool_max and \u0027"},{"line_number":69,"context_line":"                         \u0027ports_pool_batch.\u0027),"},{"line_number":70,"context_line":"]"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"CLI_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"c231d6d1_a5a30168","line":69,"range":{"start_line":60,"start_character":0,"end_line":69,"end_character":46},"in_reply_to":"507722ad_c61b1820","updated":"2021-09-24 03:59:24.000000000","message":"Thanks! Added","commit_id":"d8989990a049ebbcb3a27efb1d03ab4983692165"}]}