)]}'
{"kuryr_kubernetes/controller/drivers/namespace_subnet.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fff9cc1c9a2b59f4f37c708a49a5142878d2c87f","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                                                      kl_const.DEVICE_OWNER]:"},{"line_number":113,"context_line":"                    continue"},{"line_number":114,"context_line":"                c_utils.delete_port(leftover_port.id)"},{"line_number":115,"context_line":"            raise exceptions.ResourceNotReady(net_id)"},{"line_number":116,"context_line":"        except os_exc.SDKException:"},{"line_number":117,"context_line":"            LOG.exception(\"Error deleting network %s.\", net_id)"},{"line_number":118,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"aaadd2f9_b95b224b","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":53},"updated":"2021-09-15 12:13:24.000000000","message":"This will not be needed anymore.","commit_id":"23f45ce64e004fe9188b29644fbfd65427700acb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6dd073bfaeca239a97a834eb6cca8a7ae6d3d88e","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                                                      kl_const.DEVICE_OWNER]:"},{"line_number":113,"context_line":"                    continue"},{"line_number":114,"context_line":"                c_utils.delete_port(leftover_port.id)"},{"line_number":115,"context_line":"            raise exceptions.ResourceNotReady(net_id)"},{"line_number":116,"context_line":"        except os_exc.SDKException:"},{"line_number":117,"context_line":"            LOG.exception(\"Error deleting network %s.\", net_id)"},{"line_number":118,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"d7b4c8d0_350854a0","line":115,"range":{"start_line":115,"start_character":0,"end_line":115,"end_character":53},"in_reply_to":"aaadd2f9_b95b224b","updated":"2021-09-16 10:12:42.000000000","message":"Uh, oh. We still do need that ResourceNotReady raised here to make sure os_net.delete_network() is retried. :/ Sorry for confusing you, we\u0027ve looked at this wrongly yesterday.","commit_id":"23f45ce64e004fe9188b29644fbfd65427700acb"}],"kuryr_kubernetes/controller/drivers/utils.py":[{"author":{"_account_id":19521,"name":"Robin Cernin","email":"rcernin@redhat.com","username":"rcernin"},"change_message_id":"457d4266e3e0a0aaf2a74a736b29b3362f2637ea","unresolved":true,"context_lines":[{"line_number":701,"context_line":"                LOG.debug("},{"line_number":702,"context_line":"                    \"Port %s already removed from trunk %s\","},{"line_number":703,"context_line":"                    port_id, trunk_id)"},{"line_number":704,"context_line":"            try:"},{"line_number":705,"context_line":"                os_net.delete_port(port_id)"},{"line_number":706,"context_line":"            except os_exc.SDKException:"},{"line_number":707,"context_line":"                LOG.exception(\"Unexpected error deleting \""}],"source_content_type":"text/x-python","patch_set":4,"id":"0f64d1ac_2769ec97","line":704,"updated":"2021-09-14 22:25:01.000000000","message":"@Michal I have added this part to try delete port after it was removed from the trunk, it was not part of the original drivers/namespace_subnet.py I was thinking whether that was a bug or not, since without it we would just remove the port from trunk but not delete the port. Hope this is all good.\n\nCan you please review again, thank you.","commit_id":"78ef8feec915d538b46f70343dc0a4942994fa07"}],"kuryr_kubernetes/controller/drivers/vif_pool.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9c215926e21b714869f9a6efb6ff789416914d4e","unresolved":true,"context_lines":[{"line_number":477,"context_line":"                if not port.binding_host_id:"},{"line_number":478,"context_line":"                    try:"},{"line_number":479,"context_line":"                        os_net.delete_port(port[\u0027id\u0027])"},{"line_number":480,"context_line":"                    except os_exc.SDKException as e:"},{"line_number":481,"context_line":"                        if \"currently a subport for trunk\" in str(e):"},{"line_number":482,"context_line":"                            LOG.warning(\"Port %s is still associated to a \""},{"line_number":483,"context_line":"                                        \"trunk. This should not happen. \""},{"line_number":484,"context_line":"                                        \"Trying to delete it from the \""},{"line_number":485,"context_line":"                                        \"trunk.\", port[\u0027id\u0027])"},{"line_number":486,"context_line":"                            # Get the trunk_id from the error message"},{"line_number":487,"context_line":"                            trunk_id \u003d ("},{"line_number":488,"context_line":"                                str(e).split(\u0027trunk\u0027)[1].split(\u0027.\u0027)[0].strip())"}],"source_content_type":"text/x-python","patch_set":1,"id":"474bad21_03db7775","line":485,"range":{"start_line":480,"start_character":0,"end_line":485,"end_character":61},"updated":"2021-09-14 15:47:11.000000000","message":"Can we try to extract this into some helper function (e.g. in kuryr_kubernetes.drivers.utils) and make sure code isn\u0027t repeated [1]? I\u0027m motivated to request that as `# Get the trunk_id from the error message` is super volatile and if Neutron ever changes message formatting I\u0027d like to be able to fix it in a single place.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/17f99a71782caec0cbf73cb268fc55ef0d2dba06/kuryr_kubernetes/controller/drivers/namespace_subnet.py#L121-L139","commit_id":"00109ae4b5ebeb80f78d6a093d9fbd8cb72bd277"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e97e260e820fbf8c4998ee14fa4f443ca0ee31bd","unresolved":true,"context_lines":[{"line_number":501,"context_line":"                                              \"and continue with the other \""},{"line_number":502,"context_line":"                                              \"rest.\", port[\u0027id\u0027])"},{"line_number":503,"context_line":"                        else:"},{"line_number":504,"context_line":"                            LOG.exception(\"Unexpected error deleting leftover \""},{"line_number":505,"context_line":"                                          \"port %s. Skipping it and \""},{"line_number":506,"context_line":"                                          \"continue with the other \""},{"line_number":507,"context_line":"                                          \"rest.\", port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"a971b5b0_fbe4b8c4","line":504,"range":{"start_line":504,"start_character":28,"end_line":504,"end_character":42},"updated":"2021-09-14 09:53:16.000000000","message":"this log message is out of the exception context consequently the traceback wouldn\u0027t be logged here, maybe it can be removed and line 499 handles that.","commit_id":"00109ae4b5ebeb80f78d6a093d9fbd8cb72bd277"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9c215926e21b714869f9a6efb6ff789416914d4e","unresolved":true,"context_lines":[{"line_number":501,"context_line":"                                              \"and continue with the other \""},{"line_number":502,"context_line":"                                              \"rest.\", port[\u0027id\u0027])"},{"line_number":503,"context_line":"                        else:"},{"line_number":504,"context_line":"                            LOG.exception(\"Unexpected error deleting leftover \""},{"line_number":505,"context_line":"                                          \"port %s. Skipping it and \""},{"line_number":506,"context_line":"                                          \"continue with the other \""},{"line_number":507,"context_line":"                                          \"rest.\", port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"03a8840f_015b14bd","line":504,"range":{"start_line":504,"start_character":28,"end_line":504,"end_character":42},"in_reply_to":"a971b5b0_fbe4b8c4","updated":"2021-09-14 15:47:11.000000000","message":"It is in context of exception from line 480 and I assume that\u0027s the point.","commit_id":"00109ae4b5ebeb80f78d6a093d9fbd8cb72bd277"}]}