)]}'
{"kuryr_kubernetes/k8s_client.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9ce53f1d3a6d6445bb56bd188839e981c60f2261","unresolved":true,"context_lines":[{"line_number":473,"context_line":"                 \u0027type\u0027: type_,"},{"line_number":474,"context_line":"                 \u0027involvedObject\u0027: involved_object}"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        return self.post(f\u0027{constants.K8S_API_BASE}/namespaces/\u0027"},{"line_number":477,"context_line":"                         f\u0027{resource[\"metadata\"][\"namespace\"]}/events\u0027, event)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _get_hex_timestamp(self, datetimeobj):"},{"line_number":480,"context_line":"        \"\"\"Get hex representation for timestamp."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f67df9a_d712e973","line":477,"range":{"start_line":476,"start_character":0,"end_line":477,"end_character":78},"updated":"2021-09-14 14:51:31.000000000","message":"Events are pretty ephemeral and I don\u0027t think errors when creating them should stop any operation from happening. I\u0027d consider silencing K8sClientExceptions here.","commit_id":"1e1edcd9f9cd0f298a4f5421cf54ff8c57dee875"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"ace71ab1b9a68e02ad4e8137dd4e3b8f55167d15","unresolved":true,"context_lines":[{"line_number":473,"context_line":"                 \u0027type\u0027: type_,"},{"line_number":474,"context_line":"                 \u0027involvedObject\u0027: involved_object}"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        return self.post(f\u0027{constants.K8S_API_BASE}/namespaces/\u0027"},{"line_number":477,"context_line":"                         f\u0027{resource[\"metadata\"][\"namespace\"]}/events\u0027, event)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _get_hex_timestamp(self, datetimeobj):"},{"line_number":480,"context_line":"        \"\"\"Get hex representation for timestamp."}],"source_content_type":"text/x-python","patch_set":1,"id":"fad7563e_97d2f07a","line":477,"range":{"start_line":476,"start_character":0,"end_line":477,"end_character":78},"in_reply_to":"9f67df9a_d712e973","updated":"2021-09-15 08:43:09.000000000","message":"Ok, that make sense. I\u0027ll add a LOG.Warning maybe, to indicate, that there was a failure creating an event.","commit_id":"1e1edcd9f9cd0f298a4f5421cf54ff8c57dee875"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"54d6839480420027ec1c564c39c2e66d699c9916","unresolved":true,"context_lines":[{"line_number":473,"context_line":"                 \u0027type\u0027: type_,"},{"line_number":474,"context_line":"                 \u0027involvedObject\u0027: involved_object}"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        return self.post(f\u0027{constants.K8S_API_BASE}/namespaces/\u0027"},{"line_number":477,"context_line":"                         f\u0027{resource[\"metadata\"][\"namespace\"]}/events\u0027, event)"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def _get_hex_timestamp(self, datetimeobj):"},{"line_number":480,"context_line":"        \"\"\"Get hex representation for timestamp."}],"source_content_type":"text/x-python","patch_set":1,"id":"60457831_497cc98c","line":477,"range":{"start_line":476,"start_character":0,"end_line":477,"end_character":78},"in_reply_to":"fad7563e_97d2f07a","updated":"2021-09-15 08:50:38.000000000","message":"Logging a warning makes perfect sense.","commit_id":"1e1edcd9f9cd0f298a4f5421cf54ff8c57dee875"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9ce53f1d3a6d6445bb56bd188839e981c60f2261","unresolved":true,"context_lines":[{"line_number":479,"context_line":"    def _get_hex_timestamp(self, datetimeobj):"},{"line_number":480,"context_line":"        \"\"\"Get hex representation for timestamp."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        In Kuberenets, Event name is constructed name of the bounded object"},{"line_number":483,"context_line":"        and timestamp in hexadecimal representation."},{"line_number":484,"context_line":"        Note, that Python timestamp is represented as floating figure:"},{"line_number":485,"context_line":"          1631622163.8534190654754638671875"}],"source_content_type":"text/x-python","patch_set":1,"id":"79b53e3c_4ad71e2a","line":482,"range":{"start_line":482,"start_character":0,"end_line":482,"end_character":75},"updated":"2021-09-14 14:51:31.000000000","message":"Just a note - I think name doesn\u0027t really matter for K8s itself, but it\u0027s really nice to follow the convention.","commit_id":"1e1edcd9f9cd0f298a4f5421cf54ff8c57dee875"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"ace71ab1b9a68e02ad4e8137dd4e3b8f55167d15","unresolved":true,"context_lines":[{"line_number":479,"context_line":"    def _get_hex_timestamp(self, datetimeobj):"},{"line_number":480,"context_line":"        \"\"\"Get hex representation for timestamp."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        In Kuberenets, Event name is constructed name of the bounded object"},{"line_number":483,"context_line":"        and timestamp in hexadecimal representation."},{"line_number":484,"context_line":"        Note, that Python timestamp is represented as floating figure:"},{"line_number":485,"context_line":"          1631622163.8534190654754638671875"}],"source_content_type":"text/x-python","patch_set":1,"id":"c4b40bdb_e3136692","line":482,"range":{"start_line":482,"start_character":0,"end_line":482,"end_character":75},"in_reply_to":"79b53e3c_4ad71e2a","updated":"2021-09-15 08:43:09.000000000","message":"Actually - it does matter for the order. In my doodling with the code, I\u0027ve used uuid as the name of the event, and quickly turns out, that my events are listed in wrong order either in `kubectl get events` or using describe command on the object, since the list is not sorted by event timestamp, but by its name :/ Hence this a bit weird implementation.","commit_id":"1e1edcd9f9cd0f298a4f5421cf54ff8c57dee875"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"54d6839480420027ec1c564c39c2e66d699c9916","unresolved":true,"context_lines":[{"line_number":479,"context_line":"    def _get_hex_timestamp(self, datetimeobj):"},{"line_number":480,"context_line":"        \"\"\"Get hex representation for timestamp."},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"        In Kuberenets, Event name is constructed name of the bounded object"},{"line_number":483,"context_line":"        and timestamp in hexadecimal representation."},{"line_number":484,"context_line":"        Note, that Python timestamp is represented as floating figure:"},{"line_number":485,"context_line":"          1631622163.8534190654754638671875"}],"source_content_type":"text/x-python","patch_set":1,"id":"da81d554_5869044c","line":482,"range":{"start_line":482,"start_character":0,"end_line":482,"end_character":75},"in_reply_to":"c4b40bdb_e3136692","updated":"2021-09-15 08:50:38.000000000","message":"Wow, interesting!","commit_id":"1e1edcd9f9cd0f298a4f5421cf54ff8c57dee875"}]}