)]}'
{"kuryr_kubernetes/controller/drivers/node_subnets.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e8fc6800e676a6ff113a02480aee432ef3b5f719","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            subnet_id \u003d spec[\u0027primarySubnet\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if not subnet_id and \u0027networks\u0027 in spec:"},{"line_number":70,"context_line":"            if not spec.get(\u0027networks\u0027):"},{"line_number":71,"context_line":"                LOG.info(\u0027No `networks` in Machine `providerSpec`\u0027)"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                subnets \u003d spec[\u0027networks\u0027][0].get(\u0027subnets\u0027)"},{"line_number":74,"context_line":"                if not subnets:"},{"line_number":75,"context_line":"                    LOG.warning(\u0027No `subnets` in Machine `providerSpec.values.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"b7bcae1b_5db70b7b","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":17},"updated":"2021-09-24 11:53:02.000000000","message":"Is there a need for the if/else given that you already check if \u0027networks\u0027 is in the spec on line 69?","commit_id":"6efcd1d908a09d895f6f62ddd8fbbf75dd28f372"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"9c069db06902b7876a66effa8710ffd8ad64083b","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            subnet_id \u003d spec[\u0027primarySubnet\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if not subnet_id and \u0027networks\u0027 in spec:"},{"line_number":70,"context_line":"            if not spec.get(\u0027networks\u0027):"},{"line_number":71,"context_line":"                LOG.info(\u0027No `networks` in Machine `providerSpec`\u0027)"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                subnets \u003d spec[\u0027networks\u0027][0].get(\u0027subnets\u0027)"},{"line_number":74,"context_line":"                if not subnets:"},{"line_number":75,"context_line":"                    LOG.warning(\u0027No `subnets` in Machine `providerSpec.values.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"d595b0a1_4a1e869d","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":17},"in_reply_to":"b7bcae1b_5db70b7b","updated":"2021-09-27 06:21:16.000000000","message":"ah, right. I overdone it ;)","commit_id":"6efcd1d908a09d895f6f62ddd8fbbf75dd28f372"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"d12d03d65c7c39527f00e88c70d88d758c2c84ca","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        super().__init__()"},{"line_number":57,"context_line":"        self.subnets \u003d set()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_subnet_from_machine(self, machine):"},{"line_number":60,"context_line":"        spec \u003d machine[\u0027spec\u0027].get(\u0027providerSpec\u0027, {}).get(\u0027value\u0027)"},{"line_number":61,"context_line":"        subnet_id \u003d None"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"db4a67fd_4128a080","line":59,"updated":"2021-09-29 16:32:16.000000000","message":"There might be Subnets that does not use a Trunk. Shouldn\u0027t we always only look for the ones with Trunks in order to create the Ports pool and handle Network Policy?\nThere is a Trunks field defined on Ports and MachineSpec https://github.com/openshift/cluster-api-provider-openstack/blob/release-4.9/pkg/apis/openstackproviderconfig/v1alpha1/types.go","commit_id":"91d7feafae910d6335a5866278f2ec397eb7a461"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6239647a1105f954d7640589aae8b2d9a4e9d468","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        super().__init__()"},{"line_number":57,"context_line":"        self.subnets \u003d set()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_subnet_from_machine(self, machine):"},{"line_number":60,"context_line":"        spec \u003d machine[\u0027spec\u0027].get(\u0027providerSpec\u0027, {}).get(\u0027value\u0027)"},{"line_number":61,"context_line":"        subnet_id \u003d None"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"979f29e6_bb12fd90","line":59,"in_reply_to":"00096879_baae8a85","updated":"2021-10-07 07:45:37.000000000","message":"Ack","commit_id":"91d7feafae910d6335a5866278f2ec397eb7a461"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6cf51267499b42ff1a523e5916340f37902ba152","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        super().__init__()"},{"line_number":57,"context_line":"        self.subnets \u003d set()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_subnet_from_machine(self, machine):"},{"line_number":60,"context_line":"        spec \u003d machine[\u0027spec\u0027].get(\u0027providerSpec\u0027, {}).get(\u0027value\u0027)"},{"line_number":61,"context_line":"        subnet_id \u003d None"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"00096879_baae8a85","line":59,"in_reply_to":"db4a67fd_4128a080","updated":"2021-10-06 14:50:43.000000000","message":"Makes sense, we might want to check if openStackMachine.Spec.Trunk is set to True. If so - use first port we find. If not - use first port with trunk that we find.","commit_id":"91d7feafae910d6335a5866278f2ec397eb7a461"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6cf51267499b42ff1a523e5916340f37902ba152","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            subnet_id \u003d spec[\u0027primarySubnet\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if not subnet_id and \u0027networks\u0027 in spec:"},{"line_number":70,"context_line":"            subnets \u003d spec[\u0027networks\u0027][0].get(\u0027subnets\u0027)"},{"line_number":71,"context_line":"            if not subnets:"},{"line_number":72,"context_line":"                LOG.warning(\u0027No `subnets` in Machine `providerSpec.values.\u0027"},{"line_number":73,"context_line":"                            \u0027networks`.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"84b1720e_92634b99","line":70,"range":{"start_line":70,"start_character":38,"end_line":70,"end_character":41},"updated":"2021-10-06 14:50:43.000000000","message":"Maybe we would want this not to explode if `networks` is just empty list. I know, it was like this previously. ;)","commit_id":"91d7feafae910d6335a5866278f2ec397eb7a461"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6239647a1105f954d7640589aae8b2d9a4e9d468","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            subnet_id \u003d spec[\u0027primarySubnet\u0027]"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if not subnet_id and \u0027networks\u0027 in spec:"},{"line_number":70,"context_line":"            subnets \u003d spec[\u0027networks\u0027][0].get(\u0027subnets\u0027)"},{"line_number":71,"context_line":"            if not subnets:"},{"line_number":72,"context_line":"                LOG.warning(\u0027No `subnets` in Machine `providerSpec.values.\u0027"},{"line_number":73,"context_line":"                            \u0027networks`.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0a303fb9_f1e1393e","line":70,"range":{"start_line":70,"start_character":38,"end_line":70,"end_character":41},"in_reply_to":"84b1720e_92634b99","updated":"2021-10-07 07:45:37.000000000","message":"Ack","commit_id":"91d7feafae910d6335a5866278f2ec397eb7a461"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6cf51267499b42ff1a523e5916340f37902ba152","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                    subnet_id \u003d utils.get_subnet_id(**subnet_filter)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if not subnet_id and \u0027ports\u0027 in spec:"},{"line_number":83,"context_line":"            subnet_id \u003d spec[\u0027ports\u0027][0].get(\u0027fixedIPs\u0027, {})[0].get(\u0027subnetID\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not subnet_id:"},{"line_number":86,"context_line":"            LOG.warning(\u0027No `subnets` found in Machine `providerSpec`\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0e446b0d_42d93838","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":40},"updated":"2021-10-06 14:50:43.000000000","message":"Same here.","commit_id":"91d7feafae910d6335a5866278f2ec397eb7a461"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6239647a1105f954d7640589aae8b2d9a4e9d468","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    subnet_id \u003d utils.get_subnet_id(**subnet_filter)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if not subnet_id and \u0027ports\u0027 in spec:"},{"line_number":83,"context_line":"            subnet_id \u003d spec[\u0027ports\u0027][0].get(\u0027fixedIPs\u0027, {})[0].get(\u0027subnetID\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not subnet_id:"},{"line_number":86,"context_line":"            LOG.warning(\u0027No `subnets` found in Machine `providerSpec`\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b83f4be4_1cc6acbe","line":83,"range":{"start_line":83,"start_character":37,"end_line":83,"end_character":40},"in_reply_to":"0e446b0d_42d93838","updated":"2021-10-07 07:45:37.000000000","message":"Ack","commit_id":"91d7feafae910d6335a5866278f2ec397eb7a461"}]}