)]}'
{"kuryr_kubernetes/controller/handlers/vif.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"d5a92f41f66124827b8fad2bee7d6e57e14a8ff6","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        if driver_utils.is_host_network(pod):"},{"line_number":45,"context_line":"            return"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":48,"context_line":"        kp \u003d driver_utils.get_kuryrport(pod)"},{"line_number":49,"context_line":"        if utils.is_pod_completed(pod):"},{"line_number":50,"context_line":"            if kp:"}],"source_content_type":"text/x-python","patch_set":2,"id":"e7008fbb_88423e49","line":47,"updated":"2021-10-06 07:52:25.000000000","message":"k8s client is not used, do we need that here?","commit_id":"dfb865786eb59f77b697755ef035cccc99ee93bb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e3cb18650dd0f41a2d2be0d826cdf0d201052dda","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            return"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":48,"context_line":"        kp \u003d driver_utils.get_kuryrport(pod)"},{"line_number":49,"context_line":"        if utils.is_pod_completed(pod):"},{"line_number":50,"context_line":"            if kp:"},{"line_number":51,"context_line":"                LOG.debug(\"Pod has completed execution, removing the vifs\")"},{"line_number":52,"context_line":"                self.on_finalize(pod)"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                LOG.debug(\"Pod has completed execution, no KuryrPort found.\""},{"line_number":55,"context_line":"                          \" Skipping\")"},{"line_number":56,"context_line":"            return"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if not self._is_pod_scheduled(pod):"},{"line_number":59,"context_line":"            # REVISIT(ivc): consider an additional configurable check that"}],"source_content_type":"text/x-python","patch_set":2,"id":"023f3da4_2689c0dd","line":56,"range":{"start_line":48,"start_character":0,"end_line":56,"end_character":18},"updated":"2021-10-06 10:45:35.000000000","message":"Do we really need to check for KuryrPort existence? How about we just trigger `on_finalize()` regardless and will let it decide what to do?\n\nOne advantage of that would be that even though there\u0027s no KuryrPort we\u0027ll still remove the finalizer from the pod as technically we should - we don\u0027t care about this pod anymore, we\u0027ve already cleaned up the Neutron port.","commit_id":"dfb865786eb59f77b697755ef035cccc99ee93bb"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"883bd7b008e06651965009d499f062890928bd12","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            return"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        k8s \u003d clients.get_kubernetes_client()"},{"line_number":48,"context_line":"        kp \u003d driver_utils.get_kuryrport(pod)"},{"line_number":49,"context_line":"        if utils.is_pod_completed(pod):"},{"line_number":50,"context_line":"            if kp:"},{"line_number":51,"context_line":"                LOG.debug(\"Pod has completed execution, removing the vifs\")"},{"line_number":52,"context_line":"                self.on_finalize(pod)"},{"line_number":53,"context_line":"            else:"},{"line_number":54,"context_line":"                LOG.debug(\"Pod has completed execution, no KuryrPort found.\""},{"line_number":55,"context_line":"                          \" Skipping\")"},{"line_number":56,"context_line":"            return"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if not self._is_pod_scheduled(pod):"},{"line_number":59,"context_line":"            # REVISIT(ivc): consider an additional configurable check that"}],"source_content_type":"text/x-python","patch_set":2,"id":"84cfcaf4_690ca99e","line":56,"range":{"start_line":48,"start_character":0,"end_line":56,"end_character":18},"in_reply_to":"023f3da4_2689c0dd","updated":"2021-10-06 10:57:48.000000000","message":"Indeed, gonna give it a try","commit_id":"dfb865786eb59f77b697755ef035cccc99ee93bb"}]}