)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"3fbfc95f30a2feaf9cd0b74b493ec9c1b56c0469","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6a50231_1be84b52","updated":"2021-10-20 07:02:18.000000000","message":"I\u0027d love to see some tests covering this change.","commit_id":"76c11bb3f9a80fac1259b1cbbe880c2e4a4d8cd9"}],"kuryr_kubernetes/controller/drivers/lbaasv2.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c3b5e9f2c0950b4ddfa78a222c63709d06a21b93","unresolved":true,"context_lines":[{"line_number":386,"context_line":"                            \"attempting to recreate it\", loadbalancer[\u0027id\u0027],"},{"line_number":387,"context_line":"                            loadbalancer[\u0027name\u0027])"},{"line_number":388,"context_line":"                utils.clean_lb_crd_status(loadbalancer[\u0027name\u0027])"},{"line_number":389,"context_line":"                raise k_exc.LoadBalancerRemoved(loadbalancer, \"DELETED\")"},{"line_number":390,"context_line":"            else:"},{"line_number":391,"context_line":"                LOG.info(\"Listener creation failed, most probably because \""},{"line_number":392,"context_line":"                         \"protocol %s is not supported\", protocol)"}],"source_content_type":"text/x-python","patch_set":1,"id":"61a97ed5_8d2698ee","line":389,"range":{"start_line":389,"start_character":0,"end_line":389,"end_character":72},"updated":"2021-10-21 16:49:23.000000000","message":"What\u0027s the point of raising this if isn\u0027t not caught anywhere? It\u0027ll probably end up derailing the handler. In OpenShift 3.11 version of this patch the point was to stop execution immediately, but the handler got to catch this.","commit_id":"76c11bb3f9a80fac1259b1cbbe880c2e4a4d8cd9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c3b5e9f2c0950b4ddfa78a222c63709d06a21b93","unresolved":true,"context_lines":[{"line_number":379,"context_line":"            result \u003d self._ensure_provisioned("},{"line_number":380,"context_line":"                loadbalancer, listener, self._create_listener,"},{"line_number":381,"context_line":"                self._find_listener, interval\u003d_LB_STS_POLL_SLOW_INTERVAL)"},{"line_number":382,"context_line":"        except os_exc.HttpException as e:"},{"line_number":383,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":384,"context_line":"                # The LB must be gone."},{"line_number":385,"context_line":"                LOG.warning(\"Loadbalancer %s for Service %s doesn\u0027t exist, \""},{"line_number":386,"context_line":"                            \"attempting to recreate it\", loadbalancer[\u0027id\u0027],"},{"line_number":387,"context_line":"                            loadbalancer[\u0027name\u0027])"},{"line_number":388,"context_line":"                utils.clean_lb_crd_status(loadbalancer[\u0027name\u0027])"},{"line_number":389,"context_line":"                raise k_exc.LoadBalancerRemoved(loadbalancer, \"DELETED\")"},{"line_number":390,"context_line":"            else:"},{"line_number":391,"context_line":"                LOG.info(\"Listener creation failed, most probably because \""},{"line_number":392,"context_line":"                         \"protocol %s is not supported\", protocol)"},{"line_number":393,"context_line":"                return None"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        # NOTE(maysams): When ovn-octavia provider is used"},{"line_number":396,"context_line":"        # there is no need to set a security group for"}],"source_content_type":"text/x-python","patch_set":1,"id":"61ef8656_310daaaf","line":393,"range":{"start_line":382,"start_character":0,"end_line":393,"end_character":27},"updated":"2021-10-21 16:49:23.000000000","message":"Wouldn\u0027t something like this be better? I realize I did it differently in a different patch, but it seems cleaner this way. Same goes for other places\n\n except os_exc.ResourceNotFound:\n     # The LB must be gone.\n     LOG.warning(\"Loadbalancer %s for Service %s doesn\u0027t exist, \"\n                 \"attempting to recreate it\", loadbalancer[\u0027id\u0027],\n                 loadbalancer[\u0027name\u0027])\n     utils.clean_lb_crd_status(loadbalancer[\u0027name\u0027])\n     raise k_exc.LoadBalancerRemoved(loadbalancer, \"DELETED\")\n except SDKException:\n     LOG.info(\"Listener creation failed, most probably because \"\n              \"protocol %s is not supported\", protocol)\n     return None","commit_id":"76c11bb3f9a80fac1259b1cbbe880c2e4a4d8cd9"}]}