)]}'
{"devstack/lib/kuryr_kubernetes":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4a04de2826641575f7819cfbb6628b1fd254795a","unresolved":true,"context_lines":[{"line_number":431,"context_line":"  - network-attachment-definitions"},{"line_number":432,"context_line":"  verbs:"},{"line_number":433,"context_line":"  - get"},{"line_number":434,"context_line":"- apiGroups: [\"\", \"events.k8s.io\"]"},{"line_number":435,"context_line":"  resources:"},{"line_number":436,"context_line":"  - events"},{"line_number":437,"context_line":"  verbs:"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"694d954e_476aa690","line":434,"range":{"start_line":434,"start_character":14,"end_line":434,"end_character":16},"updated":"2021-10-19 09:38:40.000000000","message":"Why is this required?","commit_id":"455bafb6a3a92806f678f27790c41a1c5626b19f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"0cd36b3a41525ef93e3d539e65a824729231c402","unresolved":true,"context_lines":[{"line_number":431,"context_line":"  - network-attachment-definitions"},{"line_number":432,"context_line":"  verbs:"},{"line_number":433,"context_line":"  - get"},{"line_number":434,"context_line":"- apiGroups: [\"\", \"events.k8s.io\"]"},{"line_number":435,"context_line":"  resources:"},{"line_number":436,"context_line":"  - events"},{"line_number":437,"context_line":"  verbs:"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"cdf96aff_c557d1cc","line":434,"range":{"start_line":434,"start_character":14,"end_line":434,"end_character":16},"in_reply_to":"694d954e_476aa690","updated":"2021-10-19 09:42:35.000000000","message":"To allow creation of events. Otherwise we would get:\n\n \"Neutron security groups update has been triggered\" and type: \"Normal\": kuryr_kubernetes.exceptions.K8sForbidden: Forbidden: \u0027{\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Fail\nure\",\"message\":\"events is forbidden: User \\\\\"system:serviceaccount:kube-system:kuryr-controller\\\\\" cannot create resource \\\\\"events\\\\\" in API group \\\\\"\\\\\" in the namespace \\\\\"opa\\\\\"\",\"reason\n\":\"Forbidden\",\"details\":{\"kind\":\"events\"},\"code\":403}\\n\u0027","commit_id":"455bafb6a3a92806f678f27790c41a1c5626b19f"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e2c1fa65c230c4ac1723ec327b3b862d8e2c1958","unresolved":true,"context_lines":[{"line_number":431,"context_line":"  - network-attachment-definitions"},{"line_number":432,"context_line":"  verbs:"},{"line_number":433,"context_line":"  - get"},{"line_number":434,"context_line":"- apiGroups: [\"\", \"events.k8s.io\"]"},{"line_number":435,"context_line":"  resources:"},{"line_number":436,"context_line":"  - events"},{"line_number":437,"context_line":"  verbs:"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"eb932c04_f996701b","line":434,"range":{"start_line":434,"start_character":14,"end_line":434,"end_character":16},"in_reply_to":"6f376f1b_6124d99a","updated":"2021-10-19 10:14:36.000000000","message":"Ah okay, I thought both should be supported just as was done with other SDNs[1]. We can allow only events.k8s.io then as it seems supported on OCP 4.10. What do you think?\n\n[1] https://github.com/openshift/cluster-network-operator/commit/0daa1864cce3ee43a0309ec335acf76420a6a1b4","commit_id":"455bafb6a3a92806f678f27790c41a1c5626b19f"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"bc60e42dd6021582efdd3bbc5786e575eb867485","unresolved":true,"context_lines":[{"line_number":431,"context_line":"  - network-attachment-definitions"},{"line_number":432,"context_line":"  verbs:"},{"line_number":433,"context_line":"  - get"},{"line_number":434,"context_line":"- apiGroups: [\"\", \"events.k8s.io\"]"},{"line_number":435,"context_line":"  resources:"},{"line_number":436,"context_line":"  - events"},{"line_number":437,"context_line":"  verbs:"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf2e50f9_21b41ef0","line":434,"range":{"start_line":434,"start_character":14,"end_line":434,"end_character":16},"in_reply_to":"6f376f1b_6124d99a","updated":"2021-10-19 10:16:56.000000000","message":"Okay, looks like it\u0027s somehow weird but events are more core than events.k8s.io. Let\u0027s leave it as it is.","commit_id":"455bafb6a3a92806f678f27790c41a1c5626b19f"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5792698da0915deecc59383985d9f2b2b557c948","unresolved":true,"context_lines":[{"line_number":431,"context_line":"  - network-attachment-definitions"},{"line_number":432,"context_line":"  verbs:"},{"line_number":433,"context_line":"  - get"},{"line_number":434,"context_line":"- apiGroups: [\"\", \"events.k8s.io\"]"},{"line_number":435,"context_line":"  resources:"},{"line_number":436,"context_line":"  - events"},{"line_number":437,"context_line":"  verbs:"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"6f376f1b_6124d99a","line":434,"range":{"start_line":434,"start_character":14,"end_line":434,"end_character":16},"in_reply_to":"cdf96aff_c557d1cc","updated":"2021-10-19 10:07:20.000000000","message":"I specifically meant the empty API group. Seems like events are now in events.k8s.io only [1], and they\u0027re deprecated in core [2]? Obviously that\u0027s a problem with Roman\u0027s patch that it creates it in the core API group.\n\n[1] https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#event-v1-events-k8s-io\n[2] https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#event-v1-core","commit_id":"455bafb6a3a92806f678f27790c41a1c5626b19f"}]}