)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6d25895b8bc60effaf7d7b46f7095423cb53712c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd3ac166_85d2dcc9","updated":"2021-10-29 07:22:51.000000000","message":"Overall looks good, just one suggestion.","commit_id":"046c6dd3a3739ae5d640e504c279c28e85e0ae7f"}],"kuryr_kubernetes/controller/drivers/utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"bc955191cd04509e2a17646eb75ed9951b38daef","unresolved":true,"context_lines":[{"line_number":714,"context_line":"                trunk_id).get(\"sub_ports\", [])"},{"line_number":715,"context_line":"            for subport in subports:"},{"line_number":716,"context_line":"                if subport.get(\"port_id\") \u003d\u003d leftover_port.id:"},{"line_number":717,"context_line":"                    release_vlan_id(subport[\"segmentation_id\"])"},{"line_number":718,"context_line":"            try:"},{"line_number":719,"context_line":"                os_net.delete_port(leftover_port.id)"},{"line_number":720,"context_line":"            except os_exc.SDKException:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dcf441fa_e00cfba8","line":717,"range":{"start_line":717,"start_character":0,"end_line":717,"end_character":63},"updated":"2021-11-09 14:22:16.000000000","message":"Couldn\u0027t we just move this to the place we\u0027re calling delete_port from? I bet that\u0027s in vif_pool driver, isn\u0027t it?","commit_id":"046c6dd3a3739ae5d640e504c279c28e85e0ae7f"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"6d25895b8bc60effaf7d7b46f7095423cb53712c","unresolved":true,"context_lines":[{"line_number":700,"context_line":"                            \"not happen. Trying to delete it from \""},{"line_number":701,"context_line":"                            \"the trunk.\", leftover_port.id)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"            # Get the trunk_id from the error message"},{"line_number":704,"context_line":"            trunk_id \u003d ("},{"line_number":705,"context_line":"                str(e).split(\u0027trunk\u0027)[1].split(\u0027.\u0027)[0].strip())"},{"line_number":706,"context_line":"            try:"},{"line_number":707,"context_line":"                os_net.delete_trunk_subports("},{"line_number":708,"context_line":"                    trunk_id, [{\u0027port_id\u0027: leftover_port.id}])"},{"line_number":709,"context_line":"            except os_exc.ResourceNotFound:"},{"line_number":710,"context_line":"                LOG.debug("},{"line_number":711,"context_line":"                    \"Port %s already removed from trunk %s\","},{"line_number":712,"context_line":"                    leftover_port.id, trunk_id)"},{"line_number":713,"context_line":"            subports \u003d os_net.get_trunk_subports("},{"line_number":714,"context_line":"                trunk_id).get(\"sub_ports\", [])"},{"line_number":715,"context_line":"            for subport in subports:"},{"line_number":716,"context_line":"                if subport.get(\"port_id\") \u003d\u003d leftover_port.id:"},{"line_number":717,"context_line":"                    release_vlan_id(subport[\"segmentation_id\"])"},{"line_number":718,"context_line":"            try:"},{"line_number":719,"context_line":"                os_net.delete_port(leftover_port.id)"},{"line_number":720,"context_line":"            except os_exc.SDKException:"}],"source_content_type":"text/x-python","patch_set":3,"id":"cc63a564_964946d4","line":717,"range":{"start_line":703,"start_character":0,"end_line":717,"end_character":63},"updated":"2021-10-29 07:22:51.000000000","message":"I\u0027d extract this block to a method, so it would be easier to test without creating single-lined function like that on line 732.","commit_id":"046c6dd3a3739ae5d640e504c279c28e85e0ae7f"}]}