)]}'
{"kuryr_kubernetes/controller/drivers/nested_vlan_vif.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d5651e9a2f1ffe808d4e3810e0d15d8fb8d55580","unresolved":true,"context_lines":[{"line_number":137,"context_line":"                            trunk_id, vif.vlan_id)"},{"line_number":138,"context_line":"                try:"},{"line_number":139,"context_line":"                    self._remove_subport(trunk_id, vif.id)"},{"line_number":140,"context_line":"                except (os_exc.NotFoundException, os_exc.ResourceNotFound):"},{"line_number":141,"context_line":"                    # NOTE(dulek): This may happen when _add_subport() failed"},{"line_number":142,"context_line":"                    #              or Kuryr crashed between the calls. Let\u0027s"},{"line_number":143,"context_line":"                    #              try to fix it hoping that VLAN ID is still"}],"source_content_type":"text/x-python","patch_set":2,"id":"043f08f8_333d183d","line":140,"range":{"start_line":140,"start_character":23,"end_line":140,"end_character":74},"updated":"2021-11-19 13:49:20.000000000","message":"You\u0027re sure this is required? It shouldn\u0027t even for older openstacksdk [1].\n\n[1] https://github.com/openstack/openstacksdk/blob/0.36.5/openstack/exceptions.py#L148","commit_id":"3c7806bb3cba6a351a0f2883e7b6af649b62373e"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e63a703a8b32dd4b18143cbac11bce5506a2295d","unresolved":true,"context_lines":[{"line_number":137,"context_line":"                            trunk_id, vif.vlan_id)"},{"line_number":138,"context_line":"                try:"},{"line_number":139,"context_line":"                    self._remove_subport(trunk_id, vif.id)"},{"line_number":140,"context_line":"                except (os_exc.NotFoundException, os_exc.ResourceNotFound):"},{"line_number":141,"context_line":"                    # NOTE(dulek): This may happen when _add_subport() failed"},{"line_number":142,"context_line":"                    #              or Kuryr crashed between the calls. Let\u0027s"},{"line_number":143,"context_line":"                    #              try to fix it hoping that VLAN ID is still"}],"source_content_type":"text/x-python","patch_set":2,"id":"181975c3_5c05e1c5","line":140,"range":{"start_line":140,"start_character":23,"end_line":140,"end_character":74},"in_reply_to":"043f08f8_333d183d","updated":"2021-11-22 13:58:36.000000000","message":"The version of openstacksdk used was 0.59.0, which raises the same ResourceNotFound[0] as in the older release, since we are raising from response[1]\n[0]https://github.com/openstack/openstacksdk/blob/0.59.0/openstack/exceptions.py#L147-L152\n[1] https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/clients.py#L135","commit_id":"3c7806bb3cba6a351a0f2883e7b6af649b62373e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"89c20fb7529dd9ab931b5d29d45fd273a180cd1e","unresolved":true,"context_lines":[{"line_number":137,"context_line":"                            trunk_id, vif.vlan_id)"},{"line_number":138,"context_line":"                try:"},{"line_number":139,"context_line":"                    self._remove_subport(trunk_id, vif.id)"},{"line_number":140,"context_line":"                except (os_exc.NotFoundException, os_exc.ResourceNotFound):"},{"line_number":141,"context_line":"                    # NOTE(dulek): This may happen when _add_subport() failed"},{"line_number":142,"context_line":"                    #              or Kuryr crashed between the calls. Let\u0027s"},{"line_number":143,"context_line":"                    #              try to fix it hoping that VLAN ID is still"}],"source_content_type":"text/x-python","patch_set":2,"id":"7e8d03ce_5e130d06","line":140,"range":{"start_line":140,"start_character":23,"end_line":140,"end_character":74},"in_reply_to":"181975c3_5c05e1c5","updated":"2021-11-30 16:13:42.000000000","message":"That\u0027s the point, NotFoundException should be equal to ResourceNotFound, so no need to include both.","commit_id":"3c7806bb3cba6a351a0f2883e7b6af649b62373e"}]}