)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e926bbe1ba066e76f5c6c6717aab37b44fc2871e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e071c6f6_19a55424","updated":"2021-12-10 00:25:39.000000000","message":"looks good, just one minor remark:","commit_id":"4b98b330322cf94b2f20454809101980394410b6"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b1cec7a82c0e2ab61547fcf0987e391d2ea7c805","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98c6235d_06b2b4f4","updated":"2021-12-08 14:19:48.000000000","message":"recheck","commit_id":"4b98b330322cf94b2f20454809101980394410b6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f605f949cd00766a1f8321c732184ee62a4de239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4481eee0_749418e4","updated":"2021-12-13 16:08:22.000000000","message":"recheck","commit_id":"534ab3d66007b5ea7d9bdadb6eda82309b948ece"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8e93c5b0c4dbcdea74e94be3582b9b72127dd65a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc3c0696_f6fb7144","updated":"2021-12-13 12:42:10.000000000","message":"recheck","commit_id":"534ab3d66007b5ea7d9bdadb6eda82309b948ece"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8b80d46aabca2324808a476c0e450173290e80f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"84c7be60_00b173fd","updated":"2022-04-05 16:53:55.000000000","message":"LGTM. There are just two minor issues:","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c95ce7d50e9bdfb7b0865b0c4666b7c1257163c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0489ba02_161c5dc0","updated":"2022-04-05 13:40:56.000000000","message":"Looks ready for reviews after the rebase.","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"282c3ff7a55304366a738115a26dab13e12858f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"622b31b7_f7960b2c","updated":"2022-04-05 09:51:41.000000000","message":"recheck","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b64e5cb1e346ead2554d4c7026220c2498a03d1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f255373_938a934a","updated":"2022-03-30 08:22:06.000000000","message":"recheck\n\nDo we even run with port pools in the CI…?","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"78ceecc91e705ee6c78eeb5916d0f5ece6dc6e1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91851d17_2fe1c9cb","in_reply_to":"3f255373_938a934a","updated":"2022-04-05 09:52:04.000000000","message":"I think it\u0027s only for the experimental gates","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"6dae89e12d82088f4fa9742e30b51e44e1eecd26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"925105ef_a1258aee","updated":"2022-04-06 10:47:51.000000000","message":"@dulek It might be handy to have an upstream bug for this one","commit_id":"ee3c26542f4e4d1c20b9a7bdd653bd62193c1622"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"61093129b1e0c4037a4b24d5ada6199e9b2da47c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a2507553_4df8e3f6","updated":"2022-04-08 14:37:46.000000000","message":"Alright, this worked. I\u0027ll skip bug creation, this isn\u0027t really user-facing at all.","commit_id":"ee3c26542f4e4d1c20b9a7bdd653bd62193c1622"}],"kuryr_kubernetes/controller/drivers/vif_pool.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"e926bbe1ba066e76f5c6c6717aab37b44fc2871e","unresolved":true,"context_lines":[{"line_number":703,"context_line":"                self._available_ports_pools[pool_key].setdefault("},{"line_number":704,"context_line":"                        sg, []).append(port_id)"},{"line_number":705,"context_line":"                # Move it to the end of ports to update the SG."},{"line_number":706,"context_line":"                self._available_ports_pools[pool_key].move_to_end(sg)"},{"line_number":707,"context_line":"            else:"},{"line_number":708,"context_line":"                try:"},{"line_number":709,"context_line":"                    del self._existing_vifs[port_id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"d912a7a8_796084df","line":706,"updated":"2021-12-10 00:25:39.000000000","message":"It seems we\u0027re missing to del the self._available_ports_pools correctly at line 1137 as I got the following when trying it with my patch:\n\nAttributeError: \u0027dict\u0027 object has no attribute \u0027move_to_end\u0027","commit_id":"4b98b330322cf94b2f20454809101980394410b6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1ffaa811a2bd9f883a6679e833be0a9d8b117b01","unresolved":false,"context_lines":[{"line_number":703,"context_line":"                self._available_ports_pools[pool_key].setdefault("},{"line_number":704,"context_line":"                        sg, []).append(port_id)"},{"line_number":705,"context_line":"                # Move it to the end of ports to update the SG."},{"line_number":706,"context_line":"                self._available_ports_pools[pool_key].move_to_end(sg)"},{"line_number":707,"context_line":"            else:"},{"line_number":708,"context_line":"                try:"},{"line_number":709,"context_line":"                    del self._existing_vifs[port_id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5d1c9c7a_b6b3174f","line":706,"in_reply_to":"c271cb16_105b6bbc","updated":"2022-04-06 08:16:41.000000000","message":"Done","commit_id":"4b98b330322cf94b2f20454809101980394410b6"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7b5124563c1b04888732e30241e172b3b0bdf0c5","unresolved":true,"context_lines":[{"line_number":703,"context_line":"                self._available_ports_pools[pool_key].setdefault("},{"line_number":704,"context_line":"                        sg, []).append(port_id)"},{"line_number":705,"context_line":"                # Move it to the end of ports to update the SG."},{"line_number":706,"context_line":"                self._available_ports_pools[pool_key].move_to_end(sg)"},{"line_number":707,"context_line":"            else:"},{"line_number":708,"context_line":"                try:"},{"line_number":709,"context_line":"                    del self._existing_vifs[port_id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"c271cb16_105b6bbc","line":706,"in_reply_to":"d912a7a8_796084df","updated":"2021-12-10 18:15:40.000000000","message":"Ouch, nice catch, thank you!","commit_id":"4b98b330322cf94b2f20454809101980394410b6"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8b80d46aabca2324808a476c0e450173290e80f1","unresolved":true,"context_lines":[{"line_number":308,"context_line":"                                security_groups, []).append(vif.id)"},{"line_number":309,"context_line":"                    if vifs:"},{"line_number":310,"context_line":"                        # Mark it as updated most recently."},{"line_number":311,"context_line":"                        print(self._available_ports_pools)"},{"line_number":312,"context_line":"                        self._available_ports_pools[pool_key].move_to_end("},{"line_number":313,"context_line":"                            security_groups)"},{"line_number":314,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"315ce71b_c1d6a20e","line":311,"range":{"start_line":311,"start_character":24,"end_line":311,"end_character":58},"updated":"2022-04-05 16:53:55.000000000","message":"leftover?","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1ffaa811a2bd9f883a6679e833be0a9d8b117b01","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                                security_groups, []).append(vif.id)"},{"line_number":309,"context_line":"                    if vifs:"},{"line_number":310,"context_line":"                        # Mark it as updated most recently."},{"line_number":311,"context_line":"                        print(self._available_ports_pools)"},{"line_number":312,"context_line":"                        self._available_ports_pools[pool_key].move_to_end("},{"line_number":313,"context_line":"                            security_groups)"},{"line_number":314,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"05cd3093_4f2b0b7b","line":311,"range":{"start_line":311,"start_character":24,"end_line":311,"end_character":58},"in_reply_to":"315ce71b_c1d6a20e","updated":"2022-04-06 08:16:41.000000000","message":"Ack","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8b80d46aabca2324808a476c0e450173290e80f1","unresolved":true,"context_lines":[{"line_number":413,"context_line":"        except OSError:"},{"line_number":414,"context_line":"            pass"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        self.available_ports_pools \u003d collections.defaultdict("},{"line_number":417,"context_line":"            collections.OrderedDict)"},{"line_number":418,"context_line":"        self._existing_vifs \u003d collections.defaultdict()"},{"line_number":419,"context_line":"        self._recyclable_ports \u003d collections.defaultdict()"}],"source_content_type":"text/x-python","patch_set":4,"id":"8fe3f146_5b6f9fd7","line":416,"updated":"2022-04-05 16:53:55.000000000","message":"why is this not private anymore?","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1ffaa811a2bd9f883a6679e833be0a9d8b117b01","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        except OSError:"},{"line_number":414,"context_line":"            pass"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        self.available_ports_pools \u003d collections.defaultdict("},{"line_number":417,"context_line":"            collections.OrderedDict)"},{"line_number":418,"context_line":"        self._existing_vifs \u003d collections.defaultdict()"},{"line_number":419,"context_line":"        self._recyclable_ports \u003d collections.defaultdict()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff93676d_df1bd314","line":416,"in_reply_to":"8fe3f146_5b6f9fd7","updated":"2022-04-06 08:16:41.000000000","message":"Uh, oh. Okay, I\u0027ll better run some more tests on this.","commit_id":"66888639e47964482c0305d40f2dfb850a0a4709"}]}