)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c6526bc1629a656c50a4a72715452e20bab11187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d68f7cc_0afbef63","updated":"2022-01-19 17:29:20.000000000","message":"Let\u0027s see if this even works.","commit_id":"5e0cb436008db45e95eaf1261cddb40471609495"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a3df7df3241a59432d92bfbf09423f9bff2911ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09e5328d_a8e20a0c","updated":"2022-01-20 09:25:34.000000000","message":"Okay, it\u0027s better than I thought, only Docker\u0027s broken.","commit_id":"5e0cb436008db45e95eaf1261cddb40471609495"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4535afcdef64f6bcd3aa1aaff8fdbd6978863066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea1a57fd_8d8eab5a","updated":"2022-01-20 16:35:15.000000000","message":"recheck\n\nThe KuryrPorts are actually missing, which is weird.","commit_id":"c27a695c1c4cf99837748fcdc76494ad1cbd7906"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1dece5e26a8ea79666f0ec03ffb14f99b30743b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ae5207aa_74c1b75e","updated":"2022-01-24 10:16:47.000000000","message":"recheck\n\nSeems unrelated, some new NP bug.","commit_id":"0a1125d4ea877329ac00d704710a7ab70f294f15"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"da3e4f6491a9367edeeb411bfd0a1bedd7a15cfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9deb8bb7_70a288d0","updated":"2022-03-04 15:04:39.000000000","message":"recheck\n\nNothing unusual…","commit_id":"45410fd4595eeca6c77e4346e1fc488a1a43b6ff"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"3b92861a081e46a94f4e72c4896ffa67151ac83a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1581dca5_dbaf514e","updated":"2022-03-29 14:29:44.000000000","message":"LGTM, also I\u0027m curious for the answer for Maysa question.","commit_id":"d5f5db7005028f9ba88ed9dcc0b5d09d0bbd8bda"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"78378076991d24d87441891244cdc22e3b35e521","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"86bec441_dd7f21c7","updated":"2022-03-29 13:58:23.000000000","message":"LGTM. Just have one minor question:","commit_id":"d5f5db7005028f9ba88ed9dcc0b5d09d0bbd8bda"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"061c3def6949f068e82c1e34728555de81ed87e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2842c34e_3a8fc8fa","updated":"2022-03-30 08:32:10.000000000","message":"Ok, that\u0027s fair enough for me.","commit_id":"d5f5db7005028f9ba88ed9dcc0b5d09d0bbd8bda"}],"kuryr_kubernetes/cni/binding/base.py":[{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"0ab6b96677b78f43c3998d20f6340e7670fcf8fb","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                    iface.remove()"},{"line_number":184,"context_line":"    except Exception:"},{"line_number":185,"context_line":"        # Just ignore cleanup errors, there\u0027s not much we can do anyway."},{"line_number":186,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"c9550606_3261eccf","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":12},"updated":"2022-03-08 02:59:05.000000000","message":"In my opinion, we can add warn or exception log here.","commit_id":"169ac487673d04b7a4d2c53e6f565c60e0aa31e3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7bf55da1607001d3f6ba5cdea368733403207bcf","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                    iface.remove()"},{"line_number":184,"context_line":"    except Exception:"},{"line_number":185,"context_line":"        # Just ignore cleanup errors, there\u0027s not much we can do anyway."},{"line_number":186,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"606ea702_3189a57e","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":12},"in_reply_to":"c9550606_3261eccf","updated":"2022-03-29 16:15:05.000000000","message":"Ack","commit_id":"169ac487673d04b7a4d2c53e6f565c60e0aa31e3"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"78378076991d24d87441891244cdc22e3b35e521","unresolved":true,"context_lines":[{"line_number":182,"context_line":"                with c_ipdb.interfaces[ifname] as iface:"},{"line_number":183,"context_line":"                    iface.remove()"},{"line_number":184,"context_line":"    except Exception:"},{"line_number":185,"context_line":"        # Just ignore cleanup errors, there\u0027s not much we can do anyway."},{"line_number":186,"context_line":"        LOG.warning(\u0027Error occured when attempting to clean up netns %s. \u0027"},{"line_number":187,"context_line":"                    \u0027Ignoring.\u0027, netns)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3d26d8af_922911be","line":187,"range":{"start_line":185,"start_character":7,"end_line":187,"end_character":39},"updated":"2022-03-29 13:58:23.000000000","message":"should it be retried to avoid VLAN ID conflicts?","commit_id":"d5f5db7005028f9ba88ed9dcc0b5d09d0bbd8bda"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7bf55da1607001d3f6ba5cdea368733403207bcf","unresolved":true,"context_lines":[{"line_number":182,"context_line":"                with c_ipdb.interfaces[ifname] as iface:"},{"line_number":183,"context_line":"                    iface.remove()"},{"line_number":184,"context_line":"    except Exception:"},{"line_number":185,"context_line":"        # Just ignore cleanup errors, there\u0027s not much we can do anyway."},{"line_number":186,"context_line":"        LOG.warning(\u0027Error occured when attempting to clean up netns %s. \u0027"},{"line_number":187,"context_line":"                    \u0027Ignoring.\u0027, netns)"}],"source_content_type":"text/x-python","patch_set":10,"id":"04d65a89_8a2f3b6b","line":187,"range":{"start_line":185,"start_character":7,"end_line":187,"end_character":39},"in_reply_to":"3d26d8af_922911be","updated":"2022-03-29 16:15:05.000000000","message":"I would say no, if we have a VLAN ID conflict, we have a bruteforce at [1] to deal with it. And that approach will be retried each time CNI request fails.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/1c2cd789662b447c199b1ff1ec47313b32e833d1/kuryr_kubernetes/cni/binding/nested.py#L171","commit_id":"d5f5db7005028f9ba88ed9dcc0b5d09d0bbd8bda"}],"kuryr_kubernetes/cni/plugins/k8s_cni_registry.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"c7fe3072f4c3a297e8f50964240b0b40a21fb22c","unresolved":true,"context_lines":[{"line_number":190,"context_line":"            #               the field set and the performance penalty should"},{"line_number":191,"context_line":"            #               be resolved. Remove in the future."},{"line_number":192,"context_line":"            if \u0027K8S_POD_UID\u0027 in params.args and uid !\u003d params.args.K8S_POD_UID:"},{"line_number":193,"context_line":"                if static is None:"},{"line_number":194,"context_line":"                    pod \u003d self._get_pod(params)"},{"line_number":195,"context_line":"                    static \u003d k_utils.is_pod_static(pod)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"                if not static:"},{"line_number":198,"context_line":"                    raise exceptions.CNIPodUidMismatch("},{"line_number":199,"context_line":"                        kp_name, params.args.K8S_POD_UID, uid)"},{"line_number":200,"context_line":"            return d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"d6f68ee8_dd998cc8","line":199,"range":{"start_line":193,"start_character":0,"end_line":199,"end_character":62},"updated":"2022-03-07 13:55:34.000000000","message":"Is there a bug for the static pods UID issue somewhere?\nmaybe it can be linked here as a NOTE","commit_id":"45410fd4595eeca6c77e4346e1fc488a1a43b6ff"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0ced4d52f652701980a9e83f5cdcf40a83ddc24e","unresolved":true,"context_lines":[{"line_number":190,"context_line":"            #               the field set and the performance penalty should"},{"line_number":191,"context_line":"            #               be resolved. Remove in the future."},{"line_number":192,"context_line":"            if \u0027K8S_POD_UID\u0027 in params.args and uid !\u003d params.args.K8S_POD_UID:"},{"line_number":193,"context_line":"                if static is None:"},{"line_number":194,"context_line":"                    pod \u003d self._get_pod(params)"},{"line_number":195,"context_line":"                    static \u003d k_utils.is_pod_static(pod)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"                if not static:"},{"line_number":198,"context_line":"                    raise exceptions.CNIPodUidMismatch("},{"line_number":199,"context_line":"                        kp_name, params.args.K8S_POD_UID, uid)"},{"line_number":200,"context_line":"            return d"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0fd1ae3d_4b4e6c28","line":199,"range":{"start_line":193,"start_character":0,"end_line":199,"end_character":62},"in_reply_to":"d6f68ee8_dd998cc8","updated":"2022-03-07 17:10:49.000000000","message":"There is, but it\u0027s for other SDNs, not that much related to Kuryr. I\u0027ll just add a comment.","commit_id":"45410fd4595eeca6c77e4346e1fc488a1a43b6ff"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"51fbd400ffd0a894757f383e6b872041d6fd0b4a","unresolved":true,"context_lines":[{"line_number":59,"context_line":"                f\u0027{k_const.K8S_API_NAMESPACES}/{namespace}/pods/{name}\u0027)"},{"line_number":60,"context_line":"        except exceptions.K8sClientException:"},{"line_number":61,"context_line":"            uniq_name \u003d self._get_obj_name(params)"},{"line_number":62,"context_line":"            LOG.exception(\u0027Error when getting KuryrPort %s\u0027, uniq_name)"},{"line_number":63,"context_line":"            raise"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def add(self, params):"}],"source_content_type":"text/x-python","patch_set":9,"id":"e3180f22_b3ddf4e1","line":62,"range":{"start_line":62,"start_character":46,"end_line":62,"end_character":56},"updated":"2022-03-08 09:34:03.000000000","message":"s/Pod","commit_id":"169ac487673d04b7a4d2c53e6f565c60e0aa31e3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"3b92861a081e46a94f4e72c4896ffa67151ac83a","unresolved":true,"context_lines":[{"line_number":178,"context_line":"                        retry_on_exception\u003dlambda e: isinstance("},{"line_number":179,"context_line":"                            e, (KeyError, exceptions.CNIPodUidMismatch)))"},{"line_number":180,"context_line":"        def find():"},{"line_number":181,"context_line":"            d \u003d self.registry[kp_name]"},{"line_number":182,"context_line":"            static \u003d d[\u0027kp\u0027][\u0027spec\u0027].get(\u0027podStatic\u0027, None)"},{"line_number":183,"context_line":"            uid \u003d d[\u0027kp\u0027][\u0027spec\u0027][\u0027podUid\u0027]"},{"line_number":184,"context_line":"            # FIXME(dulek): This is weirdly structured for upgrades support."}],"source_content_type":"text/x-python","patch_set":10,"id":"19339661_e499f710","line":181,"updated":"2022-03-29 14:29:44.000000000","message":"nit: perhaps now is a good time to change the name of variable to something more meaningful?","commit_id":"d5f5db7005028f9ba88ed9dcc0b5d09d0bbd8bda"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7bf55da1607001d3f6ba5cdea368733403207bcf","unresolved":true,"context_lines":[{"line_number":178,"context_line":"                        retry_on_exception\u003dlambda e: isinstance("},{"line_number":179,"context_line":"                            e, (KeyError, exceptions.CNIPodUidMismatch)))"},{"line_number":180,"context_line":"        def find():"},{"line_number":181,"context_line":"            d \u003d self.registry[kp_name]"},{"line_number":182,"context_line":"            static \u003d d[\u0027kp\u0027][\u0027spec\u0027].get(\u0027podStatic\u0027, None)"},{"line_number":183,"context_line":"            uid \u003d d[\u0027kp\u0027][\u0027spec\u0027][\u0027podUid\u0027]"},{"line_number":184,"context_line":"            # FIXME(dulek): This is weirdly structured for upgrades support."}],"source_content_type":"text/x-python","patch_set":10,"id":"e98738e5_1af1c669","line":181,"in_reply_to":"19339661_e499f710","updated":"2022-03-29 16:15:05.000000000","message":"d(ict) was my intention, but sure, I can update it if there\u0027ll be another version of this patch.","commit_id":"d5f5db7005028f9ba88ed9dcc0b5d09d0bbd8bda"}]}