)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"02bbbf1c22e04158e0a7dfa602b98d2cda059070","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"444fb04b_1906c4e7","updated":"2022-04-06 08:07:17.000000000","message":"recheck","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"be8b4c4964851d18d17f400b5f6e332749287475","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ec0f7489_9c6e945c","updated":"2022-03-15 05:47:02.000000000","message":"recheck","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"976c0d7c7a69b8720860a36c62e77e7fa5257252","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0dd2862a_58526008","updated":"2022-04-05 11:37:51.000000000","message":"recheck\n\nI\u0027m not against that, other components are creating many events and these could be helpful, but we need to fix the ones that are not Warnings.","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ed20595a23d817019397ec330c01c5c812418bf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"782b75d5_9537df30","updated":"2022-04-05 15:02:49.000000000","message":"recheck\n\nSCTP tests flake.","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"}],"kuryr_kubernetes/controller/handlers/kuryrport.py":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"db5c3c90b161f5a033babf9cb4badb0abb0b08af","unresolved":true,"context_lines":[{"line_number":121,"context_line":"                    self._update_kuryrport_crd(kuryrport_crd, vifs)"},{"line_number":122,"context_line":"                    self.k8s.add_event(pod, \u0027KuryrPortUpdatedWithActiveVIFs\u0027,"},{"line_number":123,"context_line":"                                       f\u0027KuryrPort CRD: {kp_name} updated with\u0027"},{"line_number":124,"context_line":"                                       f\u0027 active VIFs\u0027, \u0027Warning\u0027)"},{"line_number":125,"context_line":"                except k_exc.K8sResourceNotFound as ex:"},{"line_number":126,"context_line":"                    LOG.exception(\"Failed to update KuryrPort CRD: %s\", ex)"},{"line_number":127,"context_line":"                    security_groups \u003d self._drv_sg.get_security_groups("}],"source_content_type":"text/x-python","patch_set":1,"id":"f7957a6a_b7c30829","line":124,"updated":"2022-03-15 05:45:51.000000000","message":"In case of successful crd update it should be \"Normal\" not \"Warning\". Also, didn\u0027t we agreed, that adding to much events, may create information noise instead being useful?","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"adc3b7bf9597034707908811232f0ba45ec58c11","unresolved":true,"context_lines":[{"line_number":121,"context_line":"                    self._update_kuryrport_crd(kuryrport_crd, vifs)"},{"line_number":122,"context_line":"                    self.k8s.add_event(pod, \u0027KuryrPortUpdatedWithActiveVIFs\u0027,"},{"line_number":123,"context_line":"                                       f\u0027KuryrPort CRD: {kp_name} updated with\u0027"},{"line_number":124,"context_line":"                                       f\u0027 active VIFs\u0027, \u0027Warning\u0027)"},{"line_number":125,"context_line":"                except k_exc.K8sResourceNotFound as ex:"},{"line_number":126,"context_line":"                    LOG.exception(\"Failed to update KuryrPort CRD: %s\", ex)"},{"line_number":127,"context_line":"                    security_groups \u003d self._drv_sg.get_security_groups("}],"source_content_type":"text/x-python","patch_set":1,"id":"68fcbe73_67de0ddc","line":124,"in_reply_to":"6b481b8b_29a043be","updated":"2022-04-06 10:08:03.000000000","message":"Yeah we agreed to not create events on successful scenarios, but there were many weird behavior happening on the tests in the OpenShift CI and as after each run of a test case the Namespace is cleaned up the only way to get data is with events.","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"976c0d7c7a69b8720860a36c62e77e7fa5257252","unresolved":true,"context_lines":[{"line_number":121,"context_line":"                    self._update_kuryrport_crd(kuryrport_crd, vifs)"},{"line_number":122,"context_line":"                    self.k8s.add_event(pod, \u0027KuryrPortUpdatedWithActiveVIFs\u0027,"},{"line_number":123,"context_line":"                                       f\u0027KuryrPort CRD: {kp_name} updated with\u0027"},{"line_number":124,"context_line":"                                       f\u0027 active VIFs\u0027, \u0027Warning\u0027)"},{"line_number":125,"context_line":"                except k_exc.K8sResourceNotFound as ex:"},{"line_number":126,"context_line":"                    LOG.exception(\"Failed to update KuryrPort CRD: %s\", ex)"},{"line_number":127,"context_line":"                    security_groups \u003d self._drv_sg.get_security_groups("}],"source_content_type":"text/x-python","patch_set":1,"id":"6b481b8b_29a043be","line":124,"in_reply_to":"f7957a6a_b7c30829","updated":"2022-04-05 11:37:51.000000000","message":"+1, this is Normal.","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"db5c3c90b161f5a033babf9cb4badb0abb0b08af","unresolved":true,"context_lines":[{"line_number":275,"context_line":"                        \"scheduled yet.\", pod_name)"},{"line_number":276,"context_line":"            self.k8s.add_event(pod, \u0027KuryrIgnoringPodEvent\u0027,"},{"line_number":277,"context_line":"                               f\u0027Ignoring event: Pod not scheduled \u0027"},{"line_number":278,"context_line":"                               f\u0027{pod_name}\u0027, \u0027Warning\u0027)"},{"line_number":279,"context_line":"            return False"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        vifs \u003d {constants.DEFAULT_IFNAME: {\u0027default\u0027: True, \u0027vif\u0027: main_vif}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"300715c4_d62c6560","line":278,"range":{"start_line":278,"start_character":47,"end_line":278,"end_character":54},"updated":"2022-03-15 05:45:51.000000000","message":"Normal?","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"db5c3c90b161f5a033babf9cb4badb0abb0b08af","unresolved":true,"context_lines":[{"line_number":294,"context_line":"            self._update_kuryrport_crd(kuryrport_crd, vifs)"},{"line_number":295,"context_line":"            self.k8s.add_event(pod, \u0027KuryrPortUpdatedWithVIFs\u0027,"},{"line_number":296,"context_line":"                               f\u0027KuryrPort CRD: {pod_name} updated with VIFs\u0027,"},{"line_number":297,"context_line":"                               \u0027Warning\u0027)"},{"line_number":298,"context_line":"        except k_exc.K8sClientException as ex:"},{"line_number":299,"context_line":"            LOG.exception(\"Kubernetes Client Exception creating \""},{"line_number":300,"context_line":"                          \"KuryrPort CRD: %s\", ex)"}],"source_content_type":"text/x-python","patch_set":1,"id":"75413ef4_b69b276a","line":297,"range":{"start_line":297,"start_character":32,"end_line":297,"end_character":39},"updated":"2022-03-15 05:45:51.000000000","message":"ditto.","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"976c0d7c7a69b8720860a36c62e77e7fa5257252","unresolved":true,"context_lines":[{"line_number":345,"context_line":"            return self.k8s.get(f\"{constants.K8S_API_NAMESPACES}\""},{"line_number":346,"context_line":"                                f\"/{namespace}/pods/{name}\")"},{"line_number":347,"context_line":"        except k_exc.K8sResourceNotFound as ex:"},{"line_number":348,"context_line":"            self.k8s.add_event(kuryrport_crd, \u0027KuryrFailedGettingPod\u0027"},{"line_number":349,"context_line":"                               f\u0027Failed to get corresponding pod: {ex}\u0027,"},{"line_number":350,"context_line":"                               \u0027Warning\u0027)"},{"line_number":351,"context_line":"            LOG.exception(\"Failed to get pod: %s\", ex)"},{"line_number":352,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"fc1b3b4e_b534426f","line":350,"range":{"start_line":348,"start_character":0,"end_line":350,"end_character":41},"updated":"2022-04-05 11:37:51.000000000","message":"Oh wow, that\u0027s a bug.","commit_id":"dc4291a8c5542d0c04ef0a3bd377642ba9ab9c5c"}]}