)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e9daa336169119507deff055e812caa4e6970501","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8046be18_c4853f66","updated":"2022-03-24 12:12:10.000000000","message":"Looks good.","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a0e4de5465703958196a9483002438d85f2e3b50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e84ccac_272dd6bc","updated":"2022-03-24 14:35:56.000000000","message":"Oh wait, no, it\u0027s renaming subnets a bit.","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"227eeab66508eb6329b3b84ed0c1e407ee29b731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01bf878b_626b3385","updated":"2022-03-24 14:34:49.000000000","message":"Patch is still okay, but we need to update the tempest plugin, it seems.","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"b4b85d56bca902636e49e4e7e10babaa57f3bfa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e703a22_294483e6","updated":"2022-03-30 08:29:37.000000000","message":"recheck","commit_id":"e76a727cc24772a0a8d25d8344aaaece7fade7f4"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"46dcf1cf39494ad91b5c340f2b1144d17442b1c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75bff0e3_948b590d","updated":"2022-04-07 09:57:49.000000000","message":"Just one minor leftover:","commit_id":"9241b33c8a59beb14fb70541b6b2d12238f9e93d"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"bcdd809061411ccdc4b5be52aca7afa8ec15237a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21620145_69b4c8de","updated":"2022-04-06 16:05:46.000000000","message":"recheck","commit_id":"9241b33c8a59beb14fb70541b6b2d12238f9e93d"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"1df7c5003413179d8ea1d86dfcf1f5a78cd019a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d6c73181_aece36ce","updated":"2022-04-07 08:40:44.000000000","message":"recheck","commit_id":"9241b33c8a59beb14fb70541b6b2d12238f9e93d"}],"kuryr_kubernetes/controller/drivers/namespace_subnet.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d2f62b2836f4b488b3037c88bbb248dde3fa40bb","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def create_network(self, ns_name, project_id):"},{"line_number":121,"context_line":"        os_net \u003d clients.get_network_client()"},{"line_number":122,"context_line":"        net_name \u003d c_utils.get_resource_name(ns_name, prefix\u003d\u0027ns\u0027,"},{"line_number":123,"context_line":"                                             suffix\u003d\u0027net\u0027)"},{"line_number":124,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":125,"context_line":"        if tags:"},{"line_number":126,"context_line":"            networks \u003d os_net.networks(name\u003dnet_name, tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1e14bb3_64d69f62","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":58},"updated":"2022-03-24 14:38:11.000000000","message":"This combines two separators, so it renames it. :/","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"58fb3ea6de4125716f9e03215c5772a08d44d701","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def create_network(self, ns_name, project_id):"},{"line_number":121,"context_line":"        os_net \u003d clients.get_network_client()"},{"line_number":122,"context_line":"        net_name \u003d c_utils.get_resource_name(ns_name, prefix\u003d\u0027ns\u0027,"},{"line_number":123,"context_line":"                                             suffix\u003d\u0027net\u0027)"},{"line_number":124,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":125,"context_line":"        if tags:"},{"line_number":126,"context_line":"            networks \u003d os_net.networks(name\u003dnet_name, tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9db541d5_ebfff655","line":123,"range":{"start_line":122,"start_character":0,"end_line":123,"end_character":58},"in_reply_to":"b1e14bb3_64d69f62","updated":"2022-04-01 11:37:42.000000000","message":"Done","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d2f62b2836f4b488b3037c88bbb248dde3fa40bb","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def create_subnet(self, ns_name, project_id, net_id):"},{"line_number":151,"context_line":"        os_net \u003d clients.get_network_client()"},{"line_number":152,"context_line":"        subnet_name \u003d c_utils.get_resource_name(ns_name, prefix\u003d\u0027ns\u0027,"},{"line_number":153,"context_line":"                                                suffix\u003d\u0027subnet\u0027)"},{"line_number":154,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":155,"context_line":"        if tags:"},{"line_number":156,"context_line":"            subnets \u003d os_net.subnets(name\u003dsubnet_name, tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":1,"id":"de1424db_0506fb04","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":64},"updated":"2022-03-24 14:38:11.000000000","message":"This combines two separators, so it renames it. :/","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"58fb3ea6de4125716f9e03215c5772a08d44d701","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def create_subnet(self, ns_name, project_id, net_id):"},{"line_number":151,"context_line":"        os_net \u003d clients.get_network_client()"},{"line_number":152,"context_line":"        subnet_name \u003d c_utils.get_resource_name(ns_name, prefix\u003d\u0027ns\u0027,"},{"line_number":153,"context_line":"                                                suffix\u003d\u0027subnet\u0027)"},{"line_number":154,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":155,"context_line":"        if tags:"},{"line_number":156,"context_line":"            subnets \u003d os_net.subnets(name\u003dsubnet_name, tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":1,"id":"35365e34_efd2df88","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":64},"in_reply_to":"37542fc2_b60232a7","updated":"2022-04-01 11:37:42.000000000","message":"Done","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5149696778f4596544c1e5ffd5a6f5b278b9ef72","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def create_subnet(self, ns_name, project_id, net_id):"},{"line_number":151,"context_line":"        os_net \u003d clients.get_network_client()"},{"line_number":152,"context_line":"        subnet_name \u003d c_utils.get_resource_name(ns_name, prefix\u003d\u0027ns\u0027,"},{"line_number":153,"context_line":"                                                suffix\u003d\u0027subnet\u0027)"},{"line_number":154,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":155,"context_line":"        if tags:"},{"line_number":156,"context_line":"            subnets \u003d os_net.subnets(name\u003dsubnet_name, tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":1,"id":"40652f7f_10b85776","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":64},"in_reply_to":"37542fc2_b60232a7","updated":"2022-04-04 12:55:22.000000000","message":"I agree, names shouldn\u0027t matter too much to us.","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"a2f3ace872bc35d2f7f0f93be6d23b559a09f4ce","unresolved":true,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def create_subnet(self, ns_name, project_id, net_id):"},{"line_number":151,"context_line":"        os_net \u003d clients.get_network_client()"},{"line_number":152,"context_line":"        subnet_name \u003d c_utils.get_resource_name(ns_name, prefix\u003d\u0027ns\u0027,"},{"line_number":153,"context_line":"                                                suffix\u003d\u0027subnet\u0027)"},{"line_number":154,"context_line":"        tags \u003d oslo_cfg.CONF.neutron_defaults.resource_tags"},{"line_number":155,"context_line":"        if tags:"},{"line_number":156,"context_line":"            subnets \u003d os_net.subnets(name\u003dsubnet_name, tags\u003dtags)"}],"source_content_type":"text/x-python","patch_set":1,"id":"37542fc2_b60232a7","line":153,"range":{"start_line":152,"start_character":0,"end_line":153,"end_character":64},"in_reply_to":"de1424db_0506fb04","updated":"2022-03-24 15:27:33.000000000","message":"Right. I thought, that it doesn\u0027t matter really - it is just a name so having \u0027ns/foo-net\u0027 vs \u0027ns/goo/net\u0027 doesn\u0027t bring much value, isn\u0027t it?","commit_id":"107bdc93ba026af22988b42ed2198ff85d07123e"}],"kuryr_kubernetes/controller/drivers/utils.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"46dcf1cf39494ad91b5c340f2b1144d17442b1c5","unresolved":true,"context_lines":[{"line_number":752,"context_line":"    return False"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"def get_resource_name(name, uid\u003d\u0027\u0027, prefix\u003d\u0027\u0027, suffix\u003d\u0027\u0027, separator\u003d\u0027/\u0027):"},{"line_number":756,"context_line":"    \"\"\"Get OpenStack resource name out of Kubernetes resources"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    Return name for the OpenStack resource, which usually is up to 255 chars"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfe851ef_e7548590","line":755,"updated":"2022-04-07 09:57:49.000000000","message":"I don\u0027t see uid and separators being used anywhere anymore, also not here https://review.opendev.org/c/openstack/kuryr-kubernetes/+/835078/. Perhaps we can remove it?","commit_id":"9241b33c8a59beb14fb70541b6b2d12238f9e93d"}]}
