)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"892a2b20f59bfe41cfbbbe8a461a1a976e5fe663","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"abf0284d_bc4e8432","updated":"2022-04-05 17:14:22.000000000","message":"Just one question:\nShouldn\u0027t we handle it here as well:\nhttps://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/drivers/vif_pool.py#L805-L812","commit_id":"1223d8368da5bd4cf98d02bedaa5a06a531e88ca"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"184e85ad28b44b06ce2db65fea5878bcd50ce670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0602c9f9_b201e641","in_reply_to":"abf0284d_bc4e8432","updated":"2022-04-06 12:33:02.000000000","message":"It could, with the remark, that removing port from vif dictionary and port itself would be separated - i.e. we will iterate over vif dictionary and than send for deletion in neutron. If that\u0027s ok with you I\u0027ll amend the patch.","commit_id":"1223d8368da5bd4cf98d02bedaa5a06a531e88ca"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"2a2b8b655feacfbf1006fcdc15db699e88240b28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ce63c3f1_e8867447","updated":"2022-04-11 12:21:02.000000000","message":"Need to check why removing port in parallel is actually slower than removing sequentially.","commit_id":"8cdee8d73da9b7f4149165849c35cd7e86afa2bd"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"e2171cb09c61cdc0c5cadeb2ff10ccd361d93129","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e0ecab6_294a37fe","in_reply_to":"c58cb30e_3a565cdb","updated":"2022-04-12 12:23:21.000000000","message":"The reason was, that it didn\u0027t wait for the results for port deletion - greenpool has been fed with the tasks, but there was no waiting for the results.","commit_id":"8cdee8d73da9b7f4149165849c35cd7e86afa2bd"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"05d24529eeb91b5892a04d6b85d3b5552817354a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c58cb30e_3a565cdb","in_reply_to":"ce63c3f1_e8867447","updated":"2022-04-11 13:09:33.000000000","message":"Seems that when we delete_network_pools we create a greenpool and then create another one at _delete_namespace_network_resources since the Network still has Ports and there was no time for all of them to be deleted at \u0027delete_network_pools\u0027 , after that we keep retrying and each retry results in longer waiting.","commit_id":"8cdee8d73da9b7f4149165849c35cd7e86afa2bd"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"fe000afff31e48265c487ce714c560ef1aee6e2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b2685b10_87178112","updated":"2022-04-12 12:51:04.000000000","message":"Great work, Roman! It looks great and there is a speed improvement now.","commit_id":"e9fd3bb13463f4a11f76694222dfc4f727c658b9"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"4d7e5fc2715c8680ec956df4ea0bd2d52e8995b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b0a36fa_9d8758f0","updated":"2022-04-12 20:40:37.000000000","message":"recheck","commit_id":"e9fd3bb13463f4a11f76694222dfc4f727c658b9"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f4f5a4bd41d5a62b786aa6faf265b847693e08cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ce505cb_59158ab0","updated":"2022-04-14 08:16:58.000000000","message":"recheck","commit_id":"e9fd3bb13463f4a11f76694222dfc4f727c658b9"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b608512342d28c4dd3537898f62d1270530c95ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"73105ef2_8e02ac0a","updated":"2022-04-13 10:00:23.000000000","message":"recheck","commit_id":"e9fd3bb13463f4a11f76694222dfc4f727c658b9"}],"kuryr_kubernetes/controller/drivers/utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7d20624e75cf63e6458305553545650fb7a6acb7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import concurrent.futures as cf"},{"line_number":17,"context_line":"import urllib"},{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ec56afd_3148510e","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":31},"updated":"2022-04-05 15:14:45.000000000","message":"Okay, this is impressive. Nice idea.","commit_id":"1223d8368da5bd4cf98d02bedaa5a06a531e88ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9946db0e87a77d03d8cf1b94d8638074440ff9c8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import concurrent.futures as cf"},{"line_number":17,"context_line":"import urllib"},{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d3165499_4a705b34","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":31},"in_reply_to":"5ec56afd_3148510e","updated":"2022-04-08 15:59:09.000000000","message":"Ack","commit_id":"1223d8368da5bd4cf98d02bedaa5a06a531e88ca"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"892a2b20f59bfe41cfbbbe8a461a1a976e5fe663","unresolved":true,"context_lines":[{"line_number":753,"context_line":"    return False"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"def delete_ports(leftover_port_list):"},{"line_number":757,"context_line":"    with cf.ThreadPoolExecutor(max_workers\u003dLEFTOVER_RM_POOL_SIZE) as executor:"},{"line_number":758,"context_line":"        executor.map(delete_port, leftover_port_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"92ac6840_793091ca","line":756,"updated":"2022-04-05 17:14:22.000000000","message":"Nicely handled!","commit_id":"1223d8368da5bd4cf98d02bedaa5a06a531e88ca"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9946db0e87a77d03d8cf1b94d8638074440ff9c8","unresolved":false,"context_lines":[{"line_number":753,"context_line":"    return False"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"def delete_ports(leftover_port_list):"},{"line_number":757,"context_line":"    with cf.ThreadPoolExecutor(max_workers\u003dLEFTOVER_RM_POOL_SIZE) as executor:"},{"line_number":758,"context_line":"        executor.map(delete_port, leftover_port_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"80c87be6_7e86f6a0","line":756,"in_reply_to":"92ac6840_793091ca","updated":"2022-04-08 15:59:09.000000000","message":"Ack","commit_id":"1223d8368da5bd4cf98d02bedaa5a06a531e88ca"}],"kuryr_kubernetes/controller/drivers/vif_pool.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"55192ea0b864d0ac5b6c5da9e214bfd693682054","unresolved":true,"context_lines":[{"line_number":1200,"context_line":"                    del self._existing_vifs[port_id]"},{"line_number":1201,"context_line":"                except KeyError:"},{"line_number":1202,"context_line":"                    LOG.debug(\u0027Port %s is not in the ports list.\u0027, port_id)"},{"line_number":1203,"context_line":"                os_net.delete_port(port_id)"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"            self._available_ports_pools[pool_key] \u003d {}"},{"line_number":1206,"context_line":"            with self._lock:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5d851c4d_0dbcdce8","line":1203,"updated":"2022-04-11 10:22:22.000000000","message":"can you also delete it in parallel here?","commit_id":"275e4c2031f675db83c0d3aa15d4c26ef6d4cc32"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"99e8a764611e6f1f7e48b1620caa4d66c264d0ce","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"                    del self._existing_vifs[port_id]"},{"line_number":1201,"context_line":"                except KeyError:"},{"line_number":1202,"context_line":"                    LOG.debug(\u0027Port %s is not in the ports list.\u0027, port_id)"},{"line_number":1203,"context_line":"                os_net.delete_port(port_id)"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"            self._available_ports_pools[pool_key] \u003d {}"},{"line_number":1206,"context_line":"            with self._lock:"}],"source_content_type":"text/x-python","patch_set":3,"id":"f59a9e9f_491ca477","line":1203,"in_reply_to":"5d851c4d_0dbcdce8","updated":"2022-04-11 10:34:11.000000000","message":"Ack","commit_id":"275e4c2031f675db83c0d3aa15d4c26ef6d4cc32"}]}