)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3d004a6a12b2e889612099de06f03851703e6b18","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Added cluster id information to the Port object."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently device_id field has been only filled with pod uid in case the"},{"line_number":10,"context_line":"port has been in use with that pod, now we start to use device_id for"},{"line_number":11,"context_line":"all ports, and additionally add pod uid for bonded ports in a form:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"cluster_id:pod_uid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5d6426f6_1068576e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":34},"updated":"2022-05-16 11:42:18.000000000","message":"and when nested configuration is not used.","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"35f210628d6f2cbcd6668c3b17afd515798181b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d3fb17e_db7f409c","updated":"2022-05-09 11:34:59.000000000","message":"recheck","commit_id":"2a97229908acf4b5b3f9c010bca760670ce06a10"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"29900417b2d71f8525740b567c274eb3b663971d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60f29880_21c79e17","updated":"2022-05-12 16:34:03.000000000","message":"I\u0027m starting to wonder if just using description for ports like it\u0027s done for subnets and networks wouldn\u0027t be easier than messing with device_id. Eh, simplicity vs using a semantic field for something, that\u0027s tough decision. :/","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3d004a6a12b2e889612099de06f03851703e6b18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5633a6d2_17fc5f5f","updated":"2022-05-16 11:42:18.000000000","message":"Thanks for the patch, Roman! Couple of topics to discuss:\n\nFrom what I understood the idea would be to set device_id:\u003cpod-uid\u003e when the Port is used by a Pod and device_id:\u003ccluster-id\u003e when not used yet, right?\n\n1. How would this play when using ports population feature?\n\nImagine that a Pod creation got triggered and a population is triggered with request_vifs method, we would have to identify somehow which Port of the pool is used and probably update it again with the device-id, this might result in the same issue we are trying to avoid with this patch, the 504 error from Neutron.\n\nMaybe we can always set the device-id:\u003ccluster-id\u003e regardless if it\u0027s bound or not?\n\n2. we might want to update any Ports listing operation to also include the device-id as a Filter\n\n3. Should we remove the addition of tags as an additional operation? e.g. https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/drivers/nested_vlan_vif.py#L100-L101","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f54eb7ebd346c01f6dd520803f757ae1849c8e2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e61a1fd4_4c6c3d6e","updated":"2022-05-10 07:21:36.000000000","message":"recheck","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"50fda2c2f8964097a3a103ba8c7c5b225fdbd20f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"78287b01_a166dc65","in_reply_to":"3731336b_74886608","updated":"2022-05-17 07:05:07.000000000","message":"I tend to agree with Michał, that having id in one place (description) could be a better (more coherent, if we ignore that it goes to non semantic field) idea. I\u0027ll put the cluster id into description instead of device_id.","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"5741cb021c45bfc3dec62354dcca40e70825cba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3731336b_74886608","in_reply_to":"60f29880_21c79e17","updated":"2022-05-16 11:44:39.000000000","message":"Just some more info, when Octavia didn\u0027t support tags, we add them to the description field https://github.com/openstack/kuryr-kubernetes/blob/master/kuryr_kubernetes/controller/drivers/lbaasv2.py#L143-L146","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"40def9e4a7cb1accf48105681d2e7325f791ad76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f726874_06819471","updated":"2022-05-23 14:43:58.000000000","message":"I think we have agreed to only add info to the description of networks/subnets, but let\u0027s confirm","commit_id":"5252d83b466056f1ff45134bb30d83bdd7795135"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"2381c4c312b924f6327cd417c4cd31f16849de3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"02cb8d75_eb3e5f8f","updated":"2022-05-19 06:32:25.000000000","message":"recheck","commit_id":"5252d83b466056f1ff45134bb30d83bdd7795135"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"9be79b28eb418189fa23058e51ab23230651674a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"26aceab9_dea45d5f","updated":"2022-05-23 07:09:02.000000000","message":"recheck","commit_id":"5252d83b466056f1ff45134bb30d83bdd7795135"}],"kuryr_kubernetes/controller/drivers/neutron_vif.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"29900417b2d71f8525740b567c274eb3b663971d","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def _get_port_request(self, pod, project_id, subnets, security_groups,"},{"line_number":125,"context_line":"                          unbound\u003dFalse):"},{"line_number":126,"context_line":"        port_req_body \u003d {\u0027project_id\u0027: project_id,"},{"line_number":127,"context_line":"                         \u0027network_id\u0027: utils.get_network_id(subnets),"},{"line_number":128,"context_line":"                         \u0027fixed_ips\u0027: ovu.osvif_to_neutron_fixed_ips(subnets),"},{"line_number":129,"context_line":"                         \u0027device_owner\u0027: kl_const.DEVICE_OWNER,"}],"source_content_type":"text/x-python","patch_set":2,"id":"60a7ce97_837b3366","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":50},"updated":"2022-05-12 16:34:03.000000000","message":"Setting it here won\u0027t cover the nested case where the method is overridden [1].\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/e9fd3bb13463f4a11f76694222dfc4f727c658b9/kuryr_kubernetes/controller/drivers/nested_vlan_vif.py#L173-L177","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"50fda2c2f8964097a3a103ba8c7c5b225fdbd20f","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def _get_port_request(self, pod, project_id, subnets, security_groups,"},{"line_number":125,"context_line":"                          unbound\u003dFalse):"},{"line_number":126,"context_line":"        port_req_body \u003d {\u0027project_id\u0027: project_id,"},{"line_number":127,"context_line":"                         \u0027network_id\u0027: utils.get_network_id(subnets),"},{"line_number":128,"context_line":"                         \u0027fixed_ips\u0027: ovu.osvif_to_neutron_fixed_ips(subnets),"},{"line_number":129,"context_line":"                         \u0027device_owner\u0027: kl_const.DEVICE_OWNER,"}],"source_content_type":"text/x-python","patch_set":2,"id":"71b63b5a_9636390a","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":50},"in_reply_to":"60a7ce97_837b3366","updated":"2022-05-17 07:05:07.000000000","message":"Ack","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"8041991b5b9ebda95c2a6a177c2f94e8dc19cb12","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                         \u0027network_id\u0027: utils.get_network_id(subnets),"},{"line_number":128,"context_line":"                         \u0027fixed_ips\u0027: ovu.osvif_to_neutron_fixed_ips(subnets),"},{"line_number":129,"context_line":"                         \u0027device_owner\u0027: kl_const.DEVICE_OWNER,"},{"line_number":130,"context_line":"                         \u0027device_id\u0027: CONF.kubernetes.cluster_id,"},{"line_number":131,"context_line":"                         \u0027admin_state_up\u0027: True,"},{"line_number":132,"context_line":"                         \u0027binding_host_id\u0027: utils.get_host_id(pod)}"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e8359dc4_508dab7b","line":130,"range":{"start_line":130,"start_character":38,"end_line":130,"end_character":64},"updated":"2022-05-10 07:00:54.000000000","message":"According to the commit message, the \u0027device_id\u0027 form like this: \u0027cluster_id:pod_uid\u0027, I confused thing is that where is the \u0027pod_uid\u0027 added.","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"f54eb7ebd346c01f6dd520803f757ae1849c8e2a","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                         \u0027network_id\u0027: utils.get_network_id(subnets),"},{"line_number":128,"context_line":"                         \u0027fixed_ips\u0027: ovu.osvif_to_neutron_fixed_ips(subnets),"},{"line_number":129,"context_line":"                         \u0027device_owner\u0027: kl_const.DEVICE_OWNER,"},{"line_number":130,"context_line":"                         \u0027device_id\u0027: CONF.kubernetes.cluster_id,"},{"line_number":131,"context_line":"                         \u0027admin_state_up\u0027: True,"},{"line_number":132,"context_line":"                         \u0027binding_host_id\u0027: utils.get_host_id(pod)}"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"66cfd712_d91a4599","line":130,"range":{"start_line":130,"start_character":38,"end_line":130,"end_character":64},"in_reply_to":"e8359dc4_508dab7b","updated":"2022-05-10 07:21:36.000000000","message":"Every port created by kuryr need to have cluster_id set. But for bounded port, we additionally have pod id originally set in \u0027device_id\u0027. So in case of port being binded, the device_id will have a form of \u0027cluster_id:pod_id\u0027, all the other kuryr ports will have just \u0027cluster_id\u0027 (as in line 144, where appropriate string is get by `utils.get_device_id(pod)` function.","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"29900417b2d71f8525740b567c274eb3b663971d","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            # only set the name if port_debug is enabled"},{"line_number":142,"context_line":"            if config.CONF.kubernetes.port_debug:"},{"line_number":143,"context_line":"                port_req_body[\u0027name\u0027] \u003d utils.get_port_name(pod)"},{"line_number":144,"context_line":"            port_req_body[\u0027device_id\u0027] \u003d utils.get_device_id(pod)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if security_groups:"},{"line_number":147,"context_line":"            port_req_body[\u0027security_groups\u0027] \u003d security_groups"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2a482b9_ec9d70a7","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":65},"updated":"2022-05-12 16:34:03.000000000","message":"Do we want it to be immediately overwritten for non-nested case?","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"50fda2c2f8964097a3a103ba8c7c5b225fdbd20f","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            # only set the name if port_debug is enabled"},{"line_number":142,"context_line":"            if config.CONF.kubernetes.port_debug:"},{"line_number":143,"context_line":"                port_req_body[\u0027name\u0027] \u003d utils.get_port_name(pod)"},{"line_number":144,"context_line":"            port_req_body[\u0027device_id\u0027] \u003d utils.get_device_id(pod)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if security_groups:"},{"line_number":147,"context_line":"            port_req_body[\u0027security_groups\u0027] \u003d security_groups"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe0f441f_c058cfa7","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":65},"in_reply_to":"e2a482b9_ec9d70a7","updated":"2022-05-17 07:05:07.000000000","message":"Well, not really. I\u0027ll use the description field, so that we don\u0027t need to worry about that part.","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"}],"releasenotes/notes/zed-upgrade-06fcd4624f8116ce.yaml":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"3d004a6a12b2e889612099de06f03851703e6b18","unresolved":true,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    There was a change for the Neutron resources, to have device_id set to"},{"line_number":5,"context_line":"    the Kubernetes cluster id (which shold be set in kuryr config), so it"},{"line_number":6,"context_line":"    might affect Neutron binded ports, which till now holds pod uid - now for"},{"line_number":7,"context_line":"    such a case this field would be use ``cluster_id:pod_uid`` convention."},{"line_number":8,"context_line":"    Any projects which leverage information on this field should be updated"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a8acd6c9_7f3b1607","line":5,"range":{"start_line":5,"start_character":37,"end_line":5,"end_character":42},"updated":"2022-05-16 11:42:18.000000000","message":"should","commit_id":"04aae065baf606dbca70381a383c3298839c39c3"}]}