)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"16a89243df9b0f9b49a6c9fe9b051246d6fb225b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ab6cb1f9_61e98e0c","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":11},"updated":"2022-06-24 11:31:57.000000000","message":"patch","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"16a89243df9b0f9b49a6c9fe9b051246d6fb225b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d6e6612b_294415c1","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":34},"updated":"2022-06-24 11:31:57.000000000","message":"typo","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"638b0a787260d34d95b343401fe9a3f315ddcdfd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7b2a9c7c_6eb85527","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":11},"in_reply_to":"ab6cb1f9_61e98e0c","updated":"2022-08-22 14:27:14.000000000","message":"Done","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"638b0a787260d34d95b343401fe9a3f315ddcdfd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6372152e_b03aa14d","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":34},"in_reply_to":"d6e6612b_294415c1","updated":"2022-08-22 14:27:14.000000000","message":"Done","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"16a89243df9b0f9b49a6c9fe9b051246d6fb225b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint reconcile-openstack-resources-with-k8s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a322c79e_b5b77b8a","line":10,"updated":"2022-06-24 11:31:57.000000000","message":"the respective Kubernetes Endpoints.","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"16a89243df9b0f9b49a6c9fe9b051246d6fb225b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint reconcile-openstack-resources-with-k8s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2343c20c_b96604c4","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":19},"updated":"2022-06-24 11:31:57.000000000","message":"typo","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"638b0a787260d34d95b343401fe9a3f315ddcdfd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint reconcile-openstack-resources-with-k8s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f8bf69ed_5a440497","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":19},"in_reply_to":"2343c20c_b96604c4","updated":"2022-08-22 14:27:14.000000000","message":"Done","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"638b0a787260d34d95b343401fe9a3f315ddcdfd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"LoadBalancer Members Reconciliation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The pathset implements the memebrs reconciliation to"},{"line_number":10,"context_line":"ensure that memebrs in pools in OpenStack are matching that of"},{"line_number":11,"context_line":"Kubernetes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint reconcile-openstack-resources-with-k8s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"edccd20c_680acb76","line":10,"in_reply_to":"a322c79e_b5b77b8a","updated":"2022-08-22 14:27:14.000000000","message":"Done","commit_id":"5d5a791af421dd273225848f779131550b68f624"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8c0861d580e991fe59f0639280de40e87e72f245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b28b0f84_3373d0e2","updated":"2022-08-23 14:46:39.000000000","message":"Thanks, Sunday. Here goes some tweaks:","commit_id":"4a153c5c3a6aea743f462d744eda2609fdd2d884"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6eee7e93f8819634d6b29125a4e94097ff5d8b8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"78bffa05_1bcd1c4c","updated":"2022-09-01 10:10:22.000000000","message":"Alright, I tested the patch, it worked.","commit_id":"269730be07acb1ccbf000eb8f518787b6181f8e4"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0c66ad9f1d1494679040fcaacb9cc5865ecb591b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"061f69e7_7df6dc9a","updated":"2022-08-30 15:10:25.000000000","message":"Code wise this looks pretty okay. Had you tested that this works fine? I\u0027ll probably need to spin this up on an env and play a bit before adding +2.","commit_id":"269730be07acb1ccbf000eb8f518787b6181f8e4"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"a3e5f0151b23ee855903f1a36911037eac6359db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2054f6df_55ca417d","updated":"2022-08-24 09:05:17.000000000","message":"recheck","commit_id":"269730be07acb1ccbf000eb8f518787b6181f8e4"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"a19577974d8c58c59092d30f6408bd9f61b46190","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a93d1d26_02ff1b91","updated":"2022-08-23 17:34:04.000000000","message":"recheck","commit_id":"269730be07acb1ccbf000eb8f518787b6181f8e4"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"c1bc3953202e7808cc7f0c3c522dd5060b5d8407","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a42ecd22_595d80c9","in_reply_to":"061f69e7_7df6dc9a","updated":"2022-08-30 16:11:23.000000000","message":"\u003e Code wise this looks pretty okay. Had you tested that this works fine? I\u0027ll probably need to spin this up on an env and play a bit before adding +2.\n\nYes, I tested and it\u0027s working. But let me know in case you have any observations or more improvements","commit_id":"269730be07acb1ccbf000eb8f518787b6181f8e4"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4b727a78882a24c2f2004fce437f2a272c4cd509","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"20204eb4_42e78dd5","updated":"2022-09-02 10:29:23.000000000","message":"recheck","commit_id":"da92da2f4763b310db5701704316383a9697f3d8"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"1167a7727ea5b695eb4c4be3c67a758e3d232ddc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"36c0d192_5c7cc89e","updated":"2022-09-02 16:56:12.000000000","message":"recheck","commit_id":"da92da2f4763b310db5701704316383a9697f3d8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dc1315bfcb57dc6723a05eeb23105f42d2867e2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9efa2cbb_7b95f16f","updated":"2022-09-05 06:33:12.000000000","message":"recheck","commit_id":"da92da2f4763b310db5701704316383a9697f3d8"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"0ced03523ecdc29e3daf7f52f0402bf7e3e635ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cf197d3c_6f8421b5","updated":"2022-09-02 05:19:25.000000000","message":"recheck","commit_id":"da92da2f4763b310db5701704316383a9697f3d8"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"72ede344d7771f0921f429dc82350f3fb1ef0bc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ae4755eb_8d997a2e","updated":"2022-09-03 08:38:14.000000000","message":"reckeck","commit_id":"da92da2f4763b310db5701704316383a9697f3d8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f60b818f759f5c4d01e3954d10c03c4e038d4a7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c4bd087e_4a675fa9","updated":"2022-09-05 10:05:30.000000000","message":"I added a Depends-On with an OVN Octavia fix.","commit_id":"93ef2f8650f39e1d8cab40a8c3d523296904249a"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"e38d6f9b0a3e62621954d3f8826dd05a63f91702","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"40d0914d_beedff24","updated":"2022-09-06 11:04:53.000000000","message":"Let\u0027s wait for mr Zuul.","commit_id":"93ef2f8650f39e1d8cab40a8c3d523296904249a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8672cef2918d17b492872cb950a26bcbdd7b91a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5ec5bcb4_ea1d5ab6","updated":"2022-09-06 09:26:56.000000000","message":"recheck","commit_id":"93ef2f8650f39e1d8cab40a8c3d523296904249a"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"18ef86bc6953f6d60de4d1524a06f24dc510208c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6b9c4593_97f0dbdd","updated":"2022-09-06 14:23:54.000000000","message":"recheck","commit_id":"93ef2f8650f39e1d8cab40a8c3d523296904249a"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"042984d45fe8bd7391aca400e7f138e38ebf1349","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7dec304b_8a8899e8","updated":"2022-09-06 00:44:27.000000000","message":"recheck","commit_id":"93ef2f8650f39e1d8cab40a8c3d523296904249a"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"8a0367858df76cfa46d74177821d2e4e71b77d0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a5bf1e91_fa7d429b","updated":"2022-09-05 16:52:10.000000000","message":"recheck","commit_id":"93ef2f8650f39e1d8cab40a8c3d523296904249a"}],"kuryr_kubernetes/controller/handlers/loadbalancer.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"16a89243df9b0f9b49a6c9fe9b051246d6fb225b","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            filters \u003d {}"},{"line_number":220,"context_line":"            self._drv_lbaas.add_tags(resource_type, filters)"},{"line_number":221,"context_line":"            os_list \u003d resources_fn[resource_type]"},{"line_number":222,"context_line":"            os_resources \u003d os_list(**filters)"},{"line_number":223,"context_line":"            os_resources_id \u003d [rsrc[\u0027id\u0027] for rsrc in os_resources]"},{"line_number":224,"context_line":"            for data in resources[resource_type]:"},{"line_number":225,"context_line":"                if data[\u0027selflink\u0027] in resources_already_triggered:"}],"source_content_type":"text/x-python","patch_set":1,"id":"63b0a8d3_90795fd6","line":222,"range":{"start_line":222,"start_character":12,"end_line":222,"end_character":45},"updated":"2022-06-24 11:31:57.000000000","message":"I don\u0027t think octavia API allows to list members only, without passing the pool those members would be in, consequently the filters would need update. Can you double check it?\n\nhere is the link to the API:\nhttps://docs.openstack.org/api-ref/load-balancer/v2/#members","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"a8041dd884e1a181903c35c462b673b2a835e1ba","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            filters \u003d {}"},{"line_number":220,"context_line":"            self._drv_lbaas.add_tags(resource_type, filters)"},{"line_number":221,"context_line":"            os_list \u003d resources_fn[resource_type]"},{"line_number":222,"context_line":"            os_resources \u003d os_list(**filters)"},{"line_number":223,"context_line":"            os_resources_id \u003d [rsrc[\u0027id\u0027] for rsrc in os_resources]"},{"line_number":224,"context_line":"            for data in resources[resource_type]:"},{"line_number":225,"context_line":"                if data[\u0027selflink\u0027] in resources_already_triggered:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed0d04cb_604ee5cc","line":222,"range":{"start_line":222,"start_character":12,"end_line":222,"end_character":45},"in_reply_to":"63b0a8d3_90795fd6","updated":"2022-06-24 11:34:49.000000000","message":"Let me take a look again. Thanks","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"638b0a787260d34d95b343401fe9a3f315ddcdfd","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            filters \u003d {}"},{"line_number":220,"context_line":"            self._drv_lbaas.add_tags(resource_type, filters)"},{"line_number":221,"context_line":"            os_list \u003d resources_fn[resource_type]"},{"line_number":222,"context_line":"            os_resources \u003d os_list(**filters)"},{"line_number":223,"context_line":"            os_resources_id \u003d [rsrc[\u0027id\u0027] for rsrc in os_resources]"},{"line_number":224,"context_line":"            for data in resources[resource_type]:"},{"line_number":225,"context_line":"                if data[\u0027selflink\u0027] in resources_already_triggered:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca638b26_2081c982","line":222,"range":{"start_line":222,"start_character":12,"end_line":222,"end_character":45},"in_reply_to":"ed0d04cb_604ee5cc","updated":"2022-08-22 14:27:14.000000000","message":"Ack","commit_id":"5d5a791af421dd273225848f779131550b68f624"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8c0861d580e991fe59f0639280de40e87e72f245","unresolved":true,"context_lines":[{"line_number":183,"context_line":"        resources_fn \u003d {\u0027loadbalancer\u0027: lbaas.load_balancers,"},{"line_number":184,"context_line":"                        \u0027listener\u0027: lbaas.listeners,"},{"line_number":185,"context_line":"                        \u0027pool\u0027: lbaas.pools, \u0027member\u0027: lbaas.members}"},{"line_number":186,"context_line":"        resources \u003d {\u0027loadbalancer\u0027: [], \u0027listener\u0027: [], \u0027pool\u0027: [],"},{"line_number":187,"context_line":"                     \u0027member\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        for klb in loadbalancer_crds:"}],"source_content_type":"text/x-python","patch_set":6,"id":"0bbb3d08_0756e41f","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":17},"updated":"2022-08-23 14:46:39.000000000","message":"perhaps this variable can be renamed to","commit_id":"4a153c5c3a6aea743f462d744eda2609fdd2d884"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"9865f8fffa489503a9a08450ad4ddf4b918b92b3","unresolved":true,"context_lines":[{"line_number":183,"context_line":"        resources_fn \u003d {\u0027loadbalancer\u0027: lbaas.load_balancers,"},{"line_number":184,"context_line":"                        \u0027listener\u0027: lbaas.listeners,"},{"line_number":185,"context_line":"                        \u0027pool\u0027: lbaas.pools, \u0027member\u0027: lbaas.members}"},{"line_number":186,"context_line":"        resources \u003d {\u0027loadbalancer\u0027: [], \u0027listener\u0027: [], \u0027pool\u0027: [],"},{"line_number":187,"context_line":"                     \u0027member\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        for klb in loadbalancer_crds:"}],"source_content_type":"text/x-python","patch_set":6,"id":"a482d82e_9e532625","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":17},"in_reply_to":"0bbb3d08_0756e41f","updated":"2022-08-23 15:18:27.000000000","message":"ups, disregard this comment","commit_id":"4a153c5c3a6aea743f462d744eda2609fdd2d884"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"89a317b7dae784df18e445260435379d020e8dc6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        resources_fn \u003d {\u0027loadbalancer\u0027: lbaas.load_balancers,"},{"line_number":184,"context_line":"                        \u0027listener\u0027: lbaas.listeners,"},{"line_number":185,"context_line":"                        \u0027pool\u0027: lbaas.pools, \u0027member\u0027: lbaas.members}"},{"line_number":186,"context_line":"        resources \u003d {\u0027loadbalancer\u0027: [], \u0027listener\u0027: [], \u0027pool\u0027: [],"},{"line_number":187,"context_line":"                     \u0027member\u0027: []}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        for klb in loadbalancer_crds:"}],"source_content_type":"text/x-python","patch_set":6,"id":"4bf69292_0fbfbbf7","line":186,"range":{"start_line":186,"start_character":8,"end_line":186,"end_character":17},"in_reply_to":"a482d82e_9e532625","updated":"2022-08-23 15:43:48.000000000","message":"Ack","commit_id":"4a153c5c3a6aea743f462d744eda2609fdd2d884"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8c0861d580e991fe59f0639280de40e87e72f245","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            self._drv_lbaas.add_tags(resource_type, filters)"},{"line_number":222,"context_line":"            os_list \u003d resources_fn[resource_type]"},{"line_number":223,"context_line":"            if resource_type \u003d\u003d \u0027member\u0027:"},{"line_number":224,"context_line":"                pool_ids \u003d [membr_data[\u0027pool_id\u0027] for membr_data in"},{"line_number":225,"context_line":"                            resources[resource_type]]"},{"line_number":226,"context_line":"                os_resources_id \u003d []"},{"line_number":227,"context_line":"                for pl_id in pool_ids:"},{"line_number":228,"context_line":"                    os_resources \u003d os_list(pl_id, **filters)"}],"source_content_type":"text/x-python","patch_set":6,"id":"15cf87bf_2f9f5324","line":225,"range":{"start_line":224,"start_character":27,"end_line":225,"end_character":53},"updated":"2022-08-23 14:46:39.000000000","message":"We could avoid adding a duplicated pool id to the list since it\u0027s possible to have multiple members in the same pool and consequently we avoid more calls to octavia at line 228.\n\nalso renaming membr_data to cr_member would be more descriptive","commit_id":"4a153c5c3a6aea743f462d744eda2609fdd2d884"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"89a317b7dae784df18e445260435379d020e8dc6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            self._drv_lbaas.add_tags(resource_type, filters)"},{"line_number":222,"context_line":"            os_list \u003d resources_fn[resource_type]"},{"line_number":223,"context_line":"            if resource_type \u003d\u003d \u0027member\u0027:"},{"line_number":224,"context_line":"                pool_ids \u003d [membr_data[\u0027pool_id\u0027] for membr_data in"},{"line_number":225,"context_line":"                            resources[resource_type]]"},{"line_number":226,"context_line":"                os_resources_id \u003d []"},{"line_number":227,"context_line":"                for pl_id in pool_ids:"},{"line_number":228,"context_line":"                    os_resources \u003d os_list(pl_id, **filters)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1eaefe44_9512902b","line":225,"range":{"start_line":224,"start_character":27,"end_line":225,"end_character":53},"in_reply_to":"15cf87bf_2f9f5324","updated":"2022-08-23 15:43:48.000000000","message":"Done","commit_id":"4a153c5c3a6aea743f462d744eda2609fdd2d884"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e3d1d97e1042cc84acb60d45151e24a79f1e7c85","unresolved":true,"context_lines":[{"line_number":244,"context_line":"    def _reconcile_lb(self, data):"},{"line_number":245,"context_line":"        kubernetes \u003d clients.get_kubernetes_client()"},{"line_number":246,"context_line":"        try:"},{"line_number":247,"context_line":"            if data.get(\u0027klb\u0027):"},{"line_number":248,"context_line":"                self._add_event(data[\u0027klb\u0027], \u0027LoadBalancerRecreating\u0027,"},{"line_number":249,"context_line":"                                \u0027Load balancer for the Service does  not \u0027"},{"line_number":250,"context_line":"                                \u0027exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":251,"context_line":"            if data.get(\u0027lklb\u0027):"},{"line_number":252,"context_line":"                self._add_event(data[\u0027lklb\u0027], \u0027Load Balancer listener does not\u0027"},{"line_number":253,"context_line":"                                \u0027 exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":254,"context_line":"            if data.get(\u0027pklb\u0027):"},{"line_number":255,"context_line":"                self._add_event(data[\u0027pklb\u0027], \u0027Load Balancer pool does not \u0027"},{"line_number":256,"context_line":"                                \u0027exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":257,"context_line":"            if data.get(\u0027mklb\u0027):"},{"line_number":258,"context_line":"                self._add_event(data[\u0027mklb\u0027], \u0027Load Balancer member does not \u0027"},{"line_number":259,"context_line":"                                \u0027exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            kubernetes.patch_crd(\u0027status\u0027, data[\u0027selflink\u0027], {})"},{"line_number":262,"context_line":"        except k_exc.K8sResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5c49d99b_dd907539","line":259,"range":{"start_line":247,"start_character":0,"end_line":259,"end_character":75},"updated":"2022-09-01 10:15:14.000000000","message":"Ah no, there\u0027s a bug. You don\u0027t specify `LoadBalancerRecreating` as second argument for the other ones, so this ends up like this:\n\n  Normal  KuryrServiceSkipped                                          12m   kuryr-controller  Skipping Service default/test without Endpoints\n  Normal  KuryrEnsureLB                                                12m   kuryr-controller  Provisioning a load balancer\n  Normal  KuryrEnsuredLB                                               11m   kuryr-controller  Load balancer provisioned\n  Normal  KuryrEnsuredLB                                               11m   kuryr-controller  Load balancer provisioned\n  Normal  Load Balancer member does not exist anymore. Recreating it.  24s   kuryr-controller  Warning\n  Normal  KuryrEnsureLB                                                23s   kuryr-controller  Provisioning a load balancer\n  Normal  KuryrEnsuredLB                                               22s   kuryr-controller  Load balancer provisioned\n  Normal  KuryrEnsuredLB                                               19s   kuryr-controller  Load balancer provisioned\n\nLet\u0027s rework this here, second argument should be like this in correct order:\n\n \u0027LoadBalancerMissing\u0027\n \u0027LoadBalancerListenerMissing\u0027\n \u0027LoadBalancerPoolMissing\u0027\n \u0027LoadBalancerMemberMissing\u0027\n\nUsing \"LoadBalancerRecreating\" is wrong IMO, the warning event here is that we just detected that some Octavia resources are not there, while we expect they are.","commit_id":"269730be07acb1ccbf000eb8f518787b6181f8e4"},{"author":{"_account_id":33240,"name":"Sunday Mgbogu","email":"digitalsimboja@gmail.com","username":"digitalsimboja"},"change_message_id":"07aba8be499f4514ba5825424f69e446498dfe6d","unresolved":true,"context_lines":[{"line_number":244,"context_line":"    def _reconcile_lb(self, data):"},{"line_number":245,"context_line":"        kubernetes \u003d clients.get_kubernetes_client()"},{"line_number":246,"context_line":"        try:"},{"line_number":247,"context_line":"            if data.get(\u0027klb\u0027):"},{"line_number":248,"context_line":"                self._add_event(data[\u0027klb\u0027], \u0027LoadBalancerRecreating\u0027,"},{"line_number":249,"context_line":"                                \u0027Load balancer for the Service does  not \u0027"},{"line_number":250,"context_line":"                                \u0027exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":251,"context_line":"            if data.get(\u0027lklb\u0027):"},{"line_number":252,"context_line":"                self._add_event(data[\u0027lklb\u0027], \u0027Load Balancer listener does not\u0027"},{"line_number":253,"context_line":"                                \u0027 exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":254,"context_line":"            if data.get(\u0027pklb\u0027):"},{"line_number":255,"context_line":"                self._add_event(data[\u0027pklb\u0027], \u0027Load Balancer pool does not \u0027"},{"line_number":256,"context_line":"                                \u0027exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":257,"context_line":"            if data.get(\u0027mklb\u0027):"},{"line_number":258,"context_line":"                self._add_event(data[\u0027mklb\u0027], \u0027Load Balancer member does not \u0027"},{"line_number":259,"context_line":"                                \u0027exist anymore. Recreating it.\u0027, \u0027Warning\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"            kubernetes.patch_crd(\u0027status\u0027, data[\u0027selflink\u0027], {})"},{"line_number":262,"context_line":"        except k_exc.K8sResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":7,"id":"69b906de_d54c1932","line":259,"range":{"start_line":247,"start_character":0,"end_line":259,"end_character":75},"in_reply_to":"5c49d99b_dd907539","updated":"2022-09-01 16:45:39.000000000","message":"Ohh! I got it. Let me fix that for all. Thanks","commit_id":"269730be07acb1ccbf000eb8f518787b6181f8e4"}]}