)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"9078ce118fc6df4eb187a9fa9f71137d71d13382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"122f43d3_47347906","updated":"2022-06-15 11:34:41.000000000","message":"recheck\n\n(although there is an issue with this implementation - still investigating it with nested scenario)","commit_id":"491495c312b55cc2ecf2511dc5ac08d5a62ff61e"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"3196f7687d97785249cc4aecbff97899b64f027a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28030768_0ea05e55","updated":"2022-06-15 20:02:51.000000000","message":"recheck","commit_id":"b17cfcd8b371cf26b3a6c6f0d78e33af4b3e2859"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7493fcfa007a4c41a60981dbf5441bf2fbe8974f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1bbdb735_1b6770cf","updated":"2022-07-18 06:22:36.000000000","message":"LGTM perhaps adding a lp bug in case backports are needed","commit_id":"9f30872c36ad3e74573706cf15241356e4de19f7"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"42fa1522e7af04d0a59d8dc13a31f861204cc951","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"223faf2b_e9865a74","updated":"2022-07-17 10:01:21.000000000","message":"recheck","commit_id":"9f30872c36ad3e74573706cf15241356e4de19f7"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"2bb70e88ddd072ede1c91ffd5a395a8154757f6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ec7ed1bd_2ebb7a08","updated":"2022-07-18 05:02:14.000000000","message":"recheck","commit_id":"9f30872c36ad3e74573706cf15241356e4de19f7"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"4ef638e6eea6b99c6b427f8e1916d0fead01c396","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1f8c0cce_9cf43fa9","updated":"2022-07-20 15:58:10.000000000","message":"Hold on, I\u0027ll create a LP bug for it, as Luis suggested.","commit_id":"ee88efe8e1b524d58efed67fab265f9f1422e0dd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8a833a49a62febdf6ff65ab3e260d364619be755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3c0e9050_460cd788","updated":"2022-07-20 14:30:26.000000000","message":"Seems like with the lock situation explained in [1] won\u0027t be happening, but it doesn\u0027t hurt to leave it as is IMO.\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/846f15872488e2e6cd704067382fba71f866dea0/kuryr_kubernetes/controller/handlers/kuryrnetwork_population.py#L65-L73","commit_id":"ee88efe8e1b524d58efed67fab265f9f1422e0dd"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"92f38775c41f833bb3a03833c2d29d8fb8c635c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd7a4666_b19e53fe","updated":"2022-07-19 12:13:51.000000000","message":"recheck","commit_id":"ee88efe8e1b524d58efed67fab265f9f1422e0dd"}],"kuryr_kubernetes/controller/drivers/vif_pool.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"eb9fb36c111a515318d2c3dc18becaa72768f8c4","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        pool_key \u003d self._get_pool_key(trunk_ip, project_id, None, subnets)"},{"line_number":1081,"context_line":"        lock \u003d self._get_populate_pool_lock(pool_key)"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        if lock.acquire(timeout\u003dPOPULATE_POOL_TIMEOUT):"},{"line_number":1084,"context_line":"            try:"},{"line_number":1085,"context_line":"                pools \u003d self._available_ports_pools.get(pool_key)"},{"line_number":1086,"context_line":"                if not pools:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9afd9dc5_ffdba6f5","line":1083,"range":{"start_line":1083,"start_character":0,"end_line":1083,"end_character":55},"updated":"2022-06-24 09:03:15.000000000","message":"Do we need to raise if lock times out here?","commit_id":"b17cfcd8b371cf26b3a6c6f0d78e33af4b3e2859"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"17088e2c81bf5e5c7d2af271db60656995b9769b","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"        pool_key \u003d self._get_pool_key(trunk_ip, project_id, None, subnets)"},{"line_number":1081,"context_line":"        lock \u003d self._get_populate_pool_lock(pool_key)"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        if lock.acquire(timeout\u003dPOPULATE_POOL_TIMEOUT):"},{"line_number":1084,"context_line":"            try:"},{"line_number":1085,"context_line":"                pools \u003d self._available_ports_pools.get(pool_key)"},{"line_number":1086,"context_line":"                if not pools:"}],"source_content_type":"text/x-python","patch_set":3,"id":"e0565d9d_d92f3a56","line":1083,"range":{"start_line":1083,"start_character":0,"end_line":1083,"end_character":55},"in_reply_to":"9afd9dc5_ffdba6f5","updated":"2022-06-24 10:22:56.000000000","message":"+1, otherwise the operation won\u0027t be retried.","commit_id":"b17cfcd8b371cf26b3a6c6f0d78e33af4b3e2859"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"92f38775c41f833bb3a03833c2d29d8fb8c635c0","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"        pool_key \u003d self._get_pool_key(trunk_ip, project_id, None, subnets)"},{"line_number":1081,"context_line":"        lock \u003d self._get_populate_pool_lock(pool_key)"},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        if lock.acquire(timeout\u003dPOPULATE_POOL_TIMEOUT):"},{"line_number":1084,"context_line":"            try:"},{"line_number":1085,"context_line":"                pools \u003d self._available_ports_pools.get(pool_key)"},{"line_number":1086,"context_line":"                if not pools:"}],"source_content_type":"text/x-python","patch_set":3,"id":"46d12069_ad866ffe","line":1083,"range":{"start_line":1083,"start_character":0,"end_line":1083,"end_character":55},"in_reply_to":"e0565d9d_d92f3a56","updated":"2022-07-19 12:13:51.000000000","message":"Done","commit_id":"b17cfcd8b371cf26b3a6c6f0d78e33af4b3e2859"}]}
