)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"34a6def64994f45ff12e617cd1f07ec7f1b815ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a84bc4fa_f4af65c2","updated":"2022-09-06 14:30:16.000000000","message":"Thanks! Some small remarks:","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"c67c3be16716915eae01fd7e827f2b020a50140c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"857de8ee_6f25df59","updated":"2022-09-06 10:59:14.000000000","message":"Thanks, Michał.","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"95e2cb8f76ffccbede23ff1bbb97f98543e65bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d56e0273_cd72822e","updated":"2022-08-24 17:56:08.000000000","message":"The error seem unrelated, I\u0027ll just leave it with Zuul\u0027s -1 until first round of reviews.","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b2ebc019e5e8d512b6a9b17d91325da9edb0c2b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6c38d89_cccf9e00","updated":"2022-09-07 10:08:30.000000000","message":"looks good to me! Let\u0027s retry CI","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"8b7c64d7dae6018bde129fc65e8063a69878579b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2e6cc6f9_2d25cecd","updated":"2022-09-07 10:09:00.000000000","message":"recheck","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"64492913d18ffa42b7ee1248512ea9dbbc1d5020","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32b806ce_66d2a1fe","updated":"2022-09-14 11:07:14.000000000","message":"recheck","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"fe4d92814ef10c0d49e0028992c2ae115f237c8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8699824_e8d53ab3","updated":"2022-09-16 15:15:50.000000000","message":"recheck","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"988aad7cd5d1ef66d60cfde67b084d9928abe6f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5db53a0_6e97800b","updated":"2022-09-07 15:29:10.000000000","message":"recheck","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"}],"kuryr_kubernetes/controller/handlers/kuryrport.py":[{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"34a6def64994f45ff12e617cd1f07ec7f1b815ce","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        main_vif \u003d objects.base.VersionedObject.obj_from_primitive("},{"line_number":157,"context_line":"            kuryrport_crd[\u0027status\u0027][\u0027vifs\u0027][constants.DEFAULT_IFNAME]"},{"line_number":158,"context_line":"            [\u0027vif\u0027])"},{"line_number":159,"context_line":"        port_id \u003d utils.get_parent_port_id(main_vif)"},{"line_number":160,"context_line":"        host_ip \u003d utils.get_parent_port_ip(port_id)"},{"line_number":161,"context_line":"        pod[\u0027status\u0027] \u003d {\u0027hostIP\u0027: host_ip}"},{"line_number":162,"context_line":"        return pod"}],"source_content_type":"text/x-python","patch_set":1,"id":"a790f50b_bb4bc1e0","line":159,"updated":"2022-09-06 14:30:16.000000000","message":"the pod IP seems to be also needed because of delete_sg_rules method.","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b2ebc019e5e8d512b6a9b17d91325da9edb0c2b7","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        main_vif \u003d objects.base.VersionedObject.obj_from_primitive("},{"line_number":157,"context_line":"            kuryrport_crd[\u0027status\u0027][\u0027vifs\u0027][constants.DEFAULT_IFNAME]"},{"line_number":158,"context_line":"            [\u0027vif\u0027])"},{"line_number":159,"context_line":"        port_id \u003d utils.get_parent_port_id(main_vif)"},{"line_number":160,"context_line":"        host_ip \u003d utils.get_parent_port_ip(port_id)"},{"line_number":161,"context_line":"        pod[\u0027status\u0027] \u003d {\u0027hostIP\u0027: host_ip}"},{"line_number":162,"context_line":"        return pod"}],"source_content_type":"text/x-python","patch_set":1,"id":"d48e4b23_c73de896","line":159,"in_reply_to":"83291b73_aac29ec1","updated":"2022-09-07 10:08:30.000000000","message":"true!","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d3f795f80439b1a4252f9663f6079b7a11b1e90a","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        main_vif \u003d objects.base.VersionedObject.obj_from_primitive("},{"line_number":157,"context_line":"            kuryrport_crd[\u0027status\u0027][\u0027vifs\u0027][constants.DEFAULT_IFNAME]"},{"line_number":158,"context_line":"            [\u0027vif\u0027])"},{"line_number":159,"context_line":"        port_id \u003d utils.get_parent_port_id(main_vif)"},{"line_number":160,"context_line":"        host_ip \u003d utils.get_parent_port_ip(port_id)"},{"line_number":161,"context_line":"        pod[\u0027status\u0027] \u003d {\u0027hostIP\u0027: host_ip}"},{"line_number":162,"context_line":"        return pod"}],"source_content_type":"text/x-python","patch_set":1,"id":"83291b73_aac29ec1","line":159,"in_reply_to":"a790f50b_bb4bc1e0","updated":"2022-09-06 14:58:35.000000000","message":"It\u0027s using `get_pod_ip()` method [1] and it actually uses KuryrPort to get the IP [2].\n\n[1] https://github.com/openstack/kuryr-kubernetes/blob/e84a6a707ebd4c3d75a9dce34394d065e6499bc9/kuryr_kubernetes/controller/drivers/network_policy_security_groups.py#L318\n[2] https://github.com/openstack/kuryr-kubernetes/blob/04d4439606013688ef18f0fcdd7a4f035442b2cf/kuryr_kubernetes/controller/drivers/utils.py#L310-L322","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"34a6def64994f45ff12e617cd1f07ec7f1b815ce","unresolved":true,"context_lines":[{"line_number":170,"context_line":"                               f\"/{namespace}/pods/{name}\")"},{"line_number":171,"context_line":"            if pod[\u0027metadata\u0027][\u0027uid\u0027] !\u003d kuryrport_crd[\u0027spec\u0027][\u0027podUid\u0027]:"},{"line_number":172,"context_line":"                # Seems like this is KuryrPort created for an old Pod instance,"},{"line_number":173,"context_line":"                # with the same name. Cleaning it up instead of regular delete."},{"line_number":174,"context_line":"                raise k_exc.K8sResourceNotFound("},{"line_number":175,"context_line":"                    \u0027Pod %s\u0027 % pod[\u0027metadata\u0027][\u0027uid\u0027])"},{"line_number":176,"context_line":"        except k_exc.K8sResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7f4a646_64edd541","line":173,"range":{"start_line":173,"start_character":38,"end_line":173,"end_character":79},"updated":"2022-09-06 14:30:16.000000000","message":"will it be cleaned up upon retry?","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":27032,"name":"Maysa de Macedo Souza","email":"maysa.macedo95@gmail.com","username":"maysa"},"change_message_id":"b2ebc019e5e8d512b6a9b17d91325da9edb0c2b7","unresolved":true,"context_lines":[{"line_number":170,"context_line":"                               f\"/{namespace}/pods/{name}\")"},{"line_number":171,"context_line":"            if pod[\u0027metadata\u0027][\u0027uid\u0027] !\u003d kuryrport_crd[\u0027spec\u0027][\u0027podUid\u0027]:"},{"line_number":172,"context_line":"                # Seems like this is KuryrPort created for an old Pod instance,"},{"line_number":173,"context_line":"                # with the same name. Cleaning it up instead of regular delete."},{"line_number":174,"context_line":"                raise k_exc.K8sResourceNotFound("},{"line_number":175,"context_line":"                    \u0027Pod %s\u0027 % pod[\u0027metadata\u0027][\u0027uid\u0027])"},{"line_number":176,"context_line":"        except k_exc.K8sResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"086507e8_54f47e90","line":173,"range":{"start_line":173,"start_character":38,"end_line":173,"end_character":79},"in_reply_to":"c2e62ac4_b568cfb1","updated":"2022-09-07 10:08:30.000000000","message":"true!","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d3f795f80439b1a4252f9663f6079b7a11b1e90a","unresolved":true,"context_lines":[{"line_number":170,"context_line":"                               f\"/{namespace}/pods/{name}\")"},{"line_number":171,"context_line":"            if pod[\u0027metadata\u0027][\u0027uid\u0027] !\u003d kuryrport_crd[\u0027spec\u0027][\u0027podUid\u0027]:"},{"line_number":172,"context_line":"                # Seems like this is KuryrPort created for an old Pod instance,"},{"line_number":173,"context_line":"                # with the same name. Cleaning it up instead of regular delete."},{"line_number":174,"context_line":"                raise k_exc.K8sResourceNotFound("},{"line_number":175,"context_line":"                    \u0027Pod %s\u0027 % pod[\u0027metadata\u0027][\u0027uid\u0027])"},{"line_number":176,"context_line":"        except k_exc.K8sResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2e62ac4_b568cfb1","line":173,"range":{"start_line":173,"start_character":38,"end_line":173,"end_character":79},"in_reply_to":"e7f4a646_64edd541","updated":"2022-09-06 14:58:35.000000000","message":"No, we\u0027re raising K8sResourceNotFound here, so that it\u0027ll be caught in line 176 and cleaned up.","commit_id":"03b98adde2ddaa1fd500833cc6a2a7cf881ba964"}]}